* [PATCH] radeon: Define SI_TILE_MODE_COLOR_2D_SCANOUT_8BPP for consistency and readability
@ 2016-02-12 0:29 Alexandre Demers
2016-02-12 7:36 ` Michel Dänzer
0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Demers @ 2016-02-12 0:29 UTC (permalink / raw)
To: dri-devel; +Cc: alexander.deucher
---
drivers/gpu/drm/radeon/atombios_crtc.c | 2 +-
include/uapi/drm/radeon_drm.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c b/drivers/gpu/drm/radeon/atombios_crtc.c
index 801dd60..c88f9fe 100644
--- a/drivers/gpu/drm/radeon/atombios_crtc.c
+++ b/drivers/gpu/drm/radeon/atombios_crtc.c
@@ -1287,7 +1287,7 @@ static int dce4_crtc_do_set_base(struct drm_crtc *crtc,
} else {
switch (target_fb->bits_per_pixel) {
case 8:
- index = 10;
+ index = SI_TILE_MODE_COLOR_2D_SCANOUT_8BPP;
break;
case 16:
index = SI_TILE_MODE_COLOR_2D_SCANOUT_16BPP;
diff --git a/include/uapi/drm/radeon_drm.h b/include/uapi/drm/radeon_drm.h
index ccb9bcd..407a092 100644
--- a/include/uapi/drm/radeon_drm.h
+++ b/include/uapi/drm/radeon_drm.h
@@ -1057,6 +1057,7 @@ struct drm_radeon_info {
#define SI_TILE_MODE_COLOR_2D_16BPP 15
#define SI_TILE_MODE_COLOR_2D_32BPP 16
#define SI_TILE_MODE_COLOR_2D_64BPP 17
+#define SI_TILE_MODE_COLOR_2D_SCANOUT_8BPP 10
#define SI_TILE_MODE_COLOR_2D_SCANOUT_16BPP 11
#define SI_TILE_MODE_COLOR_2D_SCANOUT_32BPP 12
#define SI_TILE_MODE_DEPTH_STENCIL_1D 4
--
2.7.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] radeon: Define SI_TILE_MODE_COLOR_2D_SCANOUT_8BPP for consistency and readability
2016-02-12 0:29 [PATCH] radeon: Define SI_TILE_MODE_COLOR_2D_SCANOUT_8BPP for consistency and readability Alexandre Demers
@ 2016-02-12 7:36 ` Michel Dänzer
0 siblings, 0 replies; 2+ messages in thread
From: Michel Dänzer @ 2016-02-12 7:36 UTC (permalink / raw)
To: Alexandre Demers; +Cc: dri-devel
On 12.02.2016 09:29, Alexandre Demers wrote:
> ---
> drivers/gpu/drm/radeon/atombios_crtc.c | 2 +-
> include/uapi/drm/radeon_drm.h | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c b/drivers/gpu/drm/radeon/atombios_crtc.c
> index 801dd60..c88f9fe 100644
> --- a/drivers/gpu/drm/radeon/atombios_crtc.c
> +++ b/drivers/gpu/drm/radeon/atombios_crtc.c
> @@ -1287,7 +1287,7 @@ static int dce4_crtc_do_set_base(struct drm_crtc *crtc,
> } else {
> switch (target_fb->bits_per_pixel) {
> case 8:
> - index = 10;
> + index = SI_TILE_MODE_COLOR_2D_SCANOUT_8BPP;
> break;
> case 16:
> index = SI_TILE_MODE_COLOR_2D_SCANOUT_16BPP;
> diff --git a/include/uapi/drm/radeon_drm.h b/include/uapi/drm/radeon_drm.h
> index ccb9bcd..407a092 100644
> --- a/include/uapi/drm/radeon_drm.h
> +++ b/include/uapi/drm/radeon_drm.h
> @@ -1057,6 +1057,7 @@ struct drm_radeon_info {
> #define SI_TILE_MODE_COLOR_2D_16BPP 15
> #define SI_TILE_MODE_COLOR_2D_32BPP 16
> #define SI_TILE_MODE_COLOR_2D_64BPP 17
> +#define SI_TILE_MODE_COLOR_2D_SCANOUT_8BPP 10
> #define SI_TILE_MODE_COLOR_2D_SCANOUT_16BPP 11
> #define SI_TILE_MODE_COLOR_2D_SCANOUT_32BPP 12
> #define SI_TILE_MODE_DEPTH_STENCIL_1D 4
>
The shortlog (subject line) is a bit long, but other than that,
Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-12 7:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-12 0:29 [PATCH] radeon: Define SI_TILE_MODE_COLOR_2D_SCANOUT_8BPP for consistency and readability Alexandre Demers
2016-02-12 7:36 ` Michel Dänzer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.