All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] efidisk: prevent errors from diskfilter scan of removable drives
Date: Fri, 12 Feb 2016 15:49:37 +0100	[thread overview]
Message-ID: <56BDF101.80003@gmail.com> (raw)
In-Reply-To: <CAA91j0W7ADgXRpc=1FC-ibR3a6uGfLCSnjWMJNA-Z4sF9aVOoQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1462 bytes --]

On 12.02.2016 15:38, Andrei Borzenkov wrote:
> On Fri, Feb 12, 2016 at 5:29 PM, Vladimir 'φ-coder/phcoder' Serbinenko
> <phcoder@gmail.com> wrote:
>> On 05.02.2016 17:56, Andrei Borzenkov wrote:
>>> Map EFI_NO_MEDIA to GRUB_ERR_OUT_OF_RANGE that is ignored by diskfilter. This
>>> actually matches pretty close (we obviously attempt to read outside of media)
>>> and avoids adding more error codes.
>>>
>>> This affects only internally initiated scans. If read/write from removable is
>>> explicitly requested, we still return an error and text explanation is more
>>> clear for user than generic error.
>>>
>>> Reported and tested by Andreas Loew <Andreas.Loew@gmx.net>
>>>
>> I feel like we should be fixing diskfilter. Consider another case: dead
>> disk dangling on cable and returning mostly I/O errors
> 
> Could you explain what do you mean? Removable media detection remains
> valid case and cannot be solved without low level driver cooperation
> anyway. If you mean some ratelimiting, this probably has to go into
> core, not in diskfilter, but it looks orthogonal to this patch.
> 
I mean what if we have a legitimately bad disk unrelated to any
diskfilter VGs. If diskfilter is unable to read from it, it should still
be able to assemble VGs and skip failed disk
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]

  reply	other threads:[~2016-02-12 14:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-05 16:56 [PATCH] efidisk: prevent errors from diskfilter scan of removable drives Andrei Borzenkov
2016-02-12 14:29 ` Vladimir 'φ-coder/phcoder' Serbinenko
2016-02-12 14:38   ` Andrei Borzenkov
2016-02-12 14:49     ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2016-02-13  5:41       ` Andrei Borzenkov
2016-02-26 13:41         ` Vladimir 'phcoder' Serbinenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56BDF101.80003@gmail.com \
    --to=phcoder@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.