Re: [PATCH v2 02/11] tests: acpi: test NVDIMM tables

[Xiao Guangrong <guangrong.xiao@linux.intel.com>]

On 02/05/2016 12:20 AM, Michael S. Tsirkin wrote:
> On Wed, Jan 13, 2016 at 02:50:01AM +0800, Xiao Guangrong wrote:
>> Add nvdimm test, two tables are created which are NFIT and
>> SSDT
>>
>> Max memory size and multiple slots are needed to enable NVDIMM which
>> cause the primal SSDT table is also updated
>>
>> Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
>
> First don't include binary in patches directly please.

Okay.

>
>> ---
>>   tests/acpi-test-data/pc/NFIT                | Bin 0 -> 224 bytes
>>   tests/acpi-test-data/pc/NFIT.bridge         | Bin 0 -> 224 bytes
>>   tests/acpi-test-data/pc/SSDT                | Bin 2486 -> 2885 bytes
>>   tests/acpi-test-data/pc/SSDT-NVDIMM         | Bin 0 -> 134 bytes
>>   tests/acpi-test-data/pc/SSDT-NVDIMM.bridge  | Bin 0 -> 134 bytes
>>   tests/acpi-test-data/pc/SSDT.bridge         | Bin 4345 -> 4745 bytes
>>   tests/acpi-test-data/q35/NFIT               | Bin 0 -> 224 bytes
>>   tests/acpi-test-data/q35/NFIT.bridge        | Bin 0 -> 224 bytes
>>   tests/acpi-test-data/q35/SSDT               | Bin 691 -> 1090 bytes
>>   tests/acpi-test-data/q35/SSDT-NVDIMM        | Bin 0 -> 134 bytes
>>   tests/acpi-test-data/q35/SSDT-NVDIMM.bridge | Bin 0 -> 134 bytes
>>   tests/acpi-test-data/q35/SSDT.bridge        | Bin 708 -> 1107 bytes
>>   tests/bios-tables-test.c                    |  15 ++++++++++-----
>
> So let's add an new test, and there only test the NVDIMM tables and only
> with one configuration.
>
> Otherwise number of tables to maintain explodes.
>
> You will have to teach test to ignore everything
> that does not have NVDIMM in name for this test.
>

Okay, i will it as the single test and make it as a separate patchset.