Re: [Qemu-devel] [PATCH v2 00/13] cuda: misc fixes and cleanups

["Hervé Poussineau" <hpoussin@reactos.org>]

Le 14/02/2016 20:01, Mark Cave-Ayland a écrit :
> On 07/02/16 20:34, Hervé Poussineau wrote:
>
>> Hi,
>>
>> This patchset cleans up a little bit the Apple CUDA emulation:
>> - correctly reject commands with wrong parameters
>> - support changing the frequency of auto-polling
>> - support changing device list probed in auto-poll
>> - add logs when using FILE_SERVER_FLAG/SET_POWER_MESSAGE
>> - remove unused commands (GET/SET_6805_ADDR)
>> - remove unimplemented GET_SET_IIC/COMBINED_FORMAT_IIC
>>
>> GET_SET_IIC/COMBINED_FORMAT_IIC commands should be added again once
>> we implement the I2C bus provided by CUDA.
>>
>> Hervé
>>
>> Hervé Poussineau (13):
>>    cuda: add a framework to handle commands
>>    cuda: move unknown commands reject out of switch
>>    cuda: port AUTOPOLL command to new framework
>>    cuda: port SET_AUTO_RATE command to new framework
>>    cuda: port SET_DEVICE_LIST command to new framework
>>    cuda: port POWERDOWN command to new framework
>>    cuda: port RESET_SYSTEM command to new framework
>>    cuda: port FILE_SERVER_FLAG command to new framework
>>    cuda: port SET_POWER_MESSAGES command to new framework
>>    cuda: port GET_TIME command to new framework
>>    cuda: port SET_TIME command to new framework
>>    cuda: remove GET_6805_ADDR command
>>    cuda: remove CUDA_GET_SET_IIC/CUDA_COMBINED_FORMAT_IIC commands
>>
>>   hw/input/adb.c         |  18 ++--
>>   hw/misc/macio/cuda.c   | 279 ++++++++++++++++++++++++++++++++++++-------------
>>   hw/ppc/mac.h           |   2 +
>>   include/hw/input/adb.h |   2 +-
>>   4 files changed, 217 insertions(+), 84 deletions(-)
>
> Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>
> This looks good to me, and again passes all my local tests. The only
> thing I noticed was that there were no changes related to
> qemu_log_mask() as per David's comments on patch 2 but other than that I
> think this patchset is fine to merge for 2.6.

qemu_log_mask() doesn't represent the same thing than trace events, even if they can go to the same output file.
I always run QEMU with -d guest_errors,unimp to see if something wrong happens on guest side.
I have no knowledge of all traces in all devices, to know which ones are important at first run.
However, if I want to detail one device behaviour, I can enable specific traces for this device.

Note also that new qemu_log_mask() calls are added, like in cc28296d82ce179e81ee6d0b9cfb7f6a79ffc1c6

Hervé