Re: [Qemu-devel] [PATCH v2 00/13] cuda: misc fixes and cleanups

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 2285 bytes --]

On Sun, Feb 14, 2016 at 07:01:48PM +0000, Mark Cave-Ayland wrote:
> On 07/02/16 20:34, Hervé Poussineau wrote:
> 
> > Hi,
> > 
> > This patchset cleans up a little bit the Apple CUDA emulation:
> > - correctly reject commands with wrong parameters
> > - support changing the frequency of auto-polling
> > - support changing device list probed in auto-poll
> > - add logs when using FILE_SERVER_FLAG/SET_POWER_MESSAGE
> > - remove unused commands (GET/SET_6805_ADDR)
> > - remove unimplemented GET_SET_IIC/COMBINED_FORMAT_IIC
> > 
> > GET_SET_IIC/COMBINED_FORMAT_IIC commands should be added again once
> > we implement the I2C bus provided by CUDA.
> > 
> > Hervé
> > 
> > Hervé Poussineau (13):
> >   cuda: add a framework to handle commands
> >   cuda: move unknown commands reject out of switch
> >   cuda: port AUTOPOLL command to new framework
> >   cuda: port SET_AUTO_RATE command to new framework
> >   cuda: port SET_DEVICE_LIST command to new framework
> >   cuda: port POWERDOWN command to new framework
> >   cuda: port RESET_SYSTEM command to new framework
> >   cuda: port FILE_SERVER_FLAG command to new framework
> >   cuda: port SET_POWER_MESSAGES command to new framework
> >   cuda: port GET_TIME command to new framework
> >   cuda: port SET_TIME command to new framework
> >   cuda: remove GET_6805_ADDR command
> >   cuda: remove CUDA_GET_SET_IIC/CUDA_COMBINED_FORMAT_IIC commands
> > 
> >  hw/input/adb.c         |  18 ++--
> >  hw/misc/macio/cuda.c   | 279 ++++++++++++++++++++++++++++++++++++-------------
> >  hw/ppc/mac.h           |   2 +
> >  include/hw/input/adb.h |   2 +-
> >  4 files changed, 217 insertions(+), 84 deletions(-)
> 
> Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> 
> This looks good to me, and again passes all my local tests. The only
> thing I noticed was that there were no changes related to
> qemu_log_mask() as per David's comments on patch 2 but other than that I
> think this patchset is fine to merge for 2.6.

Thanks for this, I've merged the series to ppc-for-2.6.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]