From: John Crispin <blogic@openwrt.org>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
Henry Chen <henryc.chen@mediatek.com>,
Thierry Reding <treding@nvidia.com>,
Flora Fu <flora.fu@mediatek.com>,
Steven Liu <steven.liu@mediatek.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V5 04/11] soc: mediatek: PMIC wrap: split SoC specific init into callback
Date: Sun, 14 Feb 2016 22:01:38 +0100 [thread overview]
Message-ID: <56C0EB32.4080701@openwrt.org> (raw)
In-Reply-To: <56BC7674.9030706@gmail.com>
On 11/02/2016 12:54, Matthias Brugger wrote:
>> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c
>> b/drivers/soc/mediatek/mtk-pmic-wrap.c
>> index b22b664..e3bbee5 100644
>> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
>> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
>> @@ -372,6 +372,7 @@ struct pmic_wrapper_type {
>> enum pwrap_type type;
>> u32 arb_en_all;
>> int (*init_reg_clock)(struct pmic_wrapper *wrp);
>> + int (*init_special)(struct pmic_wrapper *wrp);
>
> Nit:
> I wonder if we can find a better name for the callback, as init_special
> sounds quite generic to me.
>
> Thanks,
> Matthias
Hi,
At first I considered enable_wrapper as the mt8135/8173 code seems to do
just that. however mt2701 does an init of the ADC. So how about using
init_soc_specific ?
John
WARNING: multiple messages have this Message-ID (diff)
From: blogic@openwrt.org (John Crispin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V5 04/11] soc: mediatek: PMIC wrap: split SoC specific init into callback
Date: Sun, 14 Feb 2016 22:01:38 +0100 [thread overview]
Message-ID: <56C0EB32.4080701@openwrt.org> (raw)
In-Reply-To: <56BC7674.9030706@gmail.com>
On 11/02/2016 12:54, Matthias Brugger wrote:
>> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c
>> b/drivers/soc/mediatek/mtk-pmic-wrap.c
>> index b22b664..e3bbee5 100644
>> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
>> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
>> @@ -372,6 +372,7 @@ struct pmic_wrapper_type {
>> enum pwrap_type type;
>> u32 arb_en_all;
>> int (*init_reg_clock)(struct pmic_wrapper *wrp);
>> + int (*init_special)(struct pmic_wrapper *wrp);
>
> Nit:
> I wonder if we can find a better name for the callback, as init_special
> sounds quite generic to me.
>
> Thanks,
> Matthias
Hi,
At first I considered enable_wrapper as the mt8135/8173 code seems to do
just that. however mt2701 does an init of the ADC. So how about using
init_soc_specific ?
John
next prev parent reply other threads:[~2016-02-14 21:01 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-07 10:42 [PATCH V5 00/11] soc: mediatek: PMIC wrap: add MT6323/2701/7623 support John Crispin
2016-02-07 10:42 ` John Crispin
2016-02-07 10:42 ` John Crispin
[not found] ` <1454841778-35529-1-git-send-email-blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2016-02-07 10:42 ` [PATCH V5 01/11] dt-bindings: ARM: Mediatek: add MT2701/7623 string to the PMIC wrapper doc John Crispin
2016-02-07 10:42 ` John Crispin
2016-02-07 10:42 ` John Crispin
2016-02-07 10:42 ` [PATCH V5 02/11] soc: mediatek: PMIC wrap: don't duplicate the wrapper data John Crispin
2016-02-07 10:42 ` John Crispin
2016-02-07 10:42 ` John Crispin
2016-02-07 10:42 ` [PATCH V5 03/11] soc: mediatek: PMIC wrap: add wrapper callbacks for init_reg_clock John Crispin
2016-02-07 10:42 ` John Crispin
2016-02-07 10:42 ` John Crispin
2016-02-07 10:42 ` [PATCH V5 05/11] soc: mediatek: PMIC wrap: WRAP_INT_EN needs a different bitmask for MT2701/7623 John Crispin
2016-02-07 10:42 ` John Crispin
2016-02-07 10:42 ` John Crispin
2016-02-07 10:42 ` [PATCH V5 06/11] soc: mediatek: PMIC wrap: SPI_WRITE " John Crispin
2016-02-07 10:42 ` John Crispin
2016-02-07 10:42 ` John Crispin
2016-02-11 11:59 ` Matthias Brugger
2016-02-11 11:59 ` Matthias Brugger
2016-02-07 10:42 ` [PATCH V5 04/11] soc: mediatek: PMIC wrap: split SoC specific init into callback John Crispin
2016-02-07 10:42 ` John Crispin
2016-02-07 10:42 ` John Crispin
2016-02-11 11:54 ` Matthias Brugger
2016-02-11 11:54 ` Matthias Brugger
2016-02-14 21:01 ` John Crispin [this message]
2016-02-14 21:01 ` John Crispin
2016-02-17 16:55 ` Matthias Brugger
2016-02-17 16:55 ` Matthias Brugger
2016-02-07 10:42 ` [PATCH V5 07/11] soc: mediatek: PMIC wrap: move wdt_src into the pmic_wrapper_type struct John Crispin
2016-02-07 10:42 ` John Crispin
2016-02-07 10:42 ` John Crispin
2016-02-11 12:00 ` Matthias Brugger
2016-02-11 12:00 ` Matthias Brugger
2016-02-07 10:42 ` [PATCH V5 08/11] soc: mediatek: PMIC wrap: remove pwrap_is_mt8135() and pwrap_is_mt8173() John Crispin
2016-02-07 10:42 ` John Crispin
2016-02-11 12:01 ` Matthias Brugger
2016-02-11 12:01 ` Matthias Brugger
2016-02-07 10:42 ` [PATCH V5 09/11] soc: mediatek: PMIC wrap: add a slave specific struct John Crispin
2016-02-07 10:42 ` John Crispin
2016-02-11 11:25 ` Matthias Brugger
2016-02-11 11:25 ` Matthias Brugger
2016-02-07 10:42 ` [PATCH V5 10/11] soc: mediatek: PMIC wrap: add mt6323 slave support John Crispin
2016-02-07 10:42 ` John Crispin
2016-02-11 11:27 ` Matthias Brugger
2016-02-11 11:27 ` Matthias Brugger
2016-02-07 10:42 ` [PATCH V5 11/11] soc: mediatek: PMIC wrap: add MT2701/7623 support John Crispin
2016-02-07 10:42 ` John Crispin
2016-02-11 11:41 ` Matthias Brugger
2016-02-11 11:41 ` Matthias Brugger
2016-02-11 11:46 ` [PATCH V5 00/11] soc: mediatek: PMIC wrap: add MT6323/2701/7623 support Matthias Brugger
2016-02-11 11:46 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C0EB32.4080701@openwrt.org \
--to=blogic@openwrt.org \
--cc=flora.fu@mediatek.com \
--cc=henryc.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=steven.liu@mediatek.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.