From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Laxman Dewangan <ldewangan@nvidia.com>,
lee.jones@linaro.org, alexandre.belloni@free-electrons.com,
javier@osg.samsung.com, broonie@kernel.org,
gregkh@linuxfoundation.org, a.zummo@towertech.it
Cc: cw00.choi@samsung.com, linux-kernel@vger.kernel.org,
rtc-linux@googlegroups.com
Subject: [rtc-linux] Re: [PATCH V7 4/5] mfd: max77686: do not set i2c client data for rtc i2c client
Date: Mon, 15 Feb 2016 08:46:39 +0900 [thread overview]
Message-ID: <56C111DF.2020005@samsung.com> (raw)
In-Reply-To: <1455038794-9921-5-git-send-email-ldewangan@nvidia.com>
On 10.02.2016 02:26, Laxman Dewangan wrote:
> There is different RTC I2C address for RTC block in MAX77686.
> Driver is creating dummy i2c client for this address to access
> the register of this IP block.
>
> As there is no call to i2c_get_clientdata() for rtc_i2c client,
> there is no need to store pointer and hence removing the call
> to set client data for rtc i2c client.
>
> Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> CC: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> CC: Javier Martinez Canillas <javier@osg.samsung.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Tested-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
FWIW, on max77686:
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Laxman Dewangan <ldewangan@nvidia.com>,
lee.jones@linaro.org, alexandre.belloni@free-electrons.com,
javier@osg.samsung.com, broonie@kernel.org,
gregkh@linuxfoundation.org, a.zummo@towertech.it
Cc: cw00.choi@samsung.com, linux-kernel@vger.kernel.org,
rtc-linux@googlegroups.com
Subject: Re: [PATCH V7 4/5] mfd: max77686: do not set i2c client data for rtc i2c client
Date: Mon, 15 Feb 2016 08:46:39 +0900 [thread overview]
Message-ID: <56C111DF.2020005@samsung.com> (raw)
In-Reply-To: <1455038794-9921-5-git-send-email-ldewangan@nvidia.com>
On 10.02.2016 02:26, Laxman Dewangan wrote:
> There is different RTC I2C address for RTC block in MAX77686.
> Driver is creating dummy i2c client for this address to access
> the register of this IP block.
>
> As there is no call to i2c_get_clientdata() for rtc_i2c client,
> there is no need to store pointer and hence removing the call
> to set client data for rtc i2c client.
>
> Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> CC: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> CC: Javier Martinez Canillas <javier@osg.samsung.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Tested-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
FWIW, on max77686:
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-02-14 23:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 17:26 [rtc-linux] [PATCH V7 0/5] rtc: max77686: make max77686 rtc driver as IP driver Laxman Dewangan
2016-02-09 17:26 ` Laxman Dewangan
2016-02-09 17:26 ` [rtc-linux] [PATCH V7 1/5] rtc: max77686: fix checkpatch error Laxman Dewangan
2016-02-09 17:26 ` Laxman Dewangan
2016-02-09 17:26 ` [rtc-linux] [PATCH V7 2/5] rtc: max77686: use rtc regmap to access RTC registers Laxman Dewangan
2016-02-09 17:26 ` Laxman Dewangan
2016-02-09 17:26 ` [rtc-linux] [PATCH V7 3/5] rtc: max77686: avoid reference of parent device info multiple places Laxman Dewangan
2016-02-09 17:26 ` Laxman Dewangan
2016-02-09 17:26 ` [rtc-linux] [PATCH V7 4/5] mfd: max77686: do not set i2c client data for rtc i2c client Laxman Dewangan
2016-02-09 17:26 ` Laxman Dewangan
2016-02-10 16:09 ` [rtc-linux] " Lee Jones
2016-02-10 16:09 ` Lee Jones
2016-02-14 23:46 ` Krzysztof Kozlowski [this message]
2016-02-14 23:46 ` Krzysztof Kozlowski
2016-02-09 17:26 ` [rtc-linux] [PATCH V7 5/5] rtc: max77686: move initialisation of rtc regmap, irq chip locally Laxman Dewangan
2016-02-09 17:26 ` Laxman Dewangan
2016-02-10 16:08 ` [rtc-linux] " Lee Jones
2016-02-10 16:08 ` Lee Jones
2016-02-14 23:48 ` [rtc-linux] " Krzysztof Kozlowski
2016-02-14 23:48 ` Krzysztof Kozlowski
2016-02-16 1:09 ` [rtc-linux] Re: [PATCH V7 0/5] rtc: max77686: make max77686 rtc driver as IP driver Alexandre Belloni
2016-02-16 1:09 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C111DF.2020005@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=javier@osg.samsung.com \
--cc=ldewangan@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.