From: Thomas Huth <thuth@redhat.com>
To: Andrew Jones <drjones@redhat.com>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org
Cc: dgibson@redhat.com, david@gibson.dropbear.id.au, agraf@suse.de,
lvivier@redhat.com, pbonzini@redhat.com
Subject: Re: [kvm-unit-tests PATCH v3 01/17] arm/arm64: trivial: another assert fix
Date: Mon, 15 Feb 2016 06:38:38 +0000 [thread overview]
Message-ID: <56C1726E.1050101@redhat.com> (raw)
In-Reply-To: <1455380910-30604-2-git-send-email-drjones@redhat.com>
On 13.02.2016 17:28, Andrew Jones wrote:
> Signed-off-by: Andrew Jones <drjones@redhat.com>
>
> ---
> Unrelated to the powerpc initial drop, but found it while working
> on that, so just posting it now. Anyway, it's a trivial fix.
> ---
> lib/arm/io.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/arm/io.c b/lib/arm/io.c
> index a08d394e4aa1c..a111530f4802d 100644
> --- a/lib/arm/io.c
> +++ b/lib/arm/io.c
> @@ -50,7 +50,8 @@ static void uart0_init(void)
> }
>
> } else {
> - assert(dt_pbus_translate_node(ret, 0, &base) = 0);
> + ret = dt_pbus_translate_node(ret, 0, &base);
> + assert(ret = 0);
> }
>
> uart0_base = ioremap(base.addr, base.size);
Reviewed-by: Thomas Huth <thuth@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Huth <thuth@redhat.com>
To: Andrew Jones <drjones@redhat.com>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org
Cc: dgibson@redhat.com, david@gibson.dropbear.id.au, agraf@suse.de,
lvivier@redhat.com, pbonzini@redhat.com
Subject: Re: [kvm-unit-tests PATCH v3 01/17] arm/arm64: trivial: another assert fix
Date: Mon, 15 Feb 2016 07:38:38 +0100 [thread overview]
Message-ID: <56C1726E.1050101@redhat.com> (raw)
In-Reply-To: <1455380910-30604-2-git-send-email-drjones@redhat.com>
On 13.02.2016 17:28, Andrew Jones wrote:
> Signed-off-by: Andrew Jones <drjones@redhat.com>
>
> ---
> Unrelated to the powerpc initial drop, but found it while working
> on that, so just posting it now. Anyway, it's a trivial fix.
> ---
> lib/arm/io.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/arm/io.c b/lib/arm/io.c
> index a08d394e4aa1c..a111530f4802d 100644
> --- a/lib/arm/io.c
> +++ b/lib/arm/io.c
> @@ -50,7 +50,8 @@ static void uart0_init(void)
> }
>
> } else {
> - assert(dt_pbus_translate_node(ret, 0, &base) == 0);
> + ret = dt_pbus_translate_node(ret, 0, &base);
> + assert(ret == 0);
> }
>
> uart0_base = ioremap(base.addr, base.size);
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2016-02-15 6:38 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-13 16:28 [kvm-unit-tests PATCH v3 00/17] ppc64: initial drop Andrew Jones
2016-02-13 16:28 ` Andrew Jones
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 01/17] arm/arm64: trivial: another assert fix Andrew Jones
2016-02-13 16:28 ` Andrew Jones
2016-02-14 22:55 ` David Gibson
2016-02-14 22:55 ` David Gibson
2016-02-15 6:38 ` Thomas Huth [this message]
2016-02-15 6:38 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 02/17] Makefile: cscope: also look in arch shared asm Andrew Jones
2016-02-13 16:28 ` Andrew Jones
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 03/17] lib: asm-generic: add missing casts Andrew Jones
2016-02-13 16:28 ` Andrew Jones
2016-02-14 22:57 ` David Gibson
2016-02-14 22:57 ` David Gibson
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 04/17] devicetree: fix dt_get_memory_params Andrew Jones
2016-02-13 16:28 ` Andrew Jones
2016-02-14 23:00 ` David Gibson
2016-02-14 23:00 ` David Gibson
2016-02-15 7:22 ` Thomas Huth
2016-02-15 7:22 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 05/17] arm/arm64: setup improvements Andrew Jones
2016-02-13 16:28 ` Andrew Jones
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 06/17] lib: share arm-selftest utility functions Andrew Jones
2016-02-13 16:28 ` Andrew Jones
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 07/17] config: no need to mix arch makefiles Andrew Jones
2016-02-13 16:28 ` Andrew Jones
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 08/17] powerpc/ppc64: start skeleton framework Andrew Jones
2016-02-13 16:28 ` Andrew Jones
2016-02-15 7:28 ` Thomas Huth
2016-02-15 7:28 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 09/17] powerpc/ppc64: ppc-ify makefiles and linker script Andrew Jones
2016-02-13 16:28 ` Andrew Jones
2016-02-15 7:46 ` Thomas Huth
2016-02-15 7:46 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 10/17] powerpc/ppc64: add a boot rom Andrew Jones
2016-02-13 16:28 ` Andrew Jones
2016-02-15 8:00 ` Thomas Huth
2016-02-15 8:00 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 11/17] powerpc/ppc64: add hcall support and putchar Andrew Jones
2016-02-13 16:28 ` Andrew Jones
2016-02-14 23:29 ` David Gibson
2016-02-14 23:29 ` David Gibson
2016-02-15 8:44 ` Thomas Huth
2016-02-15 8:44 ` Thomas Huth
2016-02-15 8:54 ` Andrew Jones
2016-02-15 8:54 ` Andrew Jones
2016-02-15 8:58 ` Thomas Huth
2016-02-15 8:58 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 12/17] powerpc/ppc64: adapt arm's setup Andrew Jones
2016-02-13 16:28 ` Andrew Jones
2016-02-15 9:01 ` Thomas Huth
2016-02-15 9:01 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 13/17] powerpc/ppc64: relocate linker VMAs Andrew Jones
2016-02-13 16:28 ` Andrew Jones
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 14/17] powerpc/ppc64: add run script and unittests.cfg Andrew Jones
2016-02-13 16:28 ` Andrew Jones
2016-02-15 9:36 ` Thomas Huth
2016-02-15 9:36 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 15/17] mkstandalone: add support for powerpc Andrew Jones
2016-02-13 16:28 ` Andrew Jones
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 16/17] powerpc/ppc64: add RTAS support Andrew Jones
2016-02-13 16:28 ` Andrew Jones
2016-02-13 17:18 ` Andrew Jones
2016-02-13 17:18 ` Andrew Jones
2016-02-15 9:59 ` Thomas Huth
2016-02-15 9:59 ` Thomas Huth
2016-02-15 12:00 ` Andrew Jones
2016-02-15 12:00 ` Andrew Jones
2016-02-15 12:15 ` Thomas Huth
2016-02-15 12:15 ` Thomas Huth
2016-02-13 16:28 ` [kvm-unit-tests PATCH v3 17/17] powerpc/ppc64: make a fake debug-exit Andrew Jones
2016-02-13 16:28 ` Andrew Jones
2016-02-15 10:01 ` Thomas Huth
2016-02-15 10:01 ` Thomas Huth
2016-02-15 10:37 ` [kvm-unit-tests PATCH v3 00/17] ppc64: initial drop Laurent Vivier
2016-02-15 10:37 ` Laurent Vivier
2016-02-15 12:08 ` Andrew Jones
2016-02-15 12:08 ` Andrew Jones
2016-02-15 12:12 ` Laurent Vivier
2016-02-15 12:12 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C1726E.1050101@redhat.com \
--to=thuth@redhat.com \
--cc=agraf@suse.de \
--cc=david@gibson.dropbear.id.au \
--cc=dgibson@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.