From: "Mika Penttilä" <mika.penttila@nextfour.com>
To: LKML <linux-kernel@vger.kernel.org>, <mail@maciej.szmigiero.name>,
<fabio.estevam@nxp.com>
Subject: [REGRESSION, bisected] 4.5rc4 sound fsl-soc
Date: Mon, 15 Feb 2016 13:25:19 +0200 [thread overview]
Message-ID: <56C1B59F.4040204@nextfour.com> (raw)
Hi,
The following commit :
5c408fee254633a5be69505bc86c6b034f871ab4 is the first bad commit
commit 5c408fee254633a5be69505bc86c6b034f871ab4
Author: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Date: Mon Jan 18 20:07:44 2016 +0100
ASoC: fsl_ssi: remove explicit register defaults
There is no guarantee that on fsl_ssi module load
SSI registers will have their power-on-reset values.
In fact, if the driver is reloaded the values in
registers will be whatever they were set to previously.
However, the cache needs to be fully populated at probe
time to avoid non-atomic allocations during register
access.
Special case here is imx21-class SSI, since
according to datasheet it don't have SACC{ST,EN,DIS}
regs.
This fixes hard lockup on fsl_ssi module reload,
at least in AC'97 mode.
Fixes: 05cf237972fe ("ASoC: fsl_ssi: Add driver suspend and resume to support MEGA Fast")
Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Tested-by: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
causes regmap init failure when loading the sgtl5000 codec on imx6q, and
leads to no audio.
With the mentioned patch reverted sound works ok.
--Mika
next reply other threads:[~2016-02-15 11:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 11:25 Mika Penttilä [this message]
2016-02-15 11:30 ` [REGRESSION, bisected] 4.5rc4 sound fsl-soc Fabio Estevam
2016-02-15 15:59 ` Fabio Estevam
[not found] ` <56C1CBD3.4000900@nextfour.com>
[not found] ` <AM2PR04MB06909856C3BE6BBBDBC35CD7E3A10@AM2PR04MB0690.eurprd04.prod.outlook.com>
2016-02-20 20:57 ` Mika Penttilä
2016-02-20 21:21 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C1B59F.4040204@nextfour.com \
--to=mika.penttila@nextfour.com \
--cc=fabio.estevam@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.