* [REGRESSION, bisected] 4.5rc4 sound fsl-soc
@ 2016-02-15 11:25 Mika Penttilä
2016-02-15 11:30 ` Fabio Estevam
0 siblings, 1 reply; 5+ messages in thread
From: Mika Penttilä @ 2016-02-15 11:25 UTC (permalink / raw)
To: LKML, mail, fabio.estevam
Hi,
The following commit :
5c408fee254633a5be69505bc86c6b034f871ab4 is the first bad commit
commit 5c408fee254633a5be69505bc86c6b034f871ab4
Author: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Date: Mon Jan 18 20:07:44 2016 +0100
ASoC: fsl_ssi: remove explicit register defaults
There is no guarantee that on fsl_ssi module load
SSI registers will have their power-on-reset values.
In fact, if the driver is reloaded the values in
registers will be whatever they were set to previously.
However, the cache needs to be fully populated at probe
time to avoid non-atomic allocations during register
access.
Special case here is imx21-class SSI, since
according to datasheet it don't have SACC{ST,EN,DIS}
regs.
This fixes hard lockup on fsl_ssi module reload,
at least in AC'97 mode.
Fixes: 05cf237972fe ("ASoC: fsl_ssi: Add driver suspend and resume to support MEGA Fast")
Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Tested-by: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
causes regmap init failure when loading the sgtl5000 codec on imx6q, and
leads to no audio.
With the mentioned patch reverted sound works ok.
--Mika
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [REGRESSION, bisected] 4.5rc4 sound fsl-soc 2016-02-15 11:25 [REGRESSION, bisected] 4.5rc4 sound fsl-soc Mika Penttilä @ 2016-02-15 11:30 ` Fabio Estevam 2016-02-15 15:59 ` Fabio Estevam [not found] ` <56C1CBD3.4000900@nextfour.com> 0 siblings, 2 replies; 5+ messages in thread From: Fabio Estevam @ 2016-02-15 11:30 UTC (permalink / raw) To: Mika Penttilä, LKML, mail@maciej.szmigiero.name, festevam@gmail.com, broonie@kernel.org [Sorry for the top post, can't reply properly from this Inbox] Could you please try applying this commit from linux-next? https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/base/regmap/regcache.c?id=3245d460a1eb55b5c3ca31dde7b5c5ac71546edf Thanks, Fabio Estevam ________________________________________ From: Mika Penttilä <mika.penttila@nextfour.com> Sent: Monday, February 15, 2016 9:25 AM To: LKML; mail@maciej.szmigiero.name; Fabio Estevam Subject: [REGRESSION, bisected] 4.5rc4 sound fsl-soc Hi, The following commit : 5c408fee254633a5be69505bc86c6b034f871ab4 is the first bad commit commit 5c408fee254633a5be69505bc86c6b034f871ab4 Author: Maciej S. Szmigiero <mail@maciej.szmigiero.name> Date: Mon Jan 18 20:07:44 2016 +0100 ASoC: fsl_ssi: remove explicit register defaults There is no guarantee that on fsl_ssi module load SSI registers will have their power-on-reset values. In fact, if the driver is reloaded the values in registers will be whatever they were set to previously. However, the cache needs to be fully populated at probe time to avoid non-atomic allocations during register access. Special case here is imx21-class SSI, since according to datasheet it don't have SACC{ST,EN,DIS} regs. This fixes hard lockup on fsl_ssi module reload, at least in AC'97 mode. Fixes: 05cf237972fe ("ASoC: fsl_ssi: Add driver suspend and resume to support MEGA Fast") Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name> Tested-by: Fabio Estevam <fabio.estevam@nxp.com> Signed-off-by: Mark Brown <broonie@kernel.org> causes regmap init failure when loading the sgtl5000 codec on imx6q, and leads to no audio. With the mentioned patch reverted sound works ok. --Mika ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [REGRESSION, bisected] 4.5rc4 sound fsl-soc 2016-02-15 11:30 ` Fabio Estevam @ 2016-02-15 15:59 ` Fabio Estevam [not found] ` <56C1CBD3.4000900@nextfour.com> 1 sibling, 0 replies; 5+ messages in thread From: Fabio Estevam @ 2016-02-15 15:59 UTC (permalink / raw) To: broonie@kernel.org; +Cc: Mika Penttilä, LKML, mail@maciej.szmigiero.name On Mon, Feb 15, 2016 at 9:30 AM, Fabio Estevam <fabio.estevam@nxp.com> wrote: > [Sorry for the top post, can't reply properly from this Inbox] > > Could you please try applying this commit from linux-next? > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/base/regmap/regcache.c?id=3245d460a1eb55b5c3ca31dde7b5c5ac71546edf I just confirmed that applying this patch to 4.5-rc4 fixes the fsl ssi regression. Mark, Could you apply https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/base/regmap/regcache.c?id=3245d460a1eb55b5c3ca31dde7b5c5ac71546edf to 4.5-rc? Thanks ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <56C1CBD3.4000900@nextfour.com>]
[parent not found: <AM2PR04MB06909856C3BE6BBBDBC35CD7E3A10@AM2PR04MB0690.eurprd04.prod.outlook.com>]
* Re: [REGRESSION, bisected] 4.5rc4 sound fsl-soc [not found] ` <AM2PR04MB06909856C3BE6BBBDBC35CD7E3A10@AM2PR04MB0690.eurprd04.prod.outlook.com> @ 2016-02-20 20:57 ` Mika Penttilä 2016-02-20 21:21 ` Mark Brown 0 siblings, 1 reply; 5+ messages in thread From: Mika Penttilä @ 2016-02-20 20:57 UTC (permalink / raw) To: Fabio Estevam, linux-kernel, broonie; +Cc: festevam Mark, I can confirm that the patch: https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/base/regmap/regcache.c?id=3245d460a1eb55b5c3ca31dde7b5c5ac71546edf solved the audio codec probing issue for me. Without it there's no sound on imx6 with 4.5-rc4. Please apply. Thanks, Mika On 20.02.2016 22:45, Fabio Estevam wrote: > Hi Mika, > > Did it work for you? > > If so, please ask in the mailing list for Mark Brown to apply that patch. > > Thanks > > ________________________________________ > From: Mika Penttilä <mika.penttila@nextfour.com> > Sent: Monday, February 15, 2016 11:00 AM > To: Fabio Estevam > Subject: Re: [REGRESSION, bisected] 4.5rc4 sound fsl-soc > > On 02/15/2016 01:30 PM, Fabio Estevam wrote: >> [Sorry for the top post, can't reply properly from this Inbox] > Hi, > > will test that tomorrow morning EET. > > > thanks, > Mika > > >> Could you please try applying this commit from linux-next? >> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/base/regmap/regcache.c?id=3245d460a1eb55b5c3ca31dde7b5c5ac71546edf >> >> Thanks, >> >> Fabio Estevam >> >> ________________________________________ >> From: Mika Penttilä <mika.penttila@nextfour.com> >> Sent: Monday, February 15, 2016 9:25 AM >> To: LKML; mail@maciej.szmigiero.name; Fabio Estevam >> Subject: [REGRESSION, bisected] 4.5rc4 sound fsl-soc >> >> Hi, >> >> The following commit : >> >> 5c408fee254633a5be69505bc86c6b034f871ab4 is the first bad commit >> commit 5c408fee254633a5be69505bc86c6b034f871ab4 >> Author: Maciej S. Szmigiero <mail@maciej.szmigiero.name> >> Date: Mon Jan 18 20:07:44 2016 +0100 >> >> ASoC: fsl_ssi: remove explicit register defaults >> >> There is no guarantee that on fsl_ssi module load >> SSI registers will have their power-on-reset values. >> >> In fact, if the driver is reloaded the values in >> registers will be whatever they were set to previously. >> >> However, the cache needs to be fully populated at probe >> time to avoid non-atomic allocations during register >> access. >> >> Special case here is imx21-class SSI, since >> according to datasheet it don't have SACC{ST,EN,DIS} >> regs. >> >> This fixes hard lockup on fsl_ssi module reload, >> at least in AC'97 mode. >> >> Fixes: 05cf237972fe ("ASoC: fsl_ssi: Add driver suspend and resume to support MEGA Fast") >> Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name> >> Tested-by: Fabio Estevam <fabio.estevam@nxp.com> >> Signed-off-by: Mark Brown <broonie@kernel.org> >> >> >> causes regmap init failure when loading the sgtl5000 codec on imx6q, and >> leads to no audio. >> >> With the mentioned patch reverted sound works ok. >> >> --Mika >> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [REGRESSION, bisected] 4.5rc4 sound fsl-soc 2016-02-20 20:57 ` Mika Penttilä @ 2016-02-20 21:21 ` Mark Brown 0 siblings, 0 replies; 5+ messages in thread From: Mark Brown @ 2016-02-20 21:21 UTC (permalink / raw) To: Mika Penttilä; +Cc: Fabio Estevam, linux-kernel, festevam [-- Attachment #1: Type: text/plain, Size: 1414 bytes --] On Sat, Feb 20, 2016 at 10:57:58PM +0200, Mika Penttilä wrote: > Mark, > I can confirm that the patch: > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/base/regmap/regcache.c?id=3245d460a1eb55b5c3ca31dde7b5c5ac71546edf Please don't top post, reply in line with needed context. This allows readers to readily follow the flow of conversation and understand what you are talking about and also helps ensure that everything in the discussion is being addressed. Please also fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to. Please include human readable descriptions of things like commits and issues being discussed in e-mail in your mails, this makes them much easier for humans to read especially when they have no internet access. I do frequently catch up on my mail on flights or while otherwise travelling so this is even more pressing for me than just being about making things a bit easier to read. > solved the audio codec probing issue for me. Without it there's no sound on imx6 with 4.5-rc4. Did this ever work? What is the problem, this is the first message in this thread I have seen (the subject line isn't very intelligable with very long tags that hide most of the actual text, I may well have deleted prior mails)? [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 473 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-02-20 21:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-15 11:25 [REGRESSION, bisected] 4.5rc4 sound fsl-soc Mika Penttilä
2016-02-15 11:30 ` Fabio Estevam
2016-02-15 15:59 ` Fabio Estevam
[not found] ` <56C1CBD3.4000900@nextfour.com>
[not found] ` <AM2PR04MB06909856C3BE6BBBDBC35CD7E3A10@AM2PR04MB0690.eurprd04.prod.outlook.com>
2016-02-20 20:57 ` Mika Penttilä
2016-02-20 21:21 ` Mark Brown
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.