All of lore.kernel.org
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Cc: k.kozlowski.k@gmail.com, devicetree@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Rob Herring <robh+dt@kernel.org>,
	Alessandro Zummo <a.zummo@towertech.it>
Subject: Re: [rtc-linux] [PATCH] rtc: s3c: Document required clocks in the DT binding
Date: Mon, 15 Feb 2016 09:49:34 -0300	[thread overview]
Message-ID: <56C1C95E.7030002@osg.samsung.com> (raw)
In-Reply-To: <56C01FDD.9050204@samsung.com>

Hello Krzysztof,

Thanks a lot for your feedback.

On 02/14/2016 03:34 AM, Krzysztof Kozlowski wrote:
> W dniu 10.02.2016 o 02:23, Javier Martinez Canillas pisze:
>> The S3C Real Time Clock driver requires the clock and source clock to
>> be defined in the device node but that requirement is not documented.
>
> +Cc: Alessandro Zummo
>

I didn't add Alessandro to cc deliberately since Alexandre is the one
maintaining the RTC subsystem lately and before that, the RTC patches
were picked by Andrew Morton since Alessandro didn't even answer the
emails.
  
> No, not entirely. The samsung,s3c6410-rtc needs rtc and rtc_src clocks
> but rest of compatible devices need only rtc clock.
>

Right, sorry for missing that. I noticed that this patch has already
been picked by Rob Herring (I thought it would be picked by Alexandre
though) so I will post a follow up patch explaining that rtc_src is
only for the s3c6410-rtc compatible.

> Best regards,
> Krzysztof
>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
To: Krzysztof Kozlowski
	<k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: k.kozlowski.k-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Alexandre Belloni
	<alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Alessandro Zummo
	<a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org>
Subject: Re: [rtc-linux] [PATCH] rtc: s3c: Document required clocks in the DT binding
Date: Mon, 15 Feb 2016 09:49:34 -0300	[thread overview]
Message-ID: <56C1C95E.7030002@osg.samsung.com> (raw)
In-Reply-To: <56C01FDD.9050204-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

Hello Krzysztof,

Thanks a lot for your feedback.

On 02/14/2016 03:34 AM, Krzysztof Kozlowski wrote:
> W dniu 10.02.2016 o 02:23, Javier Martinez Canillas pisze:
>> The S3C Real Time Clock driver requires the clock and source clock to
>> be defined in the device node but that requirement is not documented.
>
> +Cc: Alessandro Zummo
>

I didn't add Alessandro to cc deliberately since Alexandre is the one
maintaining the RTC subsystem lately and before that, the RTC patches
were picked by Andrew Morton since Alessandro didn't even answer the
emails.
  
> No, not entirely. The samsung,s3c6410-rtc needs rtc and rtc_src clocks
> but rest of compatible devices need only rtc clock.
>

Right, sorry for missing that. I noticed that this patch has already
been picked by Rob Herring (I thought it would be picked by Alexandre
though) so I will post a follow up patch explaining that rtc_src is
only for the s3c6410-rtc compatible.

> Best regards,
> Krzysztof
>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Cc: k.kozlowski.k@gmail.com, devicetree@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Rob Herring <robh+dt@kernel.org>,
	Alessandro Zummo <a.zummo@towertech.it>
Subject: Re: [rtc-linux] [PATCH] rtc: s3c: Document required clocks in the DT binding
Date: Mon, 15 Feb 2016 09:49:34 -0300	[thread overview]
Message-ID: <56C1C95E.7030002@osg.samsung.com> (raw)
In-Reply-To: <56C01FDD.9050204@samsung.com>

Hello Krzysztof,

Thanks a lot for your feedback.

On 02/14/2016 03:34 AM, Krzysztof Kozlowski wrote:
> W dniu 10.02.2016 o 02:23, Javier Martinez Canillas pisze:
>> The S3C Real Time Clock driver requires the clock and source clock to
>> be defined in the device node but that requirement is not documented.
>
> +Cc: Alessandro Zummo
>

I didn't add Alessandro to cc deliberately since Alexandre is the one
maintaining the RTC subsystem lately and before that, the RTC patches
were picked by Andrew Morton since Alessandro didn't even answer the
emails.
  
> No, not entirely. The samsung,s3c6410-rtc needs rtc and rtc_src clocks
> but rest of compatible devices need only rtc clock.
>

Right, sorry for missing that. I noticed that this patch has already
been picked by Rob Herring (I thought it would be picked by Alexandre
though) so I will post a follow up patch explaining that rtc_src is
only for the s3c6410-rtc compatible.

> Best regards,
> Krzysztof
>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

  reply	other threads:[~2016-02-15 12:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-09 17:23 [rtc-linux] [PATCH] rtc: s3c: Document required clocks in the DT binding Javier Martinez Canillas
2016-02-09 17:23 ` Javier Martinez Canillas
2016-02-14  6:34 ` [rtc-linux] " Krzysztof Kozlowski
2016-02-14  6:34   ` Krzysztof Kozlowski
2016-02-14  6:34   ` Krzysztof Kozlowski
2016-02-15 12:49   ` Javier Martinez Canillas [this message]
2016-02-15 12:49     ` Javier Martinez Canillas
2016-02-15 12:49     ` Javier Martinez Canillas
2016-02-15 13:41     ` Alexandre Belloni
2016-02-15 13:41       ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56C1C95E.7030002@osg.samsung.com \
    --to=javier@osg.samsung.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=devicetree@vger.kernel.org \
    --cc=k.kozlowski.k@gmail.com \
    --cc=k.kozlowski@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.