From: Thomas Huth <thuth@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
Pierre Morel <pmorel@linux.vnet.ibm.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-trivial] [PATCH] s390: remove misleading comment
Date: Tue, 16 Feb 2016 09:52:47 +0100 [thread overview]
Message-ID: <56C2E35F.1030103@redhat.com> (raw)
In-Reply-To: <1455604235-3313-1-git-send-email-mjt@msgid.tls.msk.ru>
On 16.02.2016 07:30, Michael Tokarev wrote:
> The comment talks about a non-ELF object while the
> example gives ELF object.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> hw/s390x/ipl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
> index c9cf7cc..2213405 100644
> --- a/hw/s390x/ipl.c
> +++ b/hw/s390x/ipl.c
> @@ -106,7 +106,7 @@ static void s390_ipl_realize(DeviceState *dev, Error **errp)
> /* Adjust ELF start address to final location */
> ipl->bios_start_addr += fwbase;
> } else {
> - /* Try to load non-ELF file (e.g. s390-ccw.img) */
> + /* Try to load non-ELF file */
> bios_size = load_image_targphys(bios_filename, ZIPL_IMAGE_START,
> 4096);
> ipl->bios_start_addr = ZIPL_IMAGE_START;
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Huth <thuth@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
Pierre Morel <pmorel@linux.vnet.ibm.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] s390: remove misleading comment
Date: Tue, 16 Feb 2016 09:52:47 +0100 [thread overview]
Message-ID: <56C2E35F.1030103@redhat.com> (raw)
In-Reply-To: <1455604235-3313-1-git-send-email-mjt@msgid.tls.msk.ru>
On 16.02.2016 07:30, Michael Tokarev wrote:
> The comment talks about a non-ELF object while the
> example gives ELF object.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> hw/s390x/ipl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
> index c9cf7cc..2213405 100644
> --- a/hw/s390x/ipl.c
> +++ b/hw/s390x/ipl.c
> @@ -106,7 +106,7 @@ static void s390_ipl_realize(DeviceState *dev, Error **errp)
> /* Adjust ELF start address to final location */
> ipl->bios_start_addr += fwbase;
> } else {
> - /* Try to load non-ELF file (e.g. s390-ccw.img) */
> + /* Try to load non-ELF file */
> bios_size = load_image_targphys(bios_filename, ZIPL_IMAGE_START,
> 4096);
> ipl->bios_start_addr = ZIPL_IMAGE_START;
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2016-02-16 8:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 6:30 [Qemu-trivial] [PATCH] s390: remove misleading comment Michael Tokarev
2016-02-16 6:30 ` [Qemu-devel] " Michael Tokarev
2016-02-16 8:52 ` Thomas Huth [this message]
2016-02-16 8:52 ` Thomas Huth
2016-02-16 9:47 ` [Qemu-trivial] " Cornelia Huck
2016-02-16 9:47 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C2E35F.1030103@redhat.com \
--to=thuth@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=mjt@tls.msk.ru \
--cc=pmorel@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.