From: John Snow <jsnow@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, jcody@redhat.com, stefanha@redhat.com,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] block/backup: make backup cluster size configurable
Date: Tue, 16 Feb 2016 08:38:40 -0500 [thread overview]
Message-ID: <56C32660.6080703@redhat.com> (raw)
In-Reply-To: <20160214064613.GA31933@ad.usersys.redhat.com>
On 02/14/2016 01:46 AM, Fam Zheng wrote:
> On Fri, 02/12 18:06, John Snow wrote:
>> typedef struct CowRequest {
>> @@ -46,6 +43,8 @@ typedef struct BackupBlockJob {
>> CoRwlock flush_rwlock;
>> uint64_t sectors_read;
>> HBitmap *bitmap;
>> + int64_t cluster_size;
>> + int64_t sectors_per_cluster;
>
> I don't think it makes sense to duplicate one value in two units.
>
> Fam
>
Eh, fair.
I just didn't want to duplicate the math everywhere. I can add a little
macro or an inline function instead.
--js
next prev parent reply other threads:[~2016-02-16 13:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 23:06 [Qemu-devel] [PATCH 0/3] blockjob: correct backup cluster size for incremental backups John Snow
2016-02-12 23:06 ` [Qemu-devel] [PATCH 1/3] block/backup: make backup cluster size configurable John Snow
2016-02-14 6:46 ` Fam Zheng
2016-02-16 13:38 ` John Snow [this message]
2016-02-12 23:06 ` [Qemu-devel] [PATCH 2/3] block/backup: avoid copying less than full target clusters John Snow
2016-02-14 6:49 ` Fam Zheng
2016-02-16 15:43 ` John Snow
2016-02-12 23:06 ` [Qemu-devel] [PATCH 3/3] iotests/124: Add cluster_size mismatch test John Snow
2016-02-14 7:08 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C32660.6080703@redhat.com \
--to=jsnow@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.