From: Paolo Bonzini <pbonzini@redhat.com>
To: Andrew Jones <drjones@redhat.com>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org
Cc: thuth@redhat.com, dgibson@redhat.com,
david@gibson.dropbear.id.au, agraf@suse.de, lvivier@redhat.com
Subject: Re: [kvm-unit-tests PATCH v4 00/17] ppc64: initial drop
Date: Tue, 16 Feb 2016 17:32:07 +0000 [thread overview]
Message-ID: <56C35D17.5050700@redhat.com> (raw)
In-Reply-To: <1455544166-19766-1-git-send-email-drjones@redhat.com>
On 15/02/2016 14:49, Andrew Jones wrote:
> This series brings basic setup; starts a test's C entry point, main(),
> and printf, exit, and malloc work. Three more series should follow this
> one which must bring; vector support, mmu support, and smp support, at
> which point I believe the framework could just evolve with the creation
> of unit tests.
>
> Tested on TCG and a P8 kvm_pr machine, and Laurent has tested it on
> both a PowerMac G5 (kvm_pr) and a kvm_hv machine. I'm looking forward
> to hearing more testing feedback from others though.
In case everything's fine, do you have a branch that I can pull from?
Paolo
> v4:
> - check for H_PRIVILEGE in broken sc1 probe [David]
> - rename rtas' lock from lock to rtas_lock [Thomas]
> - rtas: should only iterate to size/4 [drew]
> - add powerpc/.gitignore (ignore boot_rom.bin) [drew]
>
> v3:
> Paolo's comments:
> - got rid of zero-sized files
>
> Thomas' review comments:
> - remove useless casts in needed cast adding patch
> - got rid of build_romfs building (and committing a binary), just
> offset the rom binary by 256 bytes now
> - added a better error message for a -smp N, N > NR_CPUS user error
> - got rid of infinite loop with broken rtas-poweroff
> - one r-b (wasn't sure the "looks good"'s counted, so didn't add more)
>
> Laurent's testing led me to
> - fix a problem on kvm_pr with broken sc1
> - fix handling of memory regions, expect more than one
> - and a fix to DT code so that works
>
> Additionally:
> - new patches
> - cscope: ppc64 needs to look in lib/powerpc/asm too,
> and arm64 in lib/arm/asm
> - handle memory regions better also for arm
> - a misc trivial fix for arm...
> - align toc to 256 bytes for later gcc
>
> v2:
> Besides rebasing on latest master, v2 addresses all of David's comments
> - assembler cleanup
> - jump into the RTAS blob we get from DT, instead of reproducing it
> - don't store the RTAS root node, always hunt it down
>
> We still haven't addressed debug-exit. Plugging chr-testdev into an spapr
> vty is probably what we should investigate first (as was suggested by Alex
> Graf under the v1 review). For now we keep the hack from v1, but simplified.
>
> Patches also available here
> https://github.com/rhdrjones/kvm-unit-tests/commits/ppc64/initial-drop-v4
>
>
> Andrew Jones (17):
> arm/arm64: trivial: another assert fix
> Makefile: cscope: also look in arch shared asm
> lib: asm-generic: add missing casts
> devicetree: fix dt_get_memory_params
> arm/arm64: setup improvements
> lib: share arm-selftest utility functions
> config: no need to mix arch makefiles
> powerpc/ppc64: start skeleton framework
> powerpc/ppc64: ppc-ify makefiles and linker script
> powerpc/ppc64: add a boot rom
> powerpc/ppc64: add hcall support and putchar
> powerpc/ppc64: adapt arm's setup
> powerpc/ppc64: relocate linker VMAs
> powerpc/ppc64: add run script and unittests.cfg
> mkstandalone: add support for powerpc
> powerpc/ppc64: add RTAS support
> powerpc/ppc64: make a fake debug-exit
>
> Makefile | 8 +-
> README | 3 +-
> arm/Makefile | 1 +
> config/config-arm.mak => arm/Makefile.arm | 2 +-
> config/config-arm64.mak => arm/Makefile.arm64 | 2 +-
> .../config-arm-common.mak => arm/Makefile.common | 3 +-
> arm/selftest.c | 45 +++----
> configure | 6 +
> lib/arm/asm/setup.h | 9 ++
> lib/arm/io.c | 3 +-
> lib/arm/setup.c | 66 +++++++---
> lib/asm-generic/io.h | 12 +-
> lib/devicetree.c | 8 +-
> lib/libcflat.h | 11 +-
> lib/powerpc/.gitignore | 1 +
> lib/powerpc/asm/hcall.h | 46 +++++++
> lib/powerpc/asm/rtas.h | 26 ++++
> lib/powerpc/asm/setup.h | 36 ++++++
> lib/powerpc/hcall.c | 79 ++++++++++++
> lib/powerpc/io.c | 37 ++++++
> lib/powerpc/rtas.c | 139 +++++++++++++++++++++
> lib/powerpc/setup.c | 119 ++++++++++++++++++
> lib/ppc64/.gitignore | 1 +
> lib/ppc64/asm-offsets.c | 12 ++
> lib/ppc64/asm/asm-offsets.h | 1 +
> lib/ppc64/asm/hcall.h | 1 +
> lib/ppc64/asm/io.h | 5 +
> lib/ppc64/asm/page.h | 1 +
> lib/ppc64/asm/rtas.h | 1 +
> lib/ppc64/asm/setup.h | 1 +
> lib/ppc64/asm/spinlock.h | 11 ++
> lib/ppc64/spinlock.c | 11 ++
> lib/report.c | 16 +++
> lib/util.c | 18 +++
> lib/util.h | 23 ++++
> powerpc/.gitignore | 1 +
> powerpc/Makefile | 1 +
> powerpc/Makefile.common | 71 +++++++++++
> powerpc/Makefile.ppc64 | 20 +++
> powerpc/boot_rom.S | 5 +
> powerpc/cstart64.S | 83 ++++++++++++
> powerpc/flat.lds | 44 +++++++
> powerpc/reloc64.c | 55 ++++++++
> powerpc/run | 55 ++++++++
> powerpc/selftest.c | 64 ++++++++++
> powerpc/unittests.cfg | 30 +++++
> {config => scripts}/asm-offsets.mak | 0
> scripts/mkstandalone.sh | 5 +
> x86/Makefile | 1 +
> .../config-x86-common.mak => x86/Makefile.common | 0
> config/config-i386.mak => x86/Makefile.i386 | 2 +-
> config/config-x86_64.mak => x86/Makefile.x86_64 | 2 +-
> 52 files changed, 1128 insertions(+), 75 deletions(-)
> create mode 100644 arm/Makefile
> rename config/config-arm.mak => arm/Makefile.arm (90%)
> rename config/config-arm64.mak => arm/Makefile.arm64 (89%)
> rename config/config-arm-common.mak => arm/Makefile.common (96%)
> create mode 100644 lib/powerpc/.gitignore
> create mode 100644 lib/powerpc/asm/hcall.h
> create mode 100644 lib/powerpc/asm/rtas.h
> create mode 100644 lib/powerpc/asm/setup.h
> create mode 100644 lib/powerpc/hcall.c
> create mode 100644 lib/powerpc/io.c
> create mode 100644 lib/powerpc/rtas.c
> create mode 100644 lib/powerpc/setup.c
> create mode 100644 lib/ppc64/.gitignore
> create mode 100644 lib/ppc64/asm-offsets.c
> create mode 100644 lib/ppc64/asm/asm-offsets.h
> create mode 100644 lib/ppc64/asm/hcall.h
> create mode 100644 lib/ppc64/asm/io.h
> create mode 100644 lib/ppc64/asm/page.h
> create mode 100644 lib/ppc64/asm/rtas.h
> create mode 100644 lib/ppc64/asm/setup.h
> create mode 100644 lib/ppc64/asm/spinlock.h
> create mode 100644 lib/ppc64/spinlock.c
> create mode 100644 lib/util.c
> create mode 100644 lib/util.h
> create mode 100644 powerpc/.gitignore
> create mode 100644 powerpc/Makefile
> create mode 100644 powerpc/Makefile.common
> create mode 100644 powerpc/Makefile.ppc64
> create mode 100644 powerpc/boot_rom.S
> create mode 100644 powerpc/cstart64.S
> create mode 100644 powerpc/flat.lds
> create mode 100644 powerpc/reloc64.c
> create mode 100755 powerpc/run
> create mode 100644 powerpc/selftest.c
> create mode 100644 powerpc/unittests.cfg
> rename {config => scripts}/asm-offsets.mak (100%)
> create mode 100644 x86/Makefile
> rename config/config-x86-common.mak => x86/Makefile.common (100%)
> rename config/config-i386.mak => x86/Makefile.i386 (91%)
> rename config/config-x86_64.mak => x86/Makefile.x86_64 (93%)
>
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Andrew Jones <drjones@redhat.com>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org
Cc: thuth@redhat.com, dgibson@redhat.com,
david@gibson.dropbear.id.au, agraf@suse.de, lvivier@redhat.com
Subject: Re: [kvm-unit-tests PATCH v4 00/17] ppc64: initial drop
Date: Tue, 16 Feb 2016 18:32:07 +0100 [thread overview]
Message-ID: <56C35D17.5050700@redhat.com> (raw)
In-Reply-To: <1455544166-19766-1-git-send-email-drjones@redhat.com>
On 15/02/2016 14:49, Andrew Jones wrote:
> This series brings basic setup; starts a test's C entry point, main(),
> and printf, exit, and malloc work. Three more series should follow this
> one which must bring; vector support, mmu support, and smp support, at
> which point I believe the framework could just evolve with the creation
> of unit tests.
>
> Tested on TCG and a P8 kvm_pr machine, and Laurent has tested it on
> both a PowerMac G5 (kvm_pr) and a kvm_hv machine. I'm looking forward
> to hearing more testing feedback from others though.
In case everything's fine, do you have a branch that I can pull from?
Paolo
> v4:
> - check for H_PRIVILEGE in broken sc1 probe [David]
> - rename rtas' lock from lock to rtas_lock [Thomas]
> - rtas: should only iterate to size/4 [drew]
> - add powerpc/.gitignore (ignore boot_rom.bin) [drew]
>
> v3:
> Paolo's comments:
> - got rid of zero-sized files
>
> Thomas' review comments:
> - remove useless casts in needed cast adding patch
> - got rid of build_romfs building (and committing a binary), just
> offset the rom binary by 256 bytes now
> - added a better error message for a -smp N, N > NR_CPUS user error
> - got rid of infinite loop with broken rtas-poweroff
> - one r-b (wasn't sure the "looks good"'s counted, so didn't add more)
>
> Laurent's testing led me to
> - fix a problem on kvm_pr with broken sc1
> - fix handling of memory regions, expect more than one
> - and a fix to DT code so that works
>
> Additionally:
> - new patches
> - cscope: ppc64 needs to look in lib/powerpc/asm too,
> and arm64 in lib/arm/asm
> - handle memory regions better also for arm
> - a misc trivial fix for arm...
> - align toc to 256 bytes for later gcc
>
> v2:
> Besides rebasing on latest master, v2 addresses all of David's comments
> - assembler cleanup
> - jump into the RTAS blob we get from DT, instead of reproducing it
> - don't store the RTAS root node, always hunt it down
>
> We still haven't addressed debug-exit. Plugging chr-testdev into an spapr
> vty is probably what we should investigate first (as was suggested by Alex
> Graf under the v1 review). For now we keep the hack from v1, but simplified.
>
> Patches also available here
> https://github.com/rhdrjones/kvm-unit-tests/commits/ppc64/initial-drop-v4
>
>
> Andrew Jones (17):
> arm/arm64: trivial: another assert fix
> Makefile: cscope: also look in arch shared asm
> lib: asm-generic: add missing casts
> devicetree: fix dt_get_memory_params
> arm/arm64: setup improvements
> lib: share arm-selftest utility functions
> config: no need to mix arch makefiles
> powerpc/ppc64: start skeleton framework
> powerpc/ppc64: ppc-ify makefiles and linker script
> powerpc/ppc64: add a boot rom
> powerpc/ppc64: add hcall support and putchar
> powerpc/ppc64: adapt arm's setup
> powerpc/ppc64: relocate linker VMAs
> powerpc/ppc64: add run script and unittests.cfg
> mkstandalone: add support for powerpc
> powerpc/ppc64: add RTAS support
> powerpc/ppc64: make a fake debug-exit
>
> Makefile | 8 +-
> README | 3 +-
> arm/Makefile | 1 +
> config/config-arm.mak => arm/Makefile.arm | 2 +-
> config/config-arm64.mak => arm/Makefile.arm64 | 2 +-
> .../config-arm-common.mak => arm/Makefile.common | 3 +-
> arm/selftest.c | 45 +++----
> configure | 6 +
> lib/arm/asm/setup.h | 9 ++
> lib/arm/io.c | 3 +-
> lib/arm/setup.c | 66 +++++++---
> lib/asm-generic/io.h | 12 +-
> lib/devicetree.c | 8 +-
> lib/libcflat.h | 11 +-
> lib/powerpc/.gitignore | 1 +
> lib/powerpc/asm/hcall.h | 46 +++++++
> lib/powerpc/asm/rtas.h | 26 ++++
> lib/powerpc/asm/setup.h | 36 ++++++
> lib/powerpc/hcall.c | 79 ++++++++++++
> lib/powerpc/io.c | 37 ++++++
> lib/powerpc/rtas.c | 139 +++++++++++++++++++++
> lib/powerpc/setup.c | 119 ++++++++++++++++++
> lib/ppc64/.gitignore | 1 +
> lib/ppc64/asm-offsets.c | 12 ++
> lib/ppc64/asm/asm-offsets.h | 1 +
> lib/ppc64/asm/hcall.h | 1 +
> lib/ppc64/asm/io.h | 5 +
> lib/ppc64/asm/page.h | 1 +
> lib/ppc64/asm/rtas.h | 1 +
> lib/ppc64/asm/setup.h | 1 +
> lib/ppc64/asm/spinlock.h | 11 ++
> lib/ppc64/spinlock.c | 11 ++
> lib/report.c | 16 +++
> lib/util.c | 18 +++
> lib/util.h | 23 ++++
> powerpc/.gitignore | 1 +
> powerpc/Makefile | 1 +
> powerpc/Makefile.common | 71 +++++++++++
> powerpc/Makefile.ppc64 | 20 +++
> powerpc/boot_rom.S | 5 +
> powerpc/cstart64.S | 83 ++++++++++++
> powerpc/flat.lds | 44 +++++++
> powerpc/reloc64.c | 55 ++++++++
> powerpc/run | 55 ++++++++
> powerpc/selftest.c | 64 ++++++++++
> powerpc/unittests.cfg | 30 +++++
> {config => scripts}/asm-offsets.mak | 0
> scripts/mkstandalone.sh | 5 +
> x86/Makefile | 1 +
> .../config-x86-common.mak => x86/Makefile.common | 0
> config/config-i386.mak => x86/Makefile.i386 | 2 +-
> config/config-x86_64.mak => x86/Makefile.x86_64 | 2 +-
> 52 files changed, 1128 insertions(+), 75 deletions(-)
> create mode 100644 arm/Makefile
> rename config/config-arm.mak => arm/Makefile.arm (90%)
> rename config/config-arm64.mak => arm/Makefile.arm64 (89%)
> rename config/config-arm-common.mak => arm/Makefile.common (96%)
> create mode 100644 lib/powerpc/.gitignore
> create mode 100644 lib/powerpc/asm/hcall.h
> create mode 100644 lib/powerpc/asm/rtas.h
> create mode 100644 lib/powerpc/asm/setup.h
> create mode 100644 lib/powerpc/hcall.c
> create mode 100644 lib/powerpc/io.c
> create mode 100644 lib/powerpc/rtas.c
> create mode 100644 lib/powerpc/setup.c
> create mode 100644 lib/ppc64/.gitignore
> create mode 100644 lib/ppc64/asm-offsets.c
> create mode 100644 lib/ppc64/asm/asm-offsets.h
> create mode 100644 lib/ppc64/asm/hcall.h
> create mode 100644 lib/ppc64/asm/io.h
> create mode 100644 lib/ppc64/asm/page.h
> create mode 100644 lib/ppc64/asm/rtas.h
> create mode 100644 lib/ppc64/asm/setup.h
> create mode 100644 lib/ppc64/asm/spinlock.h
> create mode 100644 lib/ppc64/spinlock.c
> create mode 100644 lib/util.c
> create mode 100644 lib/util.h
> create mode 100644 powerpc/.gitignore
> create mode 100644 powerpc/Makefile
> create mode 100644 powerpc/Makefile.common
> create mode 100644 powerpc/Makefile.ppc64
> create mode 100644 powerpc/boot_rom.S
> create mode 100644 powerpc/cstart64.S
> create mode 100644 powerpc/flat.lds
> create mode 100644 powerpc/reloc64.c
> create mode 100755 powerpc/run
> create mode 100644 powerpc/selftest.c
> create mode 100644 powerpc/unittests.cfg
> rename {config => scripts}/asm-offsets.mak (100%)
> create mode 100644 x86/Makefile
> rename config/config-x86-common.mak => x86/Makefile.common (100%)
> rename config/config-i386.mak => x86/Makefile.i386 (91%)
> rename config/config-x86_64.mak => x86/Makefile.x86_64 (93%)
>
next prev parent reply other threads:[~2016-02-16 17:32 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 13:49 [kvm-unit-tests PATCH v4 00/17] ppc64: initial drop Andrew Jones
2016-02-15 13:49 ` Andrew Jones
2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 01/17] arm/arm64: trivial: another assert fix Andrew Jones
2016-02-15 13:49 ` Andrew Jones
2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 02/17] Makefile: cscope: also look in arch shared asm Andrew Jones
2016-02-15 13:49 ` Andrew Jones
2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 03/17] lib: asm-generic: add missing casts Andrew Jones
2016-02-15 13:49 ` Andrew Jones
2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 04/17] devicetree: fix dt_get_memory_params Andrew Jones
2016-02-15 13:49 ` Andrew Jones
2016-02-16 6:11 ` David Gibson
2016-02-16 6:11 ` David Gibson
2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 05/17] arm/arm64: setup improvements Andrew Jones
2016-02-15 13:49 ` Andrew Jones
2016-02-16 6:15 ` David Gibson
2016-02-16 6:15 ` David Gibson
2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 06/17] lib: share arm-selftest utility functions Andrew Jones
2016-02-15 13:49 ` Andrew Jones
2016-02-17 0:14 ` David Gibson
2016-02-17 0:14 ` David Gibson
2016-02-17 12:17 ` Andrew Jones
2016-02-17 12:17 ` Andrew Jones
2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 07/17] config: no need to mix arch makefiles Andrew Jones
2016-02-15 13:49 ` Andrew Jones
2016-02-17 1:18 ` David Gibson
2016-02-17 1:18 ` David Gibson
2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 08/17] powerpc/ppc64: start skeleton framework Andrew Jones
2016-02-15 13:49 ` Andrew Jones
2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 09/17] powerpc/ppc64: ppc-ify makefiles and linker script Andrew Jones
2016-02-15 13:49 ` Andrew Jones
2016-02-17 1:45 ` David Gibson
2016-02-17 1:45 ` David Gibson
2016-02-17 12:21 ` Andrew Jones
2016-02-17 12:21 ` Andrew Jones
2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 10/17] powerpc/ppc64: add a boot rom Andrew Jones
2016-02-15 13:49 ` Andrew Jones
2016-02-17 1:50 ` David Gibson
2016-02-17 1:50 ` David Gibson
2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 11/17] powerpc/ppc64: add hcall support and putchar Andrew Jones
2016-02-15 13:49 ` Andrew Jones
2016-02-17 2:04 ` David Gibson
2016-02-17 2:04 ` David Gibson
2016-02-17 12:34 ` Andrew Jones
2016-02-17 12:34 ` Andrew Jones
2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 12/17] powerpc/ppc64: adapt arm's setup Andrew Jones
2016-02-15 13:49 ` Andrew Jones
2016-02-17 2:11 ` David Gibson
2016-02-17 2:11 ` David Gibson
2016-02-17 12:45 ` Andrew Jones
2016-02-17 12:45 ` Andrew Jones
2016-02-17 17:34 ` Andrew Jones
2016-02-17 17:34 ` Andrew Jones
2016-02-18 0:05 ` David Gibson
2016-02-18 0:05 ` David Gibson
2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 13/17] powerpc/ppc64: relocate linker VMAs Andrew Jones
2016-02-15 13:49 ` Andrew Jones
2016-02-17 2:14 ` David Gibson
2016-02-17 2:14 ` David Gibson
2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 14/17] powerpc/ppc64: add run script and unittests.cfg Andrew Jones
2016-02-15 13:49 ` Andrew Jones
2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 15/17] mkstandalone: add support for powerpc Andrew Jones
2016-02-15 13:49 ` Andrew Jones
2016-02-17 12:51 ` Andrew Jones
2016-02-17 12:51 ` Andrew Jones
2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 16/17] powerpc/ppc64: add RTAS support Andrew Jones
2016-02-15 13:49 ` Andrew Jones
2016-02-15 13:49 ` [kvm-unit-tests PATCH v4 17/17] powerpc/ppc64: make a fake debug-exit Andrew Jones
2016-02-15 13:49 ` Andrew Jones
2016-02-16 17:32 ` Paolo Bonzini [this message]
2016-02-16 17:32 ` [kvm-unit-tests PATCH v4 00/17] ppc64: initial drop Paolo Bonzini
2016-02-16 17:44 ` Andrew Jones
2016-02-16 17:44 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C35D17.5050700@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=david@gibson.dropbear.id.au \
--cc=dgibson@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.