From: elfring@users.sourceforge.net (SF Markus Elfring)
To: cocci@systeme.lip6.fr
Subject: [Cocci] coccinelle: also catch kzfree() issues
Date: Tue, 16 Feb 2016 21:02:17 +0100 [thread overview]
Message-ID: <56C38049.7090205@users.sourceforge.net> (raw)
In-Reply-To: <alpine.DEB.2.10.1602161815190.2685@hadrien>
>> @free@
>> +identifier kfree =~ "kz?free";
>
> Thanks for the suggestions. However, the regular expression is not such a
> good idea.
How much is such a SmPL constraint still usable then?
> Coccinelle doesn't make any optimizations based on regulat expressions.
Where can your software optimise the source code search?
> It would be better to put a disjunction with kfree and kzfree explicitly,
> as in the other cases.
What are the circumstances for corresponding benefits?
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Yann Droneaud <ydroneaud@opteya.com>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
Michal Marek <mmarek@suse.com>, Tejun Heo <tj@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: coccinelle: also catch kzfree() issues
Date: Tue, 16 Feb 2016 21:02:17 +0100 [thread overview]
Message-ID: <56C38049.7090205@users.sourceforge.net> (raw)
In-Reply-To: <alpine.DEB.2.10.1602161815190.2685@hadrien>
>> @free@
>> +identifier kfree =~ "kz?free";
>
> Thanks for the suggestions. However, the regular expression is not such a
> good idea.
How much is such a SmPL constraint still usable then?
> Coccinelle doesn't make any optimizations based on regulat expressions.
Where can your software optimise the source code search?
> It would be better to put a disjunction with kfree and kzfree explicitly,
> as in the other cases.
What are the circumstances for corresponding benefits?
Regards,
Markus
next prev parent reply other threads:[~2016-02-16 20:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 17:01 [Cocci] [PATCH 0/3] coccinelle: catchup on memory allocation functions Yann Droneaud
2016-02-16 17:01 ` Yann Droneaud
2016-02-16 17:06 ` [Cocci] [PATCH 1/3] coccinelle: also catch kzfree() issues Yann Droneaud
2016-02-16 17:06 ` Yann Droneaud
2016-02-16 17:16 ` [Cocci] " Julia Lawall
2016-02-16 17:16 ` Julia Lawall
2016-02-16 20:02 ` SF Markus Elfring [this message]
2016-02-16 20:02 ` SF Markus Elfring
2016-02-16 20:17 ` [Cocci] " Julia Lawall
2016-02-16 20:17 ` Julia Lawall
2016-02-16 20:22 ` [Cocci] " SF Markus Elfring
2016-02-16 20:22 ` SF Markus Elfring
2016-02-22 14:09 ` [Cocci] [PATCHv1 1/3] " Yann Droneaud
2016-02-22 14:09 ` Yann Droneaud
2016-02-22 14:20 ` [Cocci] " Julia Lawall
2016-02-22 14:20 ` Julia Lawall
2016-02-22 15:24 ` [Cocci] " Yann Droneaud
2016-02-22 15:24 ` Yann Droneaud
2016-02-16 17:06 ` [Cocci] [PATCH 2/3] coccinelle: recognize more devm_* memory allocation functions Yann Droneaud
2016-02-16 17:06 ` Yann Droneaud
2016-02-16 17:18 ` [Cocci] " Julia Lawall
2016-02-16 17:18 ` Julia Lawall
2016-02-16 17:06 ` [Cocci] [PATCH 3/3] coccinelle: catch krealloc() on devm_*() allocated memory Yann Droneaud
2016-02-16 17:06 ` Yann Droneaud
2016-02-16 17:19 ` [Cocci] " Julia Lawall
2016-02-16 17:19 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C38049.7090205@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.