Re: [PATCH] qat pmd:Fixing build issue on 32-bit systems

[John Griffin <john.griffin@intel.com>]

Hi Pablo,
Sure - will resubmit a v2 with those modifications.

Thanks,
John.

On 16/02/16 15:52, De Lara Guarch, Pablo wrote:
> Hi John,
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of John Griffin
>> Sent: Tuesday, February 16, 2016 9:45 AM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH] qat pmd:Fixing build issue on 32-bit systems
>>
>> Fixing build issue on 32-bit systems.
>> Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices")
>>
>> Signed-off-by: John Griffin <john.griffin@intel.com>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
> Could you include the error that you are fixing on this patch?
>
> For example:
>
> drivers/crypto/qat/qat_crypto.c:345:13:
> error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
>
> Also, as a general rule, patch titles start with lowercase and do not include the name "issue" if we use "fix".
> e.g. (qat: fix build on 32-bit systems).
>
> Apart from this, patch looks OK to me, so you can leave the acknowledgment in the v2.
>
> Thanks!
> Pablo
>