From: Vladimir Murzin <vladimir.murzin@arm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
linux@arm.linux.org.uk, pawel.moll@arm.com,
ijc+devicetree@hellion.org.uk, gregkh@linuxfoundation.org,
daniel.lezcano@linaro.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, andy.shevchenko@gmail.com,
galak@codeaurora.org, linux-serial@vger.kernel.org,
u.kleine-koenig@pengutronix.de, tglx@linutronix.de,
linux-api@vger.kernel.org, jslaby@suse.cz,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 09/10] ARM: dts: introduce MPS2 AN385/AN386
Date: Wed, 17 Feb 2016 16:48:44 +0000 [thread overview]
Message-ID: <56C4A46C.50506@arm.com> (raw)
In-Reply-To: <56C349E6.2000002@arm.com>
On 16/02/16 16:10, Vladimir Murzin wrote:
> On 16/02/16 11:01, Arnd Bergmann wrote:
>> On Tuesday 16 February 2016 10:08:14 Vladimir Murzin wrote:
>>> +
>>> + ethernet@40200000 {
>>> + compatible = "smsc,lan9220", "smsc,lan9115";
>>> + reg = <0x40200000 0x10000>;
>>> + interrupts = <13>;
>>> + interrupt-parent = <&nvic>;
>>> + smsc,irq-active-high;
>>> + };
>>> +};
>>> +
>>>
>>
>> This node seems slightly misplaced. Is there some external bus interface
>> that this is connected to? The address suggests that it should be somewhere
>> below the /soc node, and you probably want to list the external bus
>> interface with a "ranges" property that identifies the addresses visibile
>> there, and put the external chip under there.
>>
>
> I might messed it up since the MAC/PHY connects to the same 16-bit
> interface as the 16MB PSRAM external memory and both connected via AHB.
>
> Not sure how it should be expressed, so some help form DT camp would be
> appreciated.
Arnd,
Does following fixup address your point on where/how ethernet node
should be placed?
diff --git a/arch/arm/boot/dts/mps2-an385.dts b/arch/arm/boot/dts/an385.dts
index 976f86d..50c8d24 100644
--- a/arch/arm/boot/dts/mps2-an385.dts
+++ b/arch/arm/boot/dts/mps2-an385.dts
@@ -63,14 +63,10 @@
device_type = "memory";
reg = <0x21000000 0x1000000>;
};
+};
- ethernet@40200000 {
- compatible = "smsc,lan9220", "smsc,lan9115";
- reg = <0x40200000 0x10000>;
- interrupts = <13>;
- interrupt-parent = <&nvic>;
- smsc,irq-active-high;
- };
+&mb {
+ ranges = <0 0x40200000 0x10000>;
};
&uart0 {
diff --git a/arch/arm/boot/dts/mps2.dtsi b/arch/arm/boot/dts/mps2.dtsi
index 5d2c539..1673472 100644
--- a/arch/arm/boot/dts/mps2.dtsi
+++ b/arch/arm/boot/dts/mps2.dtsi
@@ -223,5 +223,21 @@
default-state = "off";
};
};
+
+ };
+
+ mb: smb {
+ compatible = "simple-bus";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ ethernet@0 {
+ compatible = "smsc,lan9220", "smsc,lan9115";
+ reg = <0x0 0x10000>;
+ interrupts = <13>;
+ interrupt-parent = <&nvic>;
+ smsc,irq-active-high;
+ };
};
};
Cheers
Vladimir
>
> Cheers
> Vladimir
>
>> Arnd
>>
>>
>>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: vladimir.murzin@arm.com (Vladimir Murzin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 09/10] ARM: dts: introduce MPS2 AN385/AN386
Date: Wed, 17 Feb 2016 16:48:44 +0000 [thread overview]
Message-ID: <56C4A46C.50506@arm.com> (raw)
In-Reply-To: <56C349E6.2000002@arm.com>
On 16/02/16 16:10, Vladimir Murzin wrote:
> On 16/02/16 11:01, Arnd Bergmann wrote:
>> On Tuesday 16 February 2016 10:08:14 Vladimir Murzin wrote:
>>> +
>>> + ethernet at 40200000 {
>>> + compatible = "smsc,lan9220", "smsc,lan9115";
>>> + reg = <0x40200000 0x10000>;
>>> + interrupts = <13>;
>>> + interrupt-parent = <&nvic>;
>>> + smsc,irq-active-high;
>>> + };
>>> +};
>>> +
>>>
>>
>> This node seems slightly misplaced. Is there some external bus interface
>> that this is connected to? The address suggests that it should be somewhere
>> below the /soc node, and you probably want to list the external bus
>> interface with a "ranges" property that identifies the addresses visibile
>> there, and put the external chip under there.
>>
>
> I might messed it up since the MAC/PHY connects to the same 16-bit
> interface as the 16MB PSRAM external memory and both connected via AHB.
>
> Not sure how it should be expressed, so some help form DT camp would be
> appreciated.
Arnd,
Does following fixup address your point on where/how ethernet node
should be placed?
diff --git a/arch/arm/boot/dts/mps2-an385.dts b/arch/arm/boot/dts/an385.dts
index 976f86d..50c8d24 100644
--- a/arch/arm/boot/dts/mps2-an385.dts
+++ b/arch/arm/boot/dts/mps2-an385.dts
@@ -63,14 +63,10 @@
device_type = "memory";
reg = <0x21000000 0x1000000>;
};
+};
- ethernet at 40200000 {
- compatible = "smsc,lan9220", "smsc,lan9115";
- reg = <0x40200000 0x10000>;
- interrupts = <13>;
- interrupt-parent = <&nvic>;
- smsc,irq-active-high;
- };
+&mb {
+ ranges = <0 0x40200000 0x10000>;
};
&uart0 {
diff --git a/arch/arm/boot/dts/mps2.dtsi b/arch/arm/boot/dts/mps2.dtsi
index 5d2c539..1673472 100644
--- a/arch/arm/boot/dts/mps2.dtsi
+++ b/arch/arm/boot/dts/mps2.dtsi
@@ -223,5 +223,21 @@
default-state = "off";
};
};
+
+ };
+
+ mb: smb {
+ compatible = "simple-bus";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ ethernet at 0 {
+ compatible = "smsc,lan9220", "smsc,lan9115";
+ reg = <0x0 0x10000>;
+ interrupts = <13>;
+ interrupt-parent = <&nvic>;
+ smsc,irq-active-high;
+ };
};
};
Cheers
Vladimir
>
> Cheers
> Vladimir
>
>> Arnd
>>
>>
>>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
>
>
next prev parent reply other threads:[~2016-02-17 16:48 UTC|newest]
Thread overview: 113+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 10:08 [PATCH v3 00/10] Support for Cortex-M Prototyping System Vladimir Murzin
2016-02-16 10:08 ` Vladimir Murzin
2016-02-16 10:08 ` Vladimir Murzin
2016-02-16 10:08 ` [PATCH v3 01/10] dt-bindings: document the MPS2 timer bindings Vladimir Murzin
2016-02-16 10:08 ` Vladimir Murzin
2016-02-16 10:08 ` Vladimir Murzin
2016-02-16 10:08 ` [PATCH v3 02/10] clockevents/drivers: add MPS2 Timer driver Vladimir Murzin
2016-02-16 10:08 ` Vladimir Murzin
2016-02-16 10:08 ` Vladimir Murzin
2016-02-16 10:08 ` [PATCH v3 03/10] dt-bindings: document the MPS2 UART bindings Vladimir Murzin
2016-02-16 10:08 ` Vladimir Murzin
2016-02-16 10:08 ` [PATCH v3 04/10] serial: mps2-uart: add MPS2 UART driver Vladimir Murzin
2016-02-16 10:08 ` Vladimir Murzin
[not found] ` <1455617295-23736-5-git-send-email-vladimir.murzin-5wv7dgnIgG8@public.gmane.org>
2016-02-16 10:48 ` Andy Shevchenko
2016-02-16 10:48 ` Andy Shevchenko
2016-02-16 10:48 ` Andy Shevchenko
2016-02-16 14:25 ` Vladimir Murzin
2016-02-16 14:25 ` Vladimir Murzin
2016-02-16 11:02 ` One Thousand Gnomes
2016-02-16 11:02 ` One Thousand Gnomes
2016-02-16 15:09 ` Vladimir Murzin
2016-02-16 15:09 ` Vladimir Murzin
2016-02-16 10:08 ` [PATCH v3 05/10] serial: mps2-uart: add support for early console Vladimir Murzin
2016-02-16 10:08 ` Vladimir Murzin
2016-02-16 10:08 ` Vladimir Murzin
2016-02-16 10:36 ` Andy Shevchenko
2016-02-16 10:36 ` Andy Shevchenko
2016-02-16 13:09 ` Vladimir Murzin
2016-02-16 13:09 ` Vladimir Murzin
2016-02-16 13:13 ` Andy Shevchenko
2016-02-16 13:13 ` Andy Shevchenko
[not found] ` <CAHp75Vf_4MgdWunQy5hBMH5GGei+OkktFPYY-ZprY0qOEnD=wA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-16 13:38 ` Vladimir Murzin
2016-02-16 13:38 ` Vladimir Murzin
2016-02-16 13:38 ` Vladimir Murzin
[not found] ` <56C32641.4020201-5wv7dgnIgG8@public.gmane.org>
2016-02-16 14:00 ` Andy Shevchenko
2016-02-16 14:00 ` Andy Shevchenko
2016-02-16 14:00 ` Andy Shevchenko
2016-02-16 16:12 ` One Thousand Gnomes
2016-02-16 16:12 ` One Thousand Gnomes
[not found] ` <56C31F9F.10000-5wv7dgnIgG8@public.gmane.org>
2016-02-19 9:45 ` Vladimir Murzin
2016-02-19 9:45 ` Vladimir Murzin
2016-02-19 9:45 ` Vladimir Murzin
[not found] ` <56C6E42E.5070601-5wv7dgnIgG8@public.gmane.org>
2016-02-19 9:57 ` Andy Shevchenko
2016-02-19 9:57 ` Andy Shevchenko
2016-02-19 9:57 ` Andy Shevchenko
[not found] ` <CAHp75VcosaVcz_aYbpfL-nUH0kBf72SshXU5k95s48Z3wnA5nQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-19 15:46 ` Peter Hurley
2016-02-19 15:46 ` Peter Hurley
2016-02-19 15:46 ` Peter Hurley
[not found] ` <56C738F1.2070307-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>
2016-02-19 16:27 ` Vladimir Murzin
2016-02-19 16:27 ` Vladimir Murzin
2016-02-19 16:27 ` Vladimir Murzin
2016-02-16 10:08 ` [PATCH v3 06/10] ARM: mps2: introduce MPS2 platform Vladimir Murzin
2016-02-16 10:08 ` Vladimir Murzin
[not found] ` <1455617295-23736-7-git-send-email-vladimir.murzin-5wv7dgnIgG8@public.gmane.org>
2016-02-16 10:56 ` Arnd Bergmann
2016-02-16 10:56 ` Arnd Bergmann
2016-02-16 10:56 ` Arnd Bergmann
2016-02-16 14:35 ` Vladimir Murzin
2016-02-16 14:35 ` Vladimir Murzin
2016-02-16 14:35 ` Vladimir Murzin
[not found] ` <56C333BF.1020108-5wv7dgnIgG8@public.gmane.org>
2016-02-16 14:39 ` Arnd Bergmann
2016-02-16 14:39 ` Arnd Bergmann
2016-02-16 14:39 ` Arnd Bergmann
2016-02-16 10:08 ` [PATCH v3 07/10] ARM: mps2: add low-level debug support Vladimir Murzin
2016-02-16 10:08 ` Vladimir Murzin
2016-02-16 10:08 ` [PATCH v3 08/10] ARM: configs: add MPS2 defconfig Vladimir Murzin
2016-02-16 10:08 ` Vladimir Murzin
2016-02-16 10:58 ` Arnd Bergmann
2016-02-16 10:58 ` Arnd Bergmann
2016-02-16 14:51 ` Vladimir Murzin
2016-02-16 14:51 ` Vladimir Murzin
[not found] ` <56C3378F.2010008-5wv7dgnIgG8@public.gmane.org>
2016-02-16 15:08 ` Arnd Bergmann
2016-02-16 15:08 ` Arnd Bergmann
2016-02-16 15:08 ` Arnd Bergmann
2016-02-16 15:14 ` Vladimir Murzin
2016-02-16 15:14 ` Vladimir Murzin
2016-02-16 10:08 ` [PATCH v3 09/10] ARM: dts: introduce MPS2 AN385/AN386 Vladimir Murzin
2016-02-16 10:08 ` Vladimir Murzin
[not found] ` <1455617295-23736-10-git-send-email-vladimir.murzin-5wv7dgnIgG8@public.gmane.org>
2016-02-16 11:01 ` Arnd Bergmann
2016-02-16 11:01 ` Arnd Bergmann
2016-02-16 11:01 ` Arnd Bergmann
2016-02-16 16:10 ` Vladimir Murzin
2016-02-16 16:10 ` Vladimir Murzin
2016-02-17 16:48 ` Vladimir Murzin [this message]
2016-02-17 16:48 ` Vladimir Murzin
[not found] ` <56C4A46C.50506-5wv7dgnIgG8@public.gmane.org>
2016-02-17 16:58 ` Arnd Bergmann
2016-02-17 16:58 ` Arnd Bergmann
2016-02-17 16:58 ` Arnd Bergmann
2016-02-18 10:11 ` Vladimir Murzin
2016-02-18 10:11 ` Vladimir Murzin
2016-02-18 10:11 ` Vladimir Murzin
2016-02-18 10:45 ` Arnd Bergmann
2016-02-18 10:45 ` Arnd Bergmann
2016-02-18 11:13 ` Vladimir Murzin
2016-02-18 11:13 ` Vladimir Murzin
[not found] ` <56C5A742.8010304-5wv7dgnIgG8@public.gmane.org>
2016-02-18 12:16 ` Arnd Bergmann
2016-02-18 12:16 ` Arnd Bergmann
2016-02-18 12:16 ` Arnd Bergmann
2016-02-18 12:47 ` Vladimir Murzin
2016-02-18 12:47 ` Vladimir Murzin
2016-02-18 12:47 ` Vladimir Murzin
2016-02-16 15:17 ` Linus Walleij
2016-02-16 15:17 ` Linus Walleij
2016-02-16 15:17 ` Linus Walleij
2016-02-16 15:37 ` Vladimir Murzin
2016-02-16 15:37 ` Vladimir Murzin
2016-02-16 15:37 ` Vladimir Murzin
2016-02-16 10:08 ` [PATCH v3 10/10] ARM: dts: introduce MPS2 AN399/AN400 Vladimir Murzin
2016-02-16 10:08 ` Vladimir Murzin
2016-02-16 11:05 ` [PATCH v3 00/10] Support for Cortex-M Prototyping System Arnd Bergmann
2016-02-16 11:05 ` Arnd Bergmann
2016-02-16 16:14 ` Vladimir Murzin
2016-02-16 16:14 ` Vladimir Murzin
2016-02-16 16:14 ` Vladimir Murzin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C4A46C.50506@arm.com \
--to=vladimir.murzin@arm.com \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jslaby@suse.cz \
--cc=linux-api@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.