From: Jonathan Cameron <jic23@kernel.org>
To: Daniel Baluta <daniel.baluta@intel.com>, Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: pressure: ms5611: select IIO_BUFFER
Date: Wed, 17 Feb 2016 20:51:14 +0000 [thread overview]
Message-ID: <56C4DD42.9090400@kernel.org> (raw)
In-Reply-To: <CAEnQRZBk0R-A5VEEd_D+kLKnyhc3nhrm0tv2JOkv0iqywGFtuw@mail.gmail.com>
On 16/02/16 18:03, Daniel Baluta wrote:
> On Tue, Feb 16, 2016 at 4:55 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>> The ms5611 driver started using the IIO_TRIGGERED_BUFFER infrastructure
>> which in turn depend on IIO_BUFFER, and it produces a build error now
>> if that is not enabled:
>>
>> warning: (... && MS5611 && ...) selects IIO_TRIGGERED_BUFFER which has unmet direct dependencies (IIO && IIO_BUFFER)
>> buffer/industrialio-triggered-buffer.c: In function 'iio_triggered_buffer_setup':
>> buffer/industrialio-triggered-buffer.c:58:2: error: implicit declaration of function 'iio_device_attach_buffer' [-Werror=implicit-function-declaration]
>> pressure/ms5611_core.c: In function 'ms5611_trigger_handler':
>> pressure/ms5611_core.c:193:2: error: implicit declaration of function 'iio_push_to_buffers_with_timestamp' [-Werror=implicit-function-declaration]
>>
>> This adds the second select.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: 713bbb4efb9d ("iio: pressure: ms5611: Add triggered buffer support")
>
> Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Applied.
Thanks, I've gotten a bit too reliant on the autobuilders it seems.
Need to keep a closer eye on this stuff to stop wasting Arnd's time!
Jonathan
>
>> ---
>> drivers/iio/pressure/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/iio/pressure/Kconfig b/drivers/iio/pressure/Kconfig
>> index f15f66d6f527..31c0e1fd2202 100644
>> --- a/drivers/iio/pressure/Kconfig
>> +++ b/drivers/iio/pressure/Kconfig
>> @@ -69,6 +69,7 @@ config MPL3115
>>
>> config MS5611
>> tristate "Measurement Specialties MS5611 pressure sensor driver"
>> + select IIO_BUFFER
>> select IIO_TRIGGERED_BUFFER
>> help
>> Say Y here to build support for the Measurement Specialties
>> --
>> 2.7.0
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: jic23@kernel.org (Jonathan Cameron)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] iio: pressure: ms5611: select IIO_BUFFER
Date: Wed, 17 Feb 2016 20:51:14 +0000 [thread overview]
Message-ID: <56C4DD42.9090400@kernel.org> (raw)
In-Reply-To: <CAEnQRZBk0R-A5VEEd_D+kLKnyhc3nhrm0tv2JOkv0iqywGFtuw@mail.gmail.com>
On 16/02/16 18:03, Daniel Baluta wrote:
> On Tue, Feb 16, 2016 at 4:55 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>> The ms5611 driver started using the IIO_TRIGGERED_BUFFER infrastructure
>> which in turn depend on IIO_BUFFER, and it produces a build error now
>> if that is not enabled:
>>
>> warning: (... && MS5611 && ...) selects IIO_TRIGGERED_BUFFER which has unmet direct dependencies (IIO && IIO_BUFFER)
>> buffer/industrialio-triggered-buffer.c: In function 'iio_triggered_buffer_setup':
>> buffer/industrialio-triggered-buffer.c:58:2: error: implicit declaration of function 'iio_device_attach_buffer' [-Werror=implicit-function-declaration]
>> pressure/ms5611_core.c: In function 'ms5611_trigger_handler':
>> pressure/ms5611_core.c:193:2: error: implicit declaration of function 'iio_push_to_buffers_with_timestamp' [-Werror=implicit-function-declaration]
>>
>> This adds the second select.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: 713bbb4efb9d ("iio: pressure: ms5611: Add triggered buffer support")
>
> Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Applied.
Thanks, I've gotten a bit too reliant on the autobuilders it seems.
Need to keep a closer eye on this stuff to stop wasting Arnd's time!
Jonathan
>
>> ---
>> drivers/iio/pressure/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/iio/pressure/Kconfig b/drivers/iio/pressure/Kconfig
>> index f15f66d6f527..31c0e1fd2202 100644
>> --- a/drivers/iio/pressure/Kconfig
>> +++ b/drivers/iio/pressure/Kconfig
>> @@ -69,6 +69,7 @@ config MPL3115
>>
>> config MS5611
>> tristate "Measurement Specialties MS5611 pressure sensor driver"
>> + select IIO_BUFFER
>> select IIO_TRIGGERED_BUFFER
>> help
>> Say Y here to build support for the Measurement Specialties
>> --
>> 2.7.0
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo at vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-02-17 20:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 14:55 [PATCH] iio: pressure: ms5611: select IIO_BUFFER Arnd Bergmann
2016-02-16 14:55 ` Arnd Bergmann
2016-02-16 18:03 ` Daniel Baluta
2016-02-16 18:03 ` Daniel Baluta
2016-02-17 20:51 ` Jonathan Cameron [this message]
2016-02-17 20:51 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C4DD42.9090400@kernel.org \
--to=jic23@kernel.org \
--cc=arnd@arndb.de \
--cc=daniel.baluta@intel.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.