All of lore.kernel.org
 help / color / mirror / Atom feed
From: Janosch Frank <frankja@linux.vnet.ibm.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, frankja@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH] scripts/kvm/kvm_stat: Fix missing right parantheses
Date: Thu, 18 Feb 2016 12:42:56 +0100	[thread overview]
Message-ID: <56C5AE40.6080809@linux.vnet.ibm.com> (raw)
In-Reply-To: <1455689899-31227-1-git-send-email-famz@redhat.com>

On 02/17/2016 07:18 AM, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  scripts/kvm/kvm_stat | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat
> index 3cf1181..517fbec 100755
> --- a/scripts/kvm/kvm_stat
> +++ b/scripts/kvm/kvm_stat
> @@ -800,7 +800,7 @@ def check_access(options):
>          if options.tracepoints:
>              sys.exit(1)
> 
> -        sys.stderr.write("Falling back to debugfs statistics!\n"
> +        sys.stderr.write("Falling back to debugfs statistics!\n")
>          options.debugfs = True
>          sleep(5)
> 
Thanks for fixing that.
If you also want to fix the missing .format(PATH_DEBUGFS_TRACING) in the
write a few lines above, go ahead.

I should have been more careful when reading the pull mail from Paolo.
The affected lines are not my code and definitely not my v2 which
included the "exit if -t is passed explicitly" that Paolo added to my
commit.

  reply	other threads:[~2016-02-18 11:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-17  6:18 [Qemu-devel] [PATCH] scripts/kvm/kvm_stat: Fix missing right parantheses Fam Zheng
2016-02-18 11:42 ` Janosch Frank [this message]
2016-02-19  2:17   ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56C5AE40.6080809@linux.vnet.ibm.com \
    --to=frankja@linux.vnet.ibm.com \
    --cc=famz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.