* [Qemu-devel] [PATCH] scripts/kvm/kvm_stat: Fix missing right parantheses
@ 2016-02-17 6:18 Fam Zheng
2016-02-18 11:42 ` Janosch Frank
0 siblings, 1 reply; 3+ messages in thread
From: Fam Zheng @ 2016-02-17 6:18 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Jason J. Herne, Janosch Frank
Signed-off-by: Fam Zheng <famz@redhat.com>
---
scripts/kvm/kvm_stat | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat
index 3cf1181..517fbec 100755
--- a/scripts/kvm/kvm_stat
+++ b/scripts/kvm/kvm_stat
@@ -800,7 +800,7 @@ def check_access(options):
if options.tracepoints:
sys.exit(1)
- sys.stderr.write("Falling back to debugfs statistics!\n"
+ sys.stderr.write("Falling back to debugfs statistics!\n")
options.debugfs = True
sleep(5)
--
2.4.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] scripts/kvm/kvm_stat: Fix missing right parantheses
2016-02-17 6:18 [Qemu-devel] [PATCH] scripts/kvm/kvm_stat: Fix missing right parantheses Fam Zheng
@ 2016-02-18 11:42 ` Janosch Frank
2016-02-19 2:17 ` Fam Zheng
0 siblings, 1 reply; 3+ messages in thread
From: Janosch Frank @ 2016-02-18 11:42 UTC (permalink / raw)
To: Fam Zheng, qemu-devel; +Cc: Paolo Bonzini, frankja
On 02/17/2016 07:18 AM, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> scripts/kvm/kvm_stat | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat
> index 3cf1181..517fbec 100755
> --- a/scripts/kvm/kvm_stat
> +++ b/scripts/kvm/kvm_stat
> @@ -800,7 +800,7 @@ def check_access(options):
> if options.tracepoints:
> sys.exit(1)
>
> - sys.stderr.write("Falling back to debugfs statistics!\n"
> + sys.stderr.write("Falling back to debugfs statistics!\n")
> options.debugfs = True
> sleep(5)
>
Thanks for fixing that.
If you also want to fix the missing .format(PATH_DEBUGFS_TRACING) in the
write a few lines above, go ahead.
I should have been more careful when reading the pull mail from Paolo.
The affected lines are not my code and definitely not my v2 which
included the "exit if -t is passed explicitly" that Paolo added to my
commit.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] scripts/kvm/kvm_stat: Fix missing right parantheses
2016-02-18 11:42 ` Janosch Frank
@ 2016-02-19 2:17 ` Fam Zheng
0 siblings, 0 replies; 3+ messages in thread
From: Fam Zheng @ 2016-02-19 2:17 UTC (permalink / raw)
To: Janosch Frank; +Cc: Paolo Bonzini, qemu-devel
On Thu, 02/18 12:42, Janosch Frank wrote:
> On 02/17/2016 07:18 AM, Fam Zheng wrote:
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> > scripts/kvm/kvm_stat | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat
> > index 3cf1181..517fbec 100755
> > --- a/scripts/kvm/kvm_stat
> > +++ b/scripts/kvm/kvm_stat
> > @@ -800,7 +800,7 @@ def check_access(options):
> > if options.tracepoints:
> > sys.exit(1)
> >
> > - sys.stderr.write("Falling back to debugfs statistics!\n"
> > + sys.stderr.write("Falling back to debugfs statistics!\n")
> > options.debugfs = True
> > sleep(5)
> >
> Thanks for fixing that.
> If you also want to fix the missing .format(PATH_DEBUGFS_TRACING) in the
> write a few lines above, go ahead.
>
> I should have been more careful when reading the pull mail from Paolo.
> The affected lines are not my code and definitely not my v2 which
> included the "exit if -t is passed explicitly" that Paolo added to my
> commit.
>
Yep, I can do it. Will send v2.
Fam
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-19 2:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-17 6:18 [Qemu-devel] [PATCH] scripts/kvm/kvm_stat: Fix missing right parantheses Fam Zheng
2016-02-18 11:42 ` Janosch Frank
2016-02-19 2:17 ` Fam Zheng
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.