From: Sergey Fedorov <serge.fdrv@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-arm] [PATCH 07/11] target-arm: Add Hyp mode checks to bad_mode_switch()
Date: Thu, 18 Feb 2016 20:43:31 +0300 [thread overview]
Message-ID: <56C602C3.2080808@gmail.com> (raw)
In-Reply-To: <1455556977-3644-8-git-send-email-peter.maydell@linaro.org>
On 15.02.2016 20:22, Peter Maydell wrote:
> We don't actually support Hyp mode yet, but add the correct
> checks for it to the bad_mode_switch() function for completeness.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Sergey Fedorov <serge.fdrv@gmail.com>
> ---
> target-arm/helper.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/target-arm/helper.c b/target-arm/helper.c
> index 37b5439..4074b97 100644
> --- a/target-arm/helper.c
> +++ b/target-arm/helper.c
> @@ -5184,6 +5184,9 @@ static int bad_mode_switch(CPUARMState *env, int mode)
> * allows FIQ mode to be Secure-only. (In v8 this doesn't exist.)
> */
> return 0;
> + case ARM_CPU_MODE_HYP:
> + return !arm_feature(env, ARM_FEATURE_EL2)
> + || arm_current_el(env) < 2 || arm_is_secure(env);
> case ARM_CPU_MODE_MON:
> return !arm_is_secure(env);
> default:
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Fedorov <serge.fdrv@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
qemu-arm@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 07/11] target-arm: Add Hyp mode checks to bad_mode_switch()
Date: Thu, 18 Feb 2016 20:43:31 +0300 [thread overview]
Message-ID: <56C602C3.2080808@gmail.com> (raw)
In-Reply-To: <1455556977-3644-8-git-send-email-peter.maydell@linaro.org>
On 15.02.2016 20:22, Peter Maydell wrote:
> We don't actually support Hyp mode yet, but add the correct
> checks for it to the bad_mode_switch() function for completeness.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Sergey Fedorov <serge.fdrv@gmail.com>
> ---
> target-arm/helper.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/target-arm/helper.c b/target-arm/helper.c
> index 37b5439..4074b97 100644
> --- a/target-arm/helper.c
> +++ b/target-arm/helper.c
> @@ -5184,6 +5184,9 @@ static int bad_mode_switch(CPUARMState *env, int mode)
> * allows FIQ mode to be Secure-only. (In v8 this doesn't exist.)
> */
> return 0;
> + case ARM_CPU_MODE_HYP:
> + return !arm_feature(env, ARM_FEATURE_EL2)
> + || arm_current_el(env) < 2 || arm_is_secure(env);
> case ARM_CPU_MODE_MON:
> return !arm_is_secure(env);
> default:
next prev parent reply other threads:[~2016-02-18 17:44 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 17:22 [Qemu-devel] [PATCH 00/11] target-arm: clean up cpsr_write mode changing Peter Maydell
2016-02-15 17:22 ` [Qemu-arm] [PATCH 01/11] target-arm: Give CPSR setting on 32-bit exception return its own helper Peter Maydell
2016-02-15 17:22 ` [Qemu-devel] " Peter Maydell
2016-02-18 17:41 ` [Qemu-arm] " Sergey Fedorov
2016-02-18 17:41 ` [Qemu-devel] " Sergey Fedorov
2016-02-15 17:22 ` [Qemu-arm] [PATCH 02/11] target-arm: Add write_type argument to cpsr_write() Peter Maydell
2016-02-15 17:22 ` [Qemu-devel] " Peter Maydell
2016-02-18 17:42 ` [Qemu-arm] " Sergey Fedorov
2016-02-18 17:42 ` [Qemu-devel] " Sergey Fedorov
2016-02-15 17:22 ` [Qemu-devel] [PATCH 03/11] target-arm: Raw CPSR writes should skip checks and bank switching Peter Maydell
2016-02-18 17:42 ` [Qemu-arm] " Sergey Fedorov
2016-02-18 17:42 ` [Qemu-devel] " Sergey Fedorov
2016-02-15 17:22 ` [Qemu-arm] [PATCH 04/11] linux-user: Use restrictive mask when calling cpsr_write() Peter Maydell
2016-02-15 17:22 ` [Qemu-devel] " Peter Maydell
2016-02-18 17:42 ` Sergey Fedorov
2016-02-15 17:22 ` [Qemu-arm] [PATCH 05/11] target-arm: In cpsr_write() ignore mode switches from User mode Peter Maydell
2016-02-15 17:22 ` [Qemu-devel] " Peter Maydell
2016-02-18 17:43 ` [Qemu-arm] " Sergey Fedorov
2016-02-18 17:43 ` [Qemu-devel] " Sergey Fedorov
2016-02-15 17:22 ` [Qemu-devel] [PATCH 06/11] target-arm: Add comment about not implementing NSACR.RFR Peter Maydell
2016-02-18 17:43 ` Sergey Fedorov
2016-02-15 17:22 ` [Qemu-devel] [PATCH 07/11] target-arm: Add Hyp mode checks to bad_mode_switch() Peter Maydell
2016-02-18 17:43 ` Sergey Fedorov [this message]
2016-02-18 17:43 ` Sergey Fedorov
2016-02-15 17:22 ` [Qemu-devel] [PATCH 08/11] target-arm: Forbid mode switch to Mon from Secure EL1 Peter Maydell
2016-02-18 17:43 ` [Qemu-arm] " Sergey Fedorov
2016-02-18 17:43 ` Sergey Fedorov
2016-02-15 17:22 ` [Qemu-devel] [PATCH 09/11] target-arm: In v8, make illegal AArch32 mode changes set PSTATE.IL Peter Maydell
2016-02-18 17:44 ` [Qemu-arm] " Sergey Fedorov
2016-02-18 17:44 ` [Qemu-devel] " Sergey Fedorov
2016-02-15 17:22 ` [Qemu-devel] [PATCH 10/11] target-arm: Make mode switches from Hyp via CPS and MRS illegal Peter Maydell
2016-02-18 17:44 ` [Qemu-arm] " Sergey Fedorov
2016-02-18 17:44 ` [Qemu-devel] " Sergey Fedorov
2016-02-15 17:22 ` [Qemu-devel] [PATCH 11/11] target-arm: Make Monitor->NS PL1 mode changes illegal if HCR.TGE is 1 Peter Maydell
2016-02-18 17:44 ` [Qemu-arm] " Sergey Fedorov
2016-02-18 17:44 ` [Qemu-devel] " Sergey Fedorov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C602C3.2080808@gmail.com \
--to=serge.fdrv@gmail.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.