All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Jan Kara <jack@suse.cz>, linux-fsdevel@vger.kernel.org
Cc: Mark Fasheh <mfasheh@suse.com>, Joel Becker <jlbec@evilplan.org>,
	ocfs2-devel@oss.oracle.com, xfs@oss.sgi.com
Subject: Re: [PATCH 1/3] quota: Add support for ->get_nextdqblk() for VFS quota
Date: Fri, 19 Feb 2016 11:31:58 -0600	[thread overview]
Message-ID: <56C7518E.4020204@sandeen.net> (raw)
In-Reply-To: <1454596087-6814-2-git-send-email-jack@suse.cz>



On 2/4/16 8:28 AM, Jan Kara wrote:
> Add infrastructure for supporting get_nextdqblk() callback for VFS
> quotas. Translate the operation into a callback to appropriate
> filesystem and consequently to quota format callback.
> 
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
>  fs/ext4/super.c          |  1 +
>  fs/quota/dquot.c         | 39 +++++++++++++++++++++++++++++++++++++++
>  fs/reiserfs/super.c      |  1 +
>  include/linux/quota.h    |  3 +++
>  include/linux/quotaops.h |  3 +++
>  5 files changed, 47 insertions(+)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index f1b56ff01208..51649f442bf6 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -1100,6 +1100,7 @@ static const struct dquot_operations ext4_quota_operations = {
>  	.write_info	= ext4_write_info,
>  	.alloc_dquot	= dquot_alloc,
>  	.destroy_dquot	= dquot_destroy,
> +	.get_next_id	= dquot_get_next_id,
>  };

Hi Jan, doesn't this also need to set:


+       .get_nextdqblk  = dquot_get_next_dqblk,

in ext4_qctl_sysfile_operations?

Thanks,
-Eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Eric Sandeen <sandeen@sandeen.net>
To: Jan Kara <jack@suse.cz>, linux-fsdevel@vger.kernel.org
Cc: ocfs2-devel@oss.oracle.com, Mark Fasheh <mfasheh@suse.com>,
	Joel Becker <jlbec@evilplan.org>,
	xfs@oss.sgi.com
Subject: [Ocfs2-devel] [PATCH 1/3] quota: Add support for ->get_nextdqblk() for VFS quota
Date: Fri, 19 Feb 2016 11:31:58 -0600	[thread overview]
Message-ID: <56C7518E.4020204@sandeen.net> (raw)
In-Reply-To: <1454596087-6814-2-git-send-email-jack@suse.cz>



On 2/4/16 8:28 AM, Jan Kara wrote:
> Add infrastructure for supporting get_nextdqblk() callback for VFS
> quotas. Translate the operation into a callback to appropriate
> filesystem and consequently to quota format callback.
> 
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
>  fs/ext4/super.c          |  1 +
>  fs/quota/dquot.c         | 39 +++++++++++++++++++++++++++++++++++++++
>  fs/reiserfs/super.c      |  1 +
>  include/linux/quota.h    |  3 +++
>  include/linux/quotaops.h |  3 +++
>  5 files changed, 47 insertions(+)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index f1b56ff01208..51649f442bf6 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -1100,6 +1100,7 @@ static const struct dquot_operations ext4_quota_operations = {
>  	.write_info	= ext4_write_info,
>  	.alloc_dquot	= dquot_alloc,
>  	.destroy_dquot	= dquot_destroy,
> +	.get_next_id	= dquot_get_next_id,
>  };

Hi Jan, doesn't this also need to set:


+       .get_nextdqblk  = dquot_get_next_dqblk,

in ext4_qctl_sysfile_operations?

Thanks,
-Eric

WARNING: multiple messages have this Message-ID (diff)
From: Eric Sandeen <sandeen@sandeen.net>
To: Jan Kara <jack@suse.cz>, linux-fsdevel@vger.kernel.org
Cc: ocfs2-devel@oss.oracle.com, Mark Fasheh <mfasheh@suse.com>,
	Joel Becker <jlbec@evilplan.org>,
	xfs@oss.sgi.com
Subject: Re: [PATCH 1/3] quota: Add support for ->get_nextdqblk() for VFS quota
Date: Fri, 19 Feb 2016 11:31:58 -0600	[thread overview]
Message-ID: <56C7518E.4020204@sandeen.net> (raw)
In-Reply-To: <1454596087-6814-2-git-send-email-jack@suse.cz>



On 2/4/16 8:28 AM, Jan Kara wrote:
> Add infrastructure for supporting get_nextdqblk() callback for VFS
> quotas. Translate the operation into a callback to appropriate
> filesystem and consequently to quota format callback.
> 
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
>  fs/ext4/super.c          |  1 +
>  fs/quota/dquot.c         | 39 +++++++++++++++++++++++++++++++++++++++
>  fs/reiserfs/super.c      |  1 +
>  include/linux/quota.h    |  3 +++
>  include/linux/quotaops.h |  3 +++
>  5 files changed, 47 insertions(+)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index f1b56ff01208..51649f442bf6 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -1100,6 +1100,7 @@ static const struct dquot_operations ext4_quota_operations = {
>  	.write_info	= ext4_write_info,
>  	.alloc_dquot	= dquot_alloc,
>  	.destroy_dquot	= dquot_destroy,
> +	.get_next_id	= dquot_get_next_id,
>  };

Hi Jan, doesn't this also need to set:


+       .get_nextdqblk  = dquot_get_next_dqblk,

in ext4_qctl_sysfile_operations?

Thanks,
-Eric

  parent reply	other threads:[~2016-02-19 17:50 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-04 14:28 [PATCH 0/3 v2] Q_GETNEXTQUOTA support Jan Kara
2016-02-04 14:28 ` Jan Kara
2016-02-04 14:28 ` [Ocfs2-devel] " Jan Kara
2016-02-04 14:28 ` [PATCH 1/3] quota: Add support for ->get_nextdqblk() for VFS quota Jan Kara
2016-02-04 14:28   ` Jan Kara
2016-02-04 14:28   ` [Ocfs2-devel] " Jan Kara
2016-02-05  1:05   ` Dave Chinner
2016-02-05  1:05     ` Dave Chinner
2016-02-05  1:05     ` [Ocfs2-devel] " Dave Chinner
2016-02-08  6:15     ` Dave Chinner
2016-02-08  6:15       ` Dave Chinner
2016-02-08  6:15       ` [Ocfs2-devel] " Dave Chinner
2016-02-08 14:27     ` Jan Kara
2016-02-08 14:27       ` Jan Kara
2016-02-08 14:27       ` [Ocfs2-devel] " Jan Kara
2016-02-08 14:34       ` Jan Kara
2016-02-08 14:34         ` Jan Kara
2016-02-08 14:34         ` [Ocfs2-devel] " Jan Kara
2016-02-19 17:31   ` Eric Sandeen [this message]
2016-02-19 17:31     ` Eric Sandeen
2016-02-19 17:31     ` [Ocfs2-devel] " Eric Sandeen
2016-02-19 18:33     ` Jan Kara
2016-02-19 18:33       ` Jan Kara
2016-02-19 18:33       ` [Ocfs2-devel] " Jan Kara
2016-02-19 18:43       ` Eric Sandeen
2016-02-19 18:43         ` Eric Sandeen
2016-02-19 18:43         ` [Ocfs2-devel] " Eric Sandeen
2016-02-22  8:01         ` Jan Kara
2016-02-22  8:01           ` Jan Kara
2016-02-22  8:01           ` [Ocfs2-devel] " Jan Kara
2016-02-04 14:28 ` [PATCH 2/3] quota_v2: Implement get_next_id() for V2 quota format Jan Kara
2016-02-04 14:28   ` Jan Kara
2016-02-04 14:28   ` [Ocfs2-devel] " Jan Kara
2016-02-04 14:28 ` [PATCH 3/3] ocfs2: Implement get_next_id() Jan Kara
2016-02-04 14:28   ` Jan Kara
2016-02-04 14:28   ` [Ocfs2-devel] " Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56C7518E.4020204@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=jack@suse.cz \
    --cc=jlbec@evilplan.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=mfasheh@suse.com \
    --cc=ocfs2-devel@oss.oracle.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.