From: hitmoon <zxq_yx_007@163.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Guan Xuetao" <gxt@mprc.pku.edu.cn>,
"Igor Mitsyanko" <i.mitsyanko@gmail.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Michael Walle" <michael@walle.cc>,
qemu-arm <qemu-arm@nongnu.org>,
"Maksim Kozlov" <m.kozlov@samsung.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-arm] [PATCH v4 9/9] hw/timer: QOM'ify tusb6010
Date: Mon, 22 Feb 2016 17:20:23 +0800 [thread overview]
Message-ID: <56CAD2D7.2000009@163.com> (raw)
In-Reply-To: <CAFEAcA-iTcWTX5eVpe9NWb5MqYVcxUajRCnzQVFY=raBq-an4w@mail.gmail.com>
在 2016年02月22日 17:18, Peter Maydell 写道:
> On 22 February 2016 at 03:15, xiaoqiang zhao <zxq_yx_007@163.com> wrote:
>> Move majority of old SysBus init's work the into instance_init.
>>
>> Note:
>> musb_init must be called in SysBus's init, otherwise it will
>> break "make check" with error message as follows:
>>
>> qom/object.c:1576:object_get_canonical_path_component: assertion failed: (obj->parent != NULL)
>>
>> Signed-off-by: xiaoqiang zhao <zxq_yx_007@163.com>
>> ---
>> hw/timer/tusb6010.c | 23 ++++++++++++++++-------
>> 1 file changed, 16 insertions(+), 7 deletions(-)
> Devices should either be instance_init + realize, or
> sysbus-init. This patch would make this device be a mix
> of both. You should just drop this patch until musb has
> been properly QOMified.
>
> thanks
> -- PMM
Ok.
WARNING: multiple messages have this Message-ID (diff)
From: hitmoon <zxq_yx_007@163.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Guan Xuetao" <gxt@mprc.pku.edu.cn>,
"Igor Mitsyanko" <i.mitsyanko@gmail.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Michael Walle" <michael@walle.cc>,
qemu-arm <qemu-arm@nongnu.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Maksim Kozlov" <m.kozlov@samsung.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v4 9/9] hw/timer: QOM'ify tusb6010
Date: Mon, 22 Feb 2016 17:20:23 +0800 [thread overview]
Message-ID: <56CAD2D7.2000009@163.com> (raw)
In-Reply-To: <CAFEAcA-iTcWTX5eVpe9NWb5MqYVcxUajRCnzQVFY=raBq-an4w@mail.gmail.com>
在 2016年02月22日 17:18, Peter Maydell 写道:
> On 22 February 2016 at 03:15, xiaoqiang zhao <zxq_yx_007@163.com> wrote:
>> Move majority of old SysBus init's work the into instance_init.
>>
>> Note:
>> musb_init must be called in SysBus's init, otherwise it will
>> break "make check" with error message as follows:
>>
>> qom/object.c:1576:object_get_canonical_path_component: assertion failed: (obj->parent != NULL)
>>
>> Signed-off-by: xiaoqiang zhao <zxq_yx_007@163.com>
>> ---
>> hw/timer/tusb6010.c | 23 ++++++++++++++++-------
>> 1 file changed, 16 insertions(+), 7 deletions(-)
> Devices should either be instance_init + realize, or
> sysbus-init. This patch would make this device be a mix
> of both. You should just drop this patch until musb has
> been properly QOMified.
>
> thanks
> -- PMM
Ok.
next prev parent reply other threads:[~2016-02-22 9:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 3:15 [Qemu-devel] [PATCH v4 0/9] QOM'ify hw/timer/* xiaoqiang zhao
2016-02-22 3:15 ` [Qemu-arm] [PATCH v4 1/9] hw/timer: QOM'ify etraxfs_timer xiaoqiang zhao
2016-02-22 3:15 ` [Qemu-devel] " xiaoqiang zhao
2016-02-22 3:15 ` [Qemu-arm] [PATCH v4 2/9] hw/timer: QOM'ify grlib_gptimer xiaoqiang zhao
2016-02-22 3:15 ` [Qemu-devel] " xiaoqiang zhao
2016-02-22 3:15 ` [Qemu-devel] [PATCH v4 3/9] hw/timer: QOM'ify lm32_timer xiaoqiang zhao
2016-03-17 14:59 ` michael
2016-03-17 15:00 ` [Qemu-arm] " Peter Maydell
2016-03-17 15:00 ` [Qemu-devel] " Peter Maydell
2016-03-17 15:02 ` michael
2016-02-22 3:15 ` [Qemu-devel] [PATCH v4 4/9] hw/timer: QOM'ify m48txx_sysbus (pass 1) xiaoqiang zhao
2016-02-22 3:15 ` [Qemu-devel] [PATCH v4 6/9] hw/timer: QOM'ify milkymist_sysctl xiaoqiang zhao
2016-03-17 15:00 ` michael
2016-03-17 15:03 ` michael
2016-03-18 3:14 ` [Qemu-arm] " xiaoqiang zhao
2016-03-18 3:14 ` xiaoqiang zhao
2016-02-22 3:15 ` [Qemu-devel] [PATCH v4 7/9] hw/timer: QOM'ify puv3_ost xiaoqiang zhao
2016-02-22 3:15 ` [Qemu-devel] [PATCH v4 8/9] hw/timer: QOM'ify slavio_timer xiaoqiang zhao
2016-02-22 3:15 ` [Qemu-devel] [PATCH v4 9/9] hw/timer: QOM'ify tusb6010 xiaoqiang zhao
2016-02-22 9:18 ` Peter Maydell
2016-02-22 9:20 ` hitmoon [this message]
2016-02-22 9:20 ` hitmoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CAD2D7.2000009@163.com \
--to=zxq_yx_007@163.com \
--cc=afaerber@suse.de \
--cc=gxt@mprc.pku.edu.cn \
--cc=i.mitsyanko@gmail.com \
--cc=m.kozlov@samsung.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=michael@walle.cc \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.