* [PATCH] Irq/mbigen:Promote the mbigen driver register timing @ 2016-02-22 11:00 ` MaJun 0 siblings, 0 replies; 4+ messages in thread From: MaJun @ 2016-02-22 11:00 UTC (permalink / raw) To: linux-arm-kernel From: Ma Jun <majun258@huawei.com> Using module_platform_driver() to register mbigen driver is too late for some driver to apply irq, because the mbigen irq domain is not created yet. Signed-off-by: Ma Jun <majun258@huawei.com> --- drivers/irqchip/irq-mbigen.c | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c index 4dd3eb8..4df359c 100644 --- a/drivers/irqchip/irq-mbigen.c +++ b/drivers/irqchip/irq-mbigen.c @@ -289,7 +289,14 @@ static struct platform_driver mbigen_platform_driver = { .probe = mbigen_device_probe, }; -module_platform_driver(mbigen_platform_driver); +static __init int mbigen_init(void) + +{ + return platform_driver_register(&mbigen_platform_driver); + +} + +arch_initcall(mbigen_init); MODULE_AUTHOR("Jun Ma <majun258@huawei.com>"); MODULE_AUTHOR("Yun Wu <wuyun.wu@huawei.com>"); -- 1.7.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] Irq/mbigen:Promote the mbigen driver register timing @ 2016-02-22 11:00 ` MaJun 0 siblings, 0 replies; 4+ messages in thread From: MaJun @ 2016-02-22 11:00 UTC (permalink / raw) To: Catalin.Marinas, linux-kernel, linux-arm-kernel, Will.Deacon, mark.rutland, marc.zyngier, jason, tglx, lizefan, huxinwei, dingtianhong, liguozhu, guohanjun, majun258, zhaojunhua From: Ma Jun <majun258@huawei.com> Using module_platform_driver() to register mbigen driver is too late for some driver to apply irq, because the mbigen irq domain is not created yet. Signed-off-by: Ma Jun <majun258@huawei.com> --- drivers/irqchip/irq-mbigen.c | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c index 4dd3eb8..4df359c 100644 --- a/drivers/irqchip/irq-mbigen.c +++ b/drivers/irqchip/irq-mbigen.c @@ -289,7 +289,14 @@ static struct platform_driver mbigen_platform_driver = { .probe = mbigen_device_probe, }; -module_platform_driver(mbigen_platform_driver); +static __init int mbigen_init(void) + +{ + return platform_driver_register(&mbigen_platform_driver); + +} + +arch_initcall(mbigen_init); MODULE_AUTHOR("Jun Ma <majun258@huawei.com>"); MODULE_AUTHOR("Yun Wu <wuyun.wu@huawei.com>"); -- 1.7.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] Irq/mbigen:Promote the mbigen driver register timing 2016-02-22 11:00 ` MaJun @ 2016-02-22 11:24 ` Marc Zyngier -1 siblings, 0 replies; 4+ messages in thread From: Marc Zyngier @ 2016-02-22 11:24 UTC (permalink / raw) To: linux-arm-kernel On 22/02/16 11:00, MaJun wrote: > From: Ma Jun <majun258@huawei.com> > > Using module_platform_driver() to register mbigen driver is > too late for some driver to apply irq, because the mbigen irq > domain is not created yet. > > Signed-off-by: Ma Jun <majun258@huawei.com> > --- > drivers/irqchip/irq-mbigen.c | 9 ++++++++- > 1 files changed, 8 insertions(+), 1 deletions(-) > > diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c > index 4dd3eb8..4df359c 100644 > --- a/drivers/irqchip/irq-mbigen.c > +++ b/drivers/irqchip/irq-mbigen.c > @@ -289,7 +289,14 @@ static struct platform_driver mbigen_platform_driver = { > .probe = mbigen_device_probe, > }; > > -module_platform_driver(mbigen_platform_driver); > +static __init int mbigen_init(void) > + > +{ > + return platform_driver_register(&mbigen_platform_driver); > + > +} > + > +arch_initcall(mbigen_init); > > MODULE_AUTHOR("Jun Ma <majun258@huawei.com>"); > MODULE_AUTHOR("Yun Wu <wuyun.wu@huawei.com>"); > I don't believe this is a proper fix, and already said so when reviewing this code: http://www.spinics.net/lists/linux-pci/msg46534.html Short of actually solving the dependencies, it is likely that you will only move the problem somewhere else. I suggest you engage will people that are working on a proper solution, and/or fix the drivers to gracefully defer their probing if their IRQs are not available. Thanks, M. -- Jazz is not dead. It just smells funny... ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Irq/mbigen:Promote the mbigen driver register timing @ 2016-02-22 11:24 ` Marc Zyngier 0 siblings, 0 replies; 4+ messages in thread From: Marc Zyngier @ 2016-02-22 11:24 UTC (permalink / raw) To: MaJun, Catalin.Marinas, linux-kernel, linux-arm-kernel, Will.Deacon, mark.rutland, jason, tglx, lizefan, huxinwei, dingtianhong, liguozhu, guohanjun, zhaojunhua On 22/02/16 11:00, MaJun wrote: > From: Ma Jun <majun258@huawei.com> > > Using module_platform_driver() to register mbigen driver is > too late for some driver to apply irq, because the mbigen irq > domain is not created yet. > > Signed-off-by: Ma Jun <majun258@huawei.com> > --- > drivers/irqchip/irq-mbigen.c | 9 ++++++++- > 1 files changed, 8 insertions(+), 1 deletions(-) > > diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c > index 4dd3eb8..4df359c 100644 > --- a/drivers/irqchip/irq-mbigen.c > +++ b/drivers/irqchip/irq-mbigen.c > @@ -289,7 +289,14 @@ static struct platform_driver mbigen_platform_driver = { > .probe = mbigen_device_probe, > }; > > -module_platform_driver(mbigen_platform_driver); > +static __init int mbigen_init(void) > + > +{ > + return platform_driver_register(&mbigen_platform_driver); > + > +} > + > +arch_initcall(mbigen_init); > > MODULE_AUTHOR("Jun Ma <majun258@huawei.com>"); > MODULE_AUTHOR("Yun Wu <wuyun.wu@huawei.com>"); > I don't believe this is a proper fix, and already said so when reviewing this code: http://www.spinics.net/lists/linux-pci/msg46534.html Short of actually solving the dependencies, it is likely that you will only move the problem somewhere else. I suggest you engage will people that are working on a proper solution, and/or fix the drivers to gracefully defer their probing if their IRQs are not available. Thanks, M. -- Jazz is not dead. It just smells funny... ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-22 11:24 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-02-22 11:00 [PATCH] Irq/mbigen:Promote the mbigen driver register timing MaJun 2016-02-22 11:00 ` MaJun 2016-02-22 11:24 ` Marc Zyngier 2016-02-22 11:24 ` Marc Zyngier
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.