* [Qemu-trivial] [PATCH 0/2] use PCI_MSIX_FLAGS on retrieving the MSIX entries @ 2016-02-19 15:18 ` Wei Yang 0 siblings, 0 replies; 20+ messages in thread From: Wei Yang @ 2016-02-19 15:18 UTC (permalink / raw) Cc: qemu-trivial, qemu-devel, Wei Yang These two patches replace the PCI_CAP_FLAGS with PCI_MSIX_FLAGS on retrieving the MSIX entries. The change is the same, while I put them in two patches for different author to review. Wei Yang (2): vfio/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries s390x/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries hw/s390x/s390-pci-bus.c | 2 +- hw/vfio/pci.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 1.7.9.5 ^ permalink raw reply [flat|nested] 20+ messages in thread
* [Qemu-devel] [PATCH 0/2] use PCI_MSIX_FLAGS on retrieving the MSIX entries @ 2016-02-19 15:18 ` Wei Yang 0 siblings, 0 replies; 20+ messages in thread From: Wei Yang @ 2016-02-19 15:18 UTC (permalink / raw) Cc: qemu-trivial, qemu-devel, Wei Yang These two patches replace the PCI_CAP_FLAGS with PCI_MSIX_FLAGS on retrieving the MSIX entries. The change is the same, while I put them in two patches for different author to review. Wei Yang (2): vfio/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries s390x/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries hw/s390x/s390-pci-bus.c | 2 +- hw/vfio/pci.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 1.7.9.5 ^ permalink raw reply [flat|nested] 20+ messages in thread
* [Qemu-trivial] [PATCH 1/2] vfio/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries 2016-02-19 15:18 ` [Qemu-devel] " Wei Yang @ 2016-02-19 15:18 ` Wei Yang -1 siblings, 0 replies; 20+ messages in thread From: Wei Yang @ 2016-02-19 15:18 UTC (permalink / raw) Cc: qemu-trivial, qemu-devel, Wei Yang Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is the more proper on retrieving MSIX entries. This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries. Signed-off-by: Wei Yang <richard.weiyang@gmail.com> --- hw/vfio/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index e66c47f..321423b 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -1210,7 +1210,7 @@ static int vfio_msix_early_setup(VFIOPCIDevice *vdev) } if (pread(fd, &ctrl, sizeof(ctrl), - vdev->config_offset + pos + PCI_CAP_FLAGS) != sizeof(ctrl)) { + vdev->config_offset + pos + PCI_MSIX_FLAGS) != sizeof(ctrl)) { return -errno; } -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [Qemu-devel] [PATCH 1/2] vfio/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries @ 2016-02-19 15:18 ` Wei Yang 0 siblings, 0 replies; 20+ messages in thread From: Wei Yang @ 2016-02-19 15:18 UTC (permalink / raw) Cc: qemu-trivial, qemu-devel, Wei Yang Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is the more proper on retrieving MSIX entries. This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries. Signed-off-by: Wei Yang <richard.weiyang@gmail.com> --- hw/vfio/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index e66c47f..321423b 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -1210,7 +1210,7 @@ static int vfio_msix_early_setup(VFIOPCIDevice *vdev) } if (pread(fd, &ctrl, sizeof(ctrl), - vdev->config_offset + pos + PCI_CAP_FLAGS) != sizeof(ctrl)) { + vdev->config_offset + pos + PCI_MSIX_FLAGS) != sizeof(ctrl)) { return -errno; } -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/2] vfio/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries 2016-02-19 15:18 ` [Qemu-devel] " Wei Yang @ 2016-02-19 16:45 ` Alex Williamson -1 siblings, 0 replies; 20+ messages in thread From: Alex Williamson @ 2016-02-19 16:45 UTC (permalink / raw) To: Wei Yang; +Cc: qemu-trivial, qemu-devel On Fri, 19 Feb 2016 15:18:10 +0000 Wei Yang <richard.weiyang@gmail.com> wrote: > Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is > the more proper on retrieving MSIX entries. > > This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries. > > Signed-off-by: Wei Yang <richard.weiyang@gmail.com> > --- > hw/vfio/pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > index e66c47f..321423b 100644 > --- a/hw/vfio/pci.c > +++ b/hw/vfio/pci.c > @@ -1210,7 +1210,7 @@ static int vfio_msix_early_setup(VFIOPCIDevice *vdev) > } > > if (pread(fd, &ctrl, sizeof(ctrl), > - vdev->config_offset + pos + PCI_CAP_FLAGS) != sizeof(ctrl)) { > + vdev->config_offset + pos + PCI_MSIX_FLAGS) != sizeof(ctrl)) { > return -errno; > } > This is certainly trivial, I'll grab it for the respin of yesterday's pull request. Thanks, Alex ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Qemu-devel] [PATCH 1/2] vfio/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries @ 2016-02-19 16:45 ` Alex Williamson 0 siblings, 0 replies; 20+ messages in thread From: Alex Williamson @ 2016-02-19 16:45 UTC (permalink / raw) To: Wei Yang; +Cc: qemu-trivial, qemu-devel On Fri, 19 Feb 2016 15:18:10 +0000 Wei Yang <richard.weiyang@gmail.com> wrote: > Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is > the more proper on retrieving MSIX entries. > > This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries. > > Signed-off-by: Wei Yang <richard.weiyang@gmail.com> > --- > hw/vfio/pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > index e66c47f..321423b 100644 > --- a/hw/vfio/pci.c > +++ b/hw/vfio/pci.c > @@ -1210,7 +1210,7 @@ static int vfio_msix_early_setup(VFIOPCIDevice *vdev) > } > > if (pread(fd, &ctrl, sizeof(ctrl), > - vdev->config_offset + pos + PCI_CAP_FLAGS) != sizeof(ctrl)) { > + vdev->config_offset + pos + PCI_MSIX_FLAGS) != sizeof(ctrl)) { > return -errno; > } > This is certainly trivial, I'll grab it for the respin of yesterday's pull request. Thanks, Alex ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/2] vfio/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries 2016-02-19 16:45 ` Alex Williamson @ 2016-02-19 23:38 ` Wei Yang -1 siblings, 0 replies; 20+ messages in thread From: Wei Yang @ 2016-02-19 23:38 UTC (permalink / raw) To: Alex Williamson; +Cc: qemu-trivial, qemu-devel, Wei Yang On Fri, Feb 19, 2016 at 09:45:32AM -0700, Alex Williamson wrote: >On Fri, 19 Feb 2016 15:18:10 +0000 >Wei Yang <richard.weiyang@gmail.com> wrote: > >> Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is >> the more proper on retrieving MSIX entries. >> >> This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries. >> >> Signed-off-by: Wei Yang <richard.weiyang@gmail.com> >> --- >> hw/vfio/pci.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c >> index e66c47f..321423b 100644 >> --- a/hw/vfio/pci.c >> +++ b/hw/vfio/pci.c >> @@ -1210,7 +1210,7 @@ static int vfio_msix_early_setup(VFIOPCIDevice *vdev) >> } >> >> if (pread(fd, &ctrl, sizeof(ctrl), >> - vdev->config_offset + pos + PCI_CAP_FLAGS) != sizeof(ctrl)) { >> + vdev->config_offset + pos + PCI_MSIX_FLAGS) != sizeof(ctrl)) { >> return -errno; >> } >> > >This is certainly trivial, I'll grab it for the respin of yesterday's >pull request. Thanks, Thanks Alex, have a nice weekend :-) > >Alex -- Wei Yang Help you, Help me ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Qemu-devel] [PATCH 1/2] vfio/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries @ 2016-02-19 23:38 ` Wei Yang 0 siblings, 0 replies; 20+ messages in thread From: Wei Yang @ 2016-02-19 23:38 UTC (permalink / raw) To: Alex Williamson; +Cc: qemu-trivial, qemu-devel, Wei Yang On Fri, Feb 19, 2016 at 09:45:32AM -0700, Alex Williamson wrote: >On Fri, 19 Feb 2016 15:18:10 +0000 >Wei Yang <richard.weiyang@gmail.com> wrote: > >> Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is >> the more proper on retrieving MSIX entries. >> >> This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries. >> >> Signed-off-by: Wei Yang <richard.weiyang@gmail.com> >> --- >> hw/vfio/pci.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c >> index e66c47f..321423b 100644 >> --- a/hw/vfio/pci.c >> +++ b/hw/vfio/pci.c >> @@ -1210,7 +1210,7 @@ static int vfio_msix_early_setup(VFIOPCIDevice *vdev) >> } >> >> if (pread(fd, &ctrl, sizeof(ctrl), >> - vdev->config_offset + pos + PCI_CAP_FLAGS) != sizeof(ctrl)) { >> + vdev->config_offset + pos + PCI_MSIX_FLAGS) != sizeof(ctrl)) { >> return -errno; >> } >> > >This is certainly trivial, I'll grab it for the respin of yesterday's >pull request. Thanks, Thanks Alex, have a nice weekend :-) > >Alex -- Wei Yang Help you, Help me ^ permalink raw reply [flat|nested] 20+ messages in thread
* [Qemu-trivial] [PATCH 2/2] s390x/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries 2016-02-19 15:18 ` [Qemu-devel] " Wei Yang @ 2016-02-19 15:18 ` Wei Yang -1 siblings, 0 replies; 20+ messages in thread From: Wei Yang @ 2016-02-19 15:18 UTC (permalink / raw) Cc: qemu-trivial, Cornelia Huck, qemu-devel, Christian Borntraeger, Wei Yang Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is the more proper on retrieving MSIX entries. This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries. Signed-off-by: Wei Yang <richard.weiyang@gmail.com> CC: Cornelia Huck <cornelia.huck@de.ibm.com> CC: Christian Borntraeger <borntraeger@de.ibm.com> --- hw/s390x/s390-pci-bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c index 132588b..9d40039 100644 --- a/hw/s390x/s390-pci-bus.c +++ b/hw/s390x/s390-pci-bus.c @@ -523,7 +523,7 @@ static int s390_pcihost_setup_msix(S390PCIBusDevice *pbdev) return 0; } - ctrl = pci_host_config_read_common(pbdev->pdev, pos + PCI_CAP_FLAGS, + ctrl = pci_host_config_read_common(pbdev->pdev, pos + PCI_MSIX_FLAGS, pci_config_size(pbdev->pdev), sizeof(ctrl)); table = pci_host_config_read_common(pbdev->pdev, pos + PCI_MSIX_TABLE, pci_config_size(pbdev->pdev), sizeof(table)); -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [Qemu-devel] [PATCH 2/2] s390x/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries @ 2016-02-19 15:18 ` Wei Yang 0 siblings, 0 replies; 20+ messages in thread From: Wei Yang @ 2016-02-19 15:18 UTC (permalink / raw) Cc: qemu-trivial, Cornelia Huck, qemu-devel, Christian Borntraeger, Wei Yang Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is the more proper on retrieving MSIX entries. This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries. Signed-off-by: Wei Yang <richard.weiyang@gmail.com> CC: Cornelia Huck <cornelia.huck@de.ibm.com> CC: Christian Borntraeger <borntraeger@de.ibm.com> --- hw/s390x/s390-pci-bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c index 132588b..9d40039 100644 --- a/hw/s390x/s390-pci-bus.c +++ b/hw/s390x/s390-pci-bus.c @@ -523,7 +523,7 @@ static int s390_pcihost_setup_msix(S390PCIBusDevice *pbdev) return 0; } - ctrl = pci_host_config_read_common(pbdev->pdev, pos + PCI_CAP_FLAGS, + ctrl = pci_host_config_read_common(pbdev->pdev, pos + PCI_MSIX_FLAGS, pci_config_size(pbdev->pdev), sizeof(ctrl)); table = pci_host_config_read_common(pbdev->pdev, pos + PCI_MSIX_TABLE, pci_config_size(pbdev->pdev), sizeof(table)); -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [Qemu-trivial] [PATCH 2/2] s390x/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries 2016-02-19 15:18 ` [Qemu-devel] " Wei Yang @ 2016-02-22 13:15 ` Christian Borntraeger -1 siblings, 0 replies; 20+ messages in thread From: Christian Borntraeger @ 2016-02-22 13:15 UTC (permalink / raw) To: Wei Yang; +Cc: qemu-trivial, Cornelia Huck, Yi Min Zhao, qemu-devel On 02/19/2016 04:18 PM, Wei Yang wrote: > Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is > the more proper on retrieving MSIX entries. > > This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries. > > Signed-off-by: Wei Yang <richard.weiyang@gmail.com> > CC: Cornelia Huck <cornelia.huck@de.ibm.com> > CC: Christian Borntraeger <borntraeger@de.ibm.com> > --- > hw/s390x/s390-pci-bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c > index 132588b..9d40039 100644 > --- a/hw/s390x/s390-pci-bus.c > +++ b/hw/s390x/s390-pci-bus.c > @@ -523,7 +523,7 @@ static int s390_pcihost_setup_msix(S390PCIBusDevice *pbdev) > return 0; > } > > - ctrl = pci_host_config_read_common(pbdev->pdev, pos + PCI_CAP_FLAGS, > + ctrl = pci_host_config_read_common(pbdev->pdev, pos + PCI_MSIX_FLAGS, > pci_config_size(pbdev->pdev), sizeof(ctrl)); > table = pci_host_config_read_common(pbdev->pdev, pos + PCI_MSIX_TABLE, > pci_config_size(pbdev->pdev), sizeof(table)); > looks sane. Yi Min, can you ack/nack? ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Qemu-devel] [PATCH 2/2] s390x/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries @ 2016-02-22 13:15 ` Christian Borntraeger 0 siblings, 0 replies; 20+ messages in thread From: Christian Borntraeger @ 2016-02-22 13:15 UTC (permalink / raw) To: Wei Yang; +Cc: qemu-trivial, Cornelia Huck, Yi Min Zhao, qemu-devel On 02/19/2016 04:18 PM, Wei Yang wrote: > Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is > the more proper on retrieving MSIX entries. > > This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries. > > Signed-off-by: Wei Yang <richard.weiyang@gmail.com> > CC: Cornelia Huck <cornelia.huck@de.ibm.com> > CC: Christian Borntraeger <borntraeger@de.ibm.com> > --- > hw/s390x/s390-pci-bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c > index 132588b..9d40039 100644 > --- a/hw/s390x/s390-pci-bus.c > +++ b/hw/s390x/s390-pci-bus.c > @@ -523,7 +523,7 @@ static int s390_pcihost_setup_msix(S390PCIBusDevice *pbdev) > return 0; > } > > - ctrl = pci_host_config_read_common(pbdev->pdev, pos + PCI_CAP_FLAGS, > + ctrl = pci_host_config_read_common(pbdev->pdev, pos + PCI_MSIX_FLAGS, > pci_config_size(pbdev->pdev), sizeof(ctrl)); > table = pci_host_config_read_common(pbdev->pdev, pos + PCI_MSIX_TABLE, > pci_config_size(pbdev->pdev), sizeof(table)); > looks sane. Yi Min, can you ack/nack? ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Qemu-trivial] [PATCH 2/2] s390x/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries 2016-02-22 13:15 ` [Qemu-devel] " Christian Borntraeger @ 2016-02-23 6:17 ` Yi Min Zhao -1 siblings, 0 replies; 20+ messages in thread From: Yi Min Zhao @ 2016-02-23 6:17 UTC (permalink / raw) To: Christian Borntraeger; +Cc: qemu-trivial, Cornelia Huck, qemu-devel, Wei Yang 于 Mon, 22 Feb 2016 14:15:07 +0100 Christian Borntraeger <borntraeger@de.ibm.com> 写道: > On 02/19/2016 04:18 PM, Wei Yang wrote: > > Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is > > the more proper on retrieving MSIX entries. > > > > This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries. > > > > Signed-off-by: Wei Yang <richard.weiyang@gmail.com> > > CC: Cornelia Huck <cornelia.huck@de.ibm.com> > > CC: Christian Borntraeger <borntraeger@de.ibm.com> > > --- > > hw/s390x/s390-pci-bus.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c > > index 132588b..9d40039 100644 > > --- a/hw/s390x/s390-pci-bus.c > > +++ b/hw/s390x/s390-pci-bus.c > > @@ -523,7 +523,7 @@ static int s390_pcihost_setup_msix(S390PCIBusDevice *pbdev) > > return 0; > > } > > > > - ctrl = pci_host_config_read_common(pbdev->pdev, pos + PCI_CAP_FLAGS, > > + ctrl = pci_host_config_read_common(pbdev->pdev, pos + PCI_MSIX_FLAGS, > > pci_config_size(pbdev->pdev), sizeof(ctrl)); > > table = pci_host_config_read_common(pbdev->pdev, pos + PCI_MSIX_TABLE, > > pci_config_size(pbdev->pdev), sizeof(table)); > > > > looks sane. > Yi Min, can you ack/nack? > > It looks sane to me. A little change. ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Qemu-devel] [PATCH 2/2] s390x/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries @ 2016-02-23 6:17 ` Yi Min Zhao 0 siblings, 0 replies; 20+ messages in thread From: Yi Min Zhao @ 2016-02-23 6:17 UTC (permalink / raw) To: Christian Borntraeger; +Cc: qemu-trivial, Cornelia Huck, qemu-devel, Wei Yang 于 Mon, 22 Feb 2016 14:15:07 +0100 Christian Borntraeger <borntraeger@de.ibm.com> 写道: > On 02/19/2016 04:18 PM, Wei Yang wrote: > > Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is > > the more proper on retrieving MSIX entries. > > > > This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries. > > > > Signed-off-by: Wei Yang <richard.weiyang@gmail.com> > > CC: Cornelia Huck <cornelia.huck@de.ibm.com> > > CC: Christian Borntraeger <borntraeger@de.ibm.com> > > --- > > hw/s390x/s390-pci-bus.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c > > index 132588b..9d40039 100644 > > --- a/hw/s390x/s390-pci-bus.c > > +++ b/hw/s390x/s390-pci-bus.c > > @@ -523,7 +523,7 @@ static int s390_pcihost_setup_msix(S390PCIBusDevice *pbdev) > > return 0; > > } > > > > - ctrl = pci_host_config_read_common(pbdev->pdev, pos + PCI_CAP_FLAGS, > > + ctrl = pci_host_config_read_common(pbdev->pdev, pos + PCI_MSIX_FLAGS, > > pci_config_size(pbdev->pdev), sizeof(ctrl)); > > table = pci_host_config_read_common(pbdev->pdev, pos + PCI_MSIX_TABLE, > > pci_config_size(pbdev->pdev), sizeof(table)); > > > > looks sane. > Yi Min, can you ack/nack? > > It looks sane to me. A little change. ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Qemu-trivial] [PATCH 2/2] s390x/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries 2016-02-23 6:17 ` [Qemu-devel] " Yi Min Zhao @ 2016-02-23 22:24 ` Wei Yang -1 siblings, 0 replies; 20+ messages in thread From: Wei Yang @ 2016-02-23 22:24 UTC (permalink / raw) To: Yi Min Zhao Cc: qemu-trivial, Christian Borntraeger, Cornelia Huck, qemu-devel, Wei Yang On Tue, Feb 23, 2016 at 02:17:11PM +0800, Yi Min Zhao wrote: >于 Mon, 22 Feb 2016 14:15:07 +0100 >Christian Borntraeger <borntraeger@de.ibm.com> 写道: > >> On 02/19/2016 04:18 PM, Wei Yang wrote: >> > Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is >> > the more proper on retrieving MSIX entries. >> > >> > This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries. >> > >> > Signed-off-by: Wei Yang <richard.weiyang@gmail.com> >> > CC: Cornelia Huck <cornelia.huck@de.ibm.com> >> > CC: Christian Borntraeger <borntraeger@de.ibm.com> >> > --- >> > hw/s390x/s390-pci-bus.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c >> > index 132588b..9d40039 100644 >> > --- a/hw/s390x/s390-pci-bus.c >> > +++ b/hw/s390x/s390-pci-bus.c >> > @@ -523,7 +523,7 @@ static int s390_pcihost_setup_msix(S390PCIBusDevice *pbdev) >> > return 0; >> > } >> > >> > - ctrl = pci_host_config_read_common(pbdev->pdev, pos + PCI_CAP_FLAGS, >> > + ctrl = pci_host_config_read_common(pbdev->pdev, pos + PCI_MSIX_FLAGS, >> > pci_config_size(pbdev->pdev), sizeof(ctrl)); >> > table = pci_host_config_read_common(pbdev->pdev, pos + PCI_MSIX_TABLE, >> > pci_config_size(pbdev->pdev), sizeof(table)); >> > >> >> looks sane. >> Yi Min, can you ack/nack? >> >> > >It looks sane to me. A little change. Thanks Yi Min and Christian. So someone would pick it up? -- Wei Yang Help you, Help me ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Qemu-devel] [PATCH 2/2] s390x/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries @ 2016-02-23 22:24 ` Wei Yang 0 siblings, 0 replies; 20+ messages in thread From: Wei Yang @ 2016-02-23 22:24 UTC (permalink / raw) To: Yi Min Zhao Cc: qemu-trivial, Christian Borntraeger, Cornelia Huck, qemu-devel, Wei Yang On Tue, Feb 23, 2016 at 02:17:11PM +0800, Yi Min Zhao wrote: >于 Mon, 22 Feb 2016 14:15:07 +0100 >Christian Borntraeger <borntraeger@de.ibm.com> 写道: > >> On 02/19/2016 04:18 PM, Wei Yang wrote: >> > Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is >> > the more proper on retrieving MSIX entries. >> > >> > This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries. >> > >> > Signed-off-by: Wei Yang <richard.weiyang@gmail.com> >> > CC: Cornelia Huck <cornelia.huck@de.ibm.com> >> > CC: Christian Borntraeger <borntraeger@de.ibm.com> >> > --- >> > hw/s390x/s390-pci-bus.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c >> > index 132588b..9d40039 100644 >> > --- a/hw/s390x/s390-pci-bus.c >> > +++ b/hw/s390x/s390-pci-bus.c >> > @@ -523,7 +523,7 @@ static int s390_pcihost_setup_msix(S390PCIBusDevice *pbdev) >> > return 0; >> > } >> > >> > - ctrl = pci_host_config_read_common(pbdev->pdev, pos + PCI_CAP_FLAGS, >> > + ctrl = pci_host_config_read_common(pbdev->pdev, pos + PCI_MSIX_FLAGS, >> > pci_config_size(pbdev->pdev), sizeof(ctrl)); >> > table = pci_host_config_read_common(pbdev->pdev, pos + PCI_MSIX_TABLE, >> > pci_config_size(pbdev->pdev), sizeof(table)); >> > >> >> looks sane. >> Yi Min, can you ack/nack? >> >> > >It looks sane to me. A little change. Thanks Yi Min and Christian. So someone would pick it up? -- Wei Yang Help you, Help me ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Qemu-trivial] [PATCH 2/2] s390x/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries 2016-02-19 15:18 ` [Qemu-devel] " Wei Yang @ 2016-02-24 9:40 ` Cornelia Huck -1 siblings, 0 replies; 20+ messages in thread From: Cornelia Huck @ 2016-02-24 9:40 UTC (permalink / raw) To: Wei Yang; +Cc: qemu-trivial, Christian Borntraeger, qemu-devel On Fri, 19 Feb 2016 15:18:11 +0000 Wei Yang <richard.weiyang@gmail.com> wrote: > Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is > the more proper on retrieving MSIX entries. > > This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries. > > Signed-off-by: Wei Yang <richard.weiyang@gmail.com> > CC: Cornelia Huck <cornelia.huck@de.ibm.com> > CC: Christian Borntraeger <borntraeger@de.ibm.com> > --- > hw/s390x/s390-pci-bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to s390-next. ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Qemu-devel] [PATCH 2/2] s390x/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries @ 2016-02-24 9:40 ` Cornelia Huck 0 siblings, 0 replies; 20+ messages in thread From: Cornelia Huck @ 2016-02-24 9:40 UTC (permalink / raw) To: Wei Yang; +Cc: qemu-trivial, Christian Borntraeger, qemu-devel On Fri, 19 Feb 2016 15:18:11 +0000 Wei Yang <richard.weiyang@gmail.com> wrote: > Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is > the more proper on retrieving MSIX entries. > > This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries. > > Signed-off-by: Wei Yang <richard.weiyang@gmail.com> > CC: Cornelia Huck <cornelia.huck@de.ibm.com> > CC: Christian Borntraeger <borntraeger@de.ibm.com> > --- > hw/s390x/s390-pci-bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to s390-next. ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Qemu-trivial] [PATCH 2/2] s390x/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries 2016-02-24 9:40 ` [Qemu-devel] " Cornelia Huck @ 2016-02-24 14:29 ` Wei Yang -1 siblings, 0 replies; 20+ messages in thread From: Wei Yang @ 2016-02-24 14:29 UTC (permalink / raw) To: Cornelia Huck; +Cc: qemu-trivial, Christian Borntraeger, qemu-devel, Wei Yang On Wed, Feb 24, 2016 at 10:40:15AM +0100, Cornelia Huck wrote: >On Fri, 19 Feb 2016 15:18:11 +0000 >Wei Yang <richard.weiyang@gmail.com> wrote: > >> Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is >> the more proper on retrieving MSIX entries. >> >> This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries. >> >> Signed-off-by: Wei Yang <richard.weiyang@gmail.com> >> CC: Cornelia Huck <cornelia.huck@de.ibm.com> >> CC: Christian Borntraeger <borntraeger@de.ibm.com> >> --- >> hw/s390x/s390-pci-bus.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > >Thanks, applied to s390-next. Thanks :-) -- Wei Yang Help you, Help me ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Qemu-devel] [PATCH 2/2] s390x/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries @ 2016-02-24 14:29 ` Wei Yang 0 siblings, 0 replies; 20+ messages in thread From: Wei Yang @ 2016-02-24 14:29 UTC (permalink / raw) To: Cornelia Huck; +Cc: qemu-trivial, Christian Borntraeger, qemu-devel, Wei Yang On Wed, Feb 24, 2016 at 10:40:15AM +0100, Cornelia Huck wrote: >On Fri, 19 Feb 2016 15:18:11 +0000 >Wei Yang <richard.weiyang@gmail.com> wrote: > >> Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is >> the more proper on retrieving MSIX entries. >> >> This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries. >> >> Signed-off-by: Wei Yang <richard.weiyang@gmail.com> >> CC: Cornelia Huck <cornelia.huck@de.ibm.com> >> CC: Christian Borntraeger <borntraeger@de.ibm.com> >> --- >> hw/s390x/s390-pci-bus.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > >Thanks, applied to s390-next. Thanks :-) -- Wei Yang Help you, Help me ^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2016-02-24 14:29 UTC | newest] Thread overview: 20+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-02-19 15:18 [Qemu-trivial] [PATCH 0/2] use PCI_MSIX_FLAGS on retrieving the MSIX entries Wei Yang 2016-02-19 15:18 ` [Qemu-devel] " Wei Yang 2016-02-19 15:18 ` [Qemu-trivial] [PATCH 1/2] vfio/pci: " Wei Yang 2016-02-19 15:18 ` [Qemu-devel] " Wei Yang 2016-02-19 16:45 ` [Qemu-trivial] " Alex Williamson 2016-02-19 16:45 ` Alex Williamson 2016-02-19 23:38 ` [Qemu-trivial] " Wei Yang 2016-02-19 23:38 ` Wei Yang 2016-02-19 15:18 ` [Qemu-trivial] [PATCH 2/2] s390x/pci: " Wei Yang 2016-02-19 15:18 ` [Qemu-devel] " Wei Yang 2016-02-22 13:15 ` [Qemu-trivial] " Christian Borntraeger 2016-02-22 13:15 ` [Qemu-devel] " Christian Borntraeger 2016-02-23 6:17 ` [Qemu-trivial] " Yi Min Zhao 2016-02-23 6:17 ` [Qemu-devel] " Yi Min Zhao 2016-02-23 22:24 ` [Qemu-trivial] " Wei Yang 2016-02-23 22:24 ` [Qemu-devel] " Wei Yang 2016-02-24 9:40 ` [Qemu-trivial] " Cornelia Huck 2016-02-24 9:40 ` [Qemu-devel] " Cornelia Huck 2016-02-24 14:29 ` [Qemu-trivial] " Wei Yang 2016-02-24 14:29 ` [Qemu-devel] " Wei Yang
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.