* [PATCH] xsm: correct operation test in flask_sysctl_scheduler_op()
@ 2016-02-23 7:35 Juergen Gross
2016-02-23 9:29 ` Jan Beulich
[not found] ` <56CC347B02000078000D514E@suse.com>
0 siblings, 2 replies; 3+ messages in thread
From: Juergen Gross @ 2016-02-23 7:35 UTC (permalink / raw)
To: xen-devel; +Cc: Juergen Gross, dgdegra
In flask_sysctl_scheduler_op() the test for the desired operation is
done with the wrong constants. While the values are correct, the names
are not. Correct the error message for the case of an unknown
operation, too.
Signed-off-by: Juergen Gross <jgross@suse.com>
---
xen/xsm/flask/hooks.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
index f63c3e2..4813623 100644
--- a/xen/xsm/flask/hooks.c
+++ b/xen/xsm/flask/hooks.c
@@ -529,14 +529,14 @@ static int flask_sysctl_scheduler_op(int op)
{
switch ( op )
{
- case XEN_DOMCTL_SCHEDOP_putinfo:
+ case XEN_SYSCTL_SCHEDOP_putinfo:
return domain_has_xen(current->domain, XEN__SETSCHEDULER);
- case XEN_DOMCTL_SCHEDOP_getinfo:
+ case XEN_SYSCTL_SCHEDOP_getinfo:
return domain_has_xen(current->domain, XEN__GETSCHEDULER);
default:
- printk("flask_domctl_scheduler_op: Unknown op %d\n", op);
+ printk("flask_sysctl_scheduler_op: Unknown op %d\n", op);
return -EPERM;
}
}
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] xsm: correct operation test in flask_sysctl_scheduler_op()
2016-02-23 7:35 [PATCH] xsm: correct operation test in flask_sysctl_scheduler_op() Juergen Gross
@ 2016-02-23 9:29 ` Jan Beulich
[not found] ` <56CC347B02000078000D514E@suse.com>
1 sibling, 0 replies; 3+ messages in thread
From: Jan Beulich @ 2016-02-23 9:29 UTC (permalink / raw)
To: Juergen Gross; +Cc: dgdegra, xen-devel
>>> On 23.02.16 at 08:35, <JGross@suse.com> wrote:
> In flask_sysctl_scheduler_op() the test for the desired operation is
> done with the wrong constants. While the values are correct, the names
> are not. Correct the error message for the case of an unknown
> operation, too.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
Would you mind fixing this everywhere, not just in XSM code? At
least sched_adjust_global() appears to have the same issue.
Jan
^ permalink raw reply [flat|nested] 3+ messages in thread[parent not found: <56CC347B02000078000D514E@suse.com>]
* Re: [PATCH] xsm: correct operation test in flask_sysctl_scheduler_op()
[not found] ` <56CC347B02000078000D514E@suse.com>
@ 2016-02-23 9:55 ` Juergen Gross
0 siblings, 0 replies; 3+ messages in thread
From: Juergen Gross @ 2016-02-23 9:55 UTC (permalink / raw)
To: Jan Beulich; +Cc: dgdegra, xen-devel
On 23/02/16 10:29, Jan Beulich wrote:
>>>> On 23.02.16 at 08:35, <JGross@suse.com> wrote:
>> In flask_sysctl_scheduler_op() the test for the desired operation is
>> done with the wrong constants. While the values are correct, the names
>> are not. Correct the error message for the case of an unknown
>> operation, too.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>
> Would you mind fixing this everywhere, not just in XSM code? At
> least sched_adjust_global() appears to have the same issue.
Aah, okay. Yes, I can do it.
Juergen
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-23 9:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-23 7:35 [PATCH] xsm: correct operation test in flask_sysctl_scheduler_op() Juergen Gross
2016-02-23 9:29 ` Jan Beulich
[not found] ` <56CC347B02000078000D514E@suse.com>
2016-02-23 9:55 ` Juergen Gross
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.