From: dinguyen@opensource.altera.com (Dinh Nguyen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: socfpga: hide unused functions
Date: Tue, 23 Feb 2016 09:22:47 -0600 [thread overview]
Message-ID: <56CC7947.6000909@opensource.altera.com> (raw)
In-Reply-To: <1456236527-189885-1-git-send-email-arnd@arndb.de>
On 02/23/2016 08:08 AM, Arnd Bergmann wrote:
> The cpu_die and cpu_kill callbacks are only used when CONFIG_HOTPLUG_CPU
> is enabled, otherwise we get a warning about them:
>
> arch/arm/mach-socfpga/platsmp.c:102:13: error: 'socfpga_cpu_die' defined but not used [-Werror=unused-function]
> arch/arm/mach-socfpga/platsmp.c:115:12: error: 'socfpga_cpu_kill' defined but not used [-Werror=unused-function]
>
> This adds the appropriate #ifdef.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/arm/mach-socfpga/platsmp.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-socfpga/platsmp.c b/arch/arm/mach-socfpga/platsmp.c
> index cbb0a54df80a..07945748b571 100644
> --- a/arch/arm/mach-socfpga/platsmp.c
> +++ b/arch/arm/mach-socfpga/platsmp.c
> @@ -94,6 +94,7 @@ static void __init socfpga_smp_prepare_cpus(unsigned int max_cpus)
> scu_enable(socfpga_scu_base_addr);
> }
>
> +#ifdef CONFIG_HOTPLUG_CPU
> /*
> * platform-specific code to shutdown a CPU
> *
> @@ -116,6 +117,7 @@ static int socfpga_cpu_kill(unsigned int cpu)
> {
> return 1;
> }
> +#endif
>
> static const struct smp_operations socfpga_smp_ops __initconst = {
> .smp_prepare_cpus = socfpga_smp_prepare_cpus,
>
Acked-by: Dinh Nguyen <dinguyen@opensource.altera.com>
Dinh
WARNING: multiple messages have this Message-ID (diff)
From: Dinh Nguyen <dinguyen@opensource.altera.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: socfpga: hide unused functions
Date: Tue, 23 Feb 2016 09:22:47 -0600 [thread overview]
Message-ID: <56CC7947.6000909@opensource.altera.com> (raw)
In-Reply-To: <1456236527-189885-1-git-send-email-arnd@arndb.de>
On 02/23/2016 08:08 AM, Arnd Bergmann wrote:
> The cpu_die and cpu_kill callbacks are only used when CONFIG_HOTPLUG_CPU
> is enabled, otherwise we get a warning about them:
>
> arch/arm/mach-socfpga/platsmp.c:102:13: error: 'socfpga_cpu_die' defined but not used [-Werror=unused-function]
> arch/arm/mach-socfpga/platsmp.c:115:12: error: 'socfpga_cpu_kill' defined but not used [-Werror=unused-function]
>
> This adds the appropriate #ifdef.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/arm/mach-socfpga/platsmp.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-socfpga/platsmp.c b/arch/arm/mach-socfpga/platsmp.c
> index cbb0a54df80a..07945748b571 100644
> --- a/arch/arm/mach-socfpga/platsmp.c
> +++ b/arch/arm/mach-socfpga/platsmp.c
> @@ -94,6 +94,7 @@ static void __init socfpga_smp_prepare_cpus(unsigned int max_cpus)
> scu_enable(socfpga_scu_base_addr);
> }
>
> +#ifdef CONFIG_HOTPLUG_CPU
> /*
> * platform-specific code to shutdown a CPU
> *
> @@ -116,6 +117,7 @@ static int socfpga_cpu_kill(unsigned int cpu)
> {
> return 1;
> }
> +#endif
>
> static const struct smp_operations socfpga_smp_ops __initconst = {
> .smp_prepare_cpus = socfpga_smp_prepare_cpus,
>
Acked-by: Dinh Nguyen <dinguyen@opensource.altera.com>
Dinh
next prev parent reply other threads:[~2016-02-23 15:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 14:08 [PATCH] ARM: socfpga: hide unused functions Arnd Bergmann
2016-02-23 14:08 ` Arnd Bergmann
2016-02-23 15:22 ` Dinh Nguyen [this message]
2016-02-23 15:22 ` Dinh Nguyen
2016-02-26 16:45 ` Arnd Bergmann
2016-02-26 16:45 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CC7947.6000909@opensource.altera.com \
--to=dinguyen@opensource.altera.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.