Re: [RFC] [autobuilder] Autobuilder.py: add verbose buildset parse error

[Alex Franco <alejandro.franco@linux.intel.com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Not sure this how this should be done, but at least it's been helpful in
my case

Alex Franco

On 02/23/2016 09:42 AM, Alex Franco wrote:
> From: Alejandro Franco <alejandro.franco@linux.intel.com>
>
> Add a more verbose Exception when a buildset parse operation fails
>
> Signed-off-by: Alejandro Franco <alejandro.franco@linux.intel.com>
> ---
>  lib/python2.7/site-packages/autobuilder/Autobuilder.py | 15
+++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/lib/python2.7/site-packages/autobuilder/Autobuilder.py
b/lib/python2.7/site-packages/autobuilder/Autobuilder.py
> index 3174784..f200974 100644
> --- a/lib/python2.7/site-packages/autobuilder/Autobuilder.py
> +++ b/lib/python2.7/site-packages/autobuilder/Autobuilder.py
> @@ -118,12 +118,15 @@ class Autobuilder:
>      def parseRepos(self, buildset=None):
>          buildset=buildset
>          if self.configdict[buildset].has_key('repos'):
> -            for layer in
ast.literal_eval(self.configdict[buildset]['repos']):
> -                if layer.iterkeys().next() not in self.repos:
> -                    schedpropstoextend, newcheckoutprops =
self.CreateLayerSchedulerParams(layer=layer, trigger=buildset,
triggerer=True)
> -                    self.schedprops.extend(schedpropstoextend)
> -                    self.checkoutprops.update(newcheckoutprops)
> -                    self.repos.append(layer.iterkeys().next())
> +            try:
> +                for layer in
ast.literal_eval(self.configdict[buildset]['repos']):
> +                    if layer.iterkeys().next() not in self.repos:
> +                        schedpropstoextend, newcheckoutprops =
self.CreateLayerSchedulerParams(layer=layer, trigger=buildset,
triggerer=True)
> +                        self.schedprops.extend(schedpropstoextend)
> +                        self.checkoutprops.update(newcheckoutprops)
> +                        self.repos.append(layer.iterkeys().next())
> +            except SyntaxError as err:
> +                raise ABConfigError("%s found in %s" % (err, buildset))
>          return
> 
>      def parseProps(self, buildset):

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBAgAGBQJWzH5AAAoJEPR9uwMY2lTLg1MH/1WoSCFXJ768TR5yGvWM5vd1
2VdHTuMRD2FlvvblbFLIrOwsYd9TU5UccijLKYcu0K1k9CiQVjDRB4D7c/uzCLQv
E/ndOerRo1FkZyat2vEONfVInJTzycM2auY3j41jz1Pr4uyNhnJphgVzC/Kinf/F
PswyAYYnnV6ytTXFLBx4dSX5AIO0qXmoX9pmEP5W+FfmkjBQlqrbAScomyNSamhf
SGpC9520wUo7tke/2qLz5PgVkZ8LGR7ZlW6qEErZY462bW/cLWWpnP77c6ll3wiX
huC4iQtSTwJ0ZKl1NWHz0N9Fs8f9ky41VOxaD3EAjdroqMlKnfd8LkDfo6g2cm4=
=9eQK
-----END PGP SIGNATURE-----