* [RFC] [autobuilder] Autobuilder.py: add verbose buildset parse error
@ 2016-02-23 15:42 Alex Franco
2016-02-23 15:44 ` Alex Franco
2016-02-23 17:20 ` Flanagan, Elizabeth
0 siblings, 2 replies; 3+ messages in thread
From: Alex Franco @ 2016-02-23 15:42 UTC (permalink / raw)
To: yocto
From: Alejandro Franco <alejandro.franco@linux.intel.com>
Add a more verbose Exception when a buildset parse operation fails
Signed-off-by: Alejandro Franco <alejandro.franco@linux.intel.com>
---
lib/python2.7/site-packages/autobuilder/Autobuilder.py | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/lib/python2.7/site-packages/autobuilder/Autobuilder.py b/lib/python2.7/site-packages/autobuilder/Autobuilder.py
index 3174784..f200974 100644
--- a/lib/python2.7/site-packages/autobuilder/Autobuilder.py
+++ b/lib/python2.7/site-packages/autobuilder/Autobuilder.py
@@ -118,12 +118,15 @@ class Autobuilder:
def parseRepos(self, buildset=None):
buildset=buildset
if self.configdict[buildset].has_key('repos'):
- for layer in ast.literal_eval(self.configdict[buildset]['repos']):
- if layer.iterkeys().next() not in self.repos:
- schedpropstoextend, newcheckoutprops = self.CreateLayerSchedulerParams(layer=layer, trigger=buildset, triggerer=True)
- self.schedprops.extend(schedpropstoextend)
- self.checkoutprops.update(newcheckoutprops)
- self.repos.append(layer.iterkeys().next())
+ try:
+ for layer in ast.literal_eval(self.configdict[buildset]['repos']):
+ if layer.iterkeys().next() not in self.repos:
+ schedpropstoextend, newcheckoutprops = self.CreateLayerSchedulerParams(layer=layer, trigger=buildset, triggerer=True)
+ self.schedprops.extend(schedpropstoextend)
+ self.checkoutprops.update(newcheckoutprops)
+ self.repos.append(layer.iterkeys().next())
+ except SyntaxError as err:
+ raise ABConfigError("%s found in %s" % (err, buildset))
return
def parseProps(self, buildset):
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [RFC] [autobuilder] Autobuilder.py: add verbose buildset parse error
2016-02-23 15:42 [RFC] [autobuilder] Autobuilder.py: add verbose buildset parse error Alex Franco
@ 2016-02-23 15:44 ` Alex Franco
2016-02-23 17:20 ` Flanagan, Elizabeth
1 sibling, 0 replies; 3+ messages in thread
From: Alex Franco @ 2016-02-23 15:44 UTC (permalink / raw)
To: yocto
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Not sure this how this should be done, but at least it's been helpful in
my case
Alex Franco
On 02/23/2016 09:42 AM, Alex Franco wrote:
> From: Alejandro Franco <alejandro.franco@linux.intel.com>
>
> Add a more verbose Exception when a buildset parse operation fails
>
> Signed-off-by: Alejandro Franco <alejandro.franco@linux.intel.com>
> ---
> lib/python2.7/site-packages/autobuilder/Autobuilder.py | 15
+++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/lib/python2.7/site-packages/autobuilder/Autobuilder.py
b/lib/python2.7/site-packages/autobuilder/Autobuilder.py
> index 3174784..f200974 100644
> --- a/lib/python2.7/site-packages/autobuilder/Autobuilder.py
> +++ b/lib/python2.7/site-packages/autobuilder/Autobuilder.py
> @@ -118,12 +118,15 @@ class Autobuilder:
> def parseRepos(self, buildset=None):
> buildset=buildset
> if self.configdict[buildset].has_key('repos'):
> - for layer in
ast.literal_eval(self.configdict[buildset]['repos']):
> - if layer.iterkeys().next() not in self.repos:
> - schedpropstoextend, newcheckoutprops =
self.CreateLayerSchedulerParams(layer=layer, trigger=buildset,
triggerer=True)
> - self.schedprops.extend(schedpropstoextend)
> - self.checkoutprops.update(newcheckoutprops)
> - self.repos.append(layer.iterkeys().next())
> + try:
> + for layer in
ast.literal_eval(self.configdict[buildset]['repos']):
> + if layer.iterkeys().next() not in self.repos:
> + schedpropstoextend, newcheckoutprops =
self.CreateLayerSchedulerParams(layer=layer, trigger=buildset,
triggerer=True)
> + self.schedprops.extend(schedpropstoextend)
> + self.checkoutprops.update(newcheckoutprops)
> + self.repos.append(layer.iterkeys().next())
> + except SyntaxError as err:
> + raise ABConfigError("%s found in %s" % (err, buildset))
> return
>
> def parseProps(self, buildset):
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBAgAGBQJWzH5AAAoJEPR9uwMY2lTLg1MH/1WoSCFXJ768TR5yGvWM5vd1
2VdHTuMRD2FlvvblbFLIrOwsYd9TU5UccijLKYcu0K1k9CiQVjDRB4D7c/uzCLQv
E/ndOerRo1FkZyat2vEONfVInJTzycM2auY3j41jz1Pr4uyNhnJphgVzC/Kinf/F
PswyAYYnnV6ytTXFLBx4dSX5AIO0qXmoX9pmEP5W+FfmkjBQlqrbAScomyNSamhf
SGpC9520wUo7tke/2qLz5PgVkZ8LGR7ZlW6qEErZY462bW/cLWWpnP77c6ll3wiX
huC4iQtSTwJ0ZKl1NWHz0N9Fs8f9ky41VOxaD3EAjdroqMlKnfd8LkDfo6g2cm4=
=9eQK
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [RFC] [autobuilder] Autobuilder.py: add verbose buildset parse error
2016-02-23 15:42 [RFC] [autobuilder] Autobuilder.py: add verbose buildset parse error Alex Franco
2016-02-23 15:44 ` Alex Franco
@ 2016-02-23 17:20 ` Flanagan, Elizabeth
1 sibling, 0 replies; 3+ messages in thread
From: Flanagan, Elizabeth @ 2016-02-23 17:20 UTC (permalink / raw)
To: Alex Franco; +Cc: yocto@yoctoproject.org
On 23 February 2016 at 15:42, Alex Franco
<alejandro.franco@linux.intel.com> wrote:
> From: Alejandro Franco <alejandro.franco@linux.intel.com>
>
> Add a more verbose Exception when a buildset parse operation fails
>
Approved and in master.
-b
> Signed-off-by: Alejandro Franco <alejandro.franco@linux.intel.com>
> ---
> lib/python2.7/site-packages/autobuilder/Autobuilder.py | 15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/lib/python2.7/site-packages/autobuilder/Autobuilder.py b/lib/python2.7/site-packages/autobuilder/Autobuilder.py
> index 3174784..f200974 100644
> --- a/lib/python2.7/site-packages/autobuilder/Autobuilder.py
> +++ b/lib/python2.7/site-packages/autobuilder/Autobuilder.py
> @@ -118,12 +118,15 @@ class Autobuilder:
> def parseRepos(self, buildset=None):
> buildset=buildset
> if self.configdict[buildset].has_key('repos'):
> - for layer in ast.literal_eval(self.configdict[buildset]['repos']):
> - if layer.iterkeys().next() not in self.repos:
> - schedpropstoextend, newcheckoutprops = self.CreateLayerSchedulerParams(layer=layer, trigger=buildset, triggerer=True)
> - self.schedprops.extend(schedpropstoextend)
> - self.checkoutprops.update(newcheckoutprops)
> - self.repos.append(layer.iterkeys().next())
> + try:
> + for layer in ast.literal_eval(self.configdict[buildset]['repos']):
> + if layer.iterkeys().next() not in self.repos:
> + schedpropstoextend, newcheckoutprops = self.CreateLayerSchedulerParams(layer=layer, trigger=buildset, triggerer=True)
> + self.schedprops.extend(schedpropstoextend)
> + self.checkoutprops.update(newcheckoutprops)
> + self.repos.append(layer.iterkeys().next())
> + except SyntaxError as err:
> + raise ABConfigError("%s found in %s" % (err, buildset))
> return
>
> def parseProps(self, buildset):
> --
> 1.9.1
>
--
Elizabeth Flanagan
Yocto Project
Build and Release
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-23 17:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-23 15:42 [RFC] [autobuilder] Autobuilder.py: add verbose buildset parse error Alex Franco
2016-02-23 15:44 ` Alex Franco
2016-02-23 17:20 ` Flanagan, Elizabeth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.