From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: "pankaj.dubey" <pankaj.dubey@samsung.com>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: kgene.kim@samsung.com, b.zolnierkie@samsung.com,
daniel.lezcano@linaro.org, thomas.ab@samsung.com,
linux@arm.linux.org.uk
Subject: Re: [PATCH 2/3] ARM: EXYNOS: remove unused register offset definition
Date: Wed, 24 Feb 2016 08:47:16 +0900 [thread overview]
Message-ID: <56CCEF84.6090502@samsung.com> (raw)
In-Reply-To: <56CC2238.2040303@samsung.com>
On 23.02.2016 18:11, pankaj.dubey wrote:
> Hi Krzysztof,
>
> On Tuesday 23 February 2016 05:33 AM, Krzysztof Kozlowski wrote:
>> On 22.02.2016 19:03, Pankaj Dubey wrote:
>>> This patch cleans up map.h by removing unused register offset
>>> and changing EXYNOS4 to EXYNOS in header comment section.
>>>
>>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>>> ---
>>> arch/arm/mach-exynos/include/mach/map.h | 9 +--------
>>> 1 file changed, 1 insertion(+), 8 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-exynos/include/mach/map.h
>>> index 351e839..c48ba4f 100644
>>> --- a/arch/arm/mach-exynos/include/mach/map.h
>>> +++ b/arch/arm/mach-exynos/include/mach/map.h
>>> @@ -2,7 +2,7 @@
>>> * Copyright (c) 2010-2011 Samsung Electronics Co., Ltd.
>>> * http://www.samsung.com/
>>> *
>>> - * EXYNOS4 - Memory map definitions
>>> + * EXYNOS - Memory map definitions
>>> *
>>> * This program is free software; you can redistribute it and/or modify
>>> * it under the terms of the GNU General Public License version 2 as
>>> @@ -14,12 +14,6 @@
>>>
>>> #include <plat/map-base.h>
>>>
>>> -/*
>>> - * EXYNOS4 UART offset is 0x10000 but the older S5P SoCs are 0x400.
>>> - * So need to define it, and here is to avoid redefinition warning.
>>> - */
>>> -#define S3C_UART_OFFSET (0x10000)
>>> -
>>> #include <plat/map-s5p.h>
>>
>> This does not look good. The S3C_UART_OFFSET is used in plat/map-s5p.h.
>>
>
> Actually it's just defined there but not getting used anywhere. In fact
> we can remove it from there also.
The point is that your patch introduce changes. Before S3C_UART_OFFSET
was defined to 0x10000, after (because of #ifndef) it will be 0x400.
Description of "unused" is not accurate. Unused stuff does not impact
anything.
> So I submitted another patch to
> cleanup such redundant register definitions from plat/map-s5p.h.
That would be good.
> Only platform using S3C_UART_OFFSET is s3c64xx and its using definition
> from map-s3c.h. I have compiled all related platform defconfigs and
> found no issues because of removal of S3C_UART_OFFSET from map-s5p.c and
> map.h.
The compilation is not a test. You compiled something like this:
-#define S3C_UART_OFFSET (0x10000)
#ifndef S3C_UART_OFFSET
#define S3C_UART_OFFSET (0x400)
#endif
... and found no errors. Of course there are no compilation errors! But
the value has changed!
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: EXYNOS: remove unused register offset definition
Date: Wed, 24 Feb 2016 08:47:16 +0900 [thread overview]
Message-ID: <56CCEF84.6090502@samsung.com> (raw)
In-Reply-To: <56CC2238.2040303@samsung.com>
On 23.02.2016 18:11, pankaj.dubey wrote:
> Hi Krzysztof,
>
> On Tuesday 23 February 2016 05:33 AM, Krzysztof Kozlowski wrote:
>> On 22.02.2016 19:03, Pankaj Dubey wrote:
>>> This patch cleans up map.h by removing unused register offset
>>> and changing EXYNOS4 to EXYNOS in header comment section.
>>>
>>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>>> ---
>>> arch/arm/mach-exynos/include/mach/map.h | 9 +--------
>>> 1 file changed, 1 insertion(+), 8 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-exynos/include/mach/map.h
>>> index 351e839..c48ba4f 100644
>>> --- a/arch/arm/mach-exynos/include/mach/map.h
>>> +++ b/arch/arm/mach-exynos/include/mach/map.h
>>> @@ -2,7 +2,7 @@
>>> * Copyright (c) 2010-2011 Samsung Electronics Co., Ltd.
>>> * http://www.samsung.com/
>>> *
>>> - * EXYNOS4 - Memory map definitions
>>> + * EXYNOS - Memory map definitions
>>> *
>>> * This program is free software; you can redistribute it and/or modify
>>> * it under the terms of the GNU General Public License version 2 as
>>> @@ -14,12 +14,6 @@
>>>
>>> #include <plat/map-base.h>
>>>
>>> -/*
>>> - * EXYNOS4 UART offset is 0x10000 but the older S5P SoCs are 0x400.
>>> - * So need to define it, and here is to avoid redefinition warning.
>>> - */
>>> -#define S3C_UART_OFFSET (0x10000)
>>> -
>>> #include <plat/map-s5p.h>
>>
>> This does not look good. The S3C_UART_OFFSET is used in plat/map-s5p.h.
>>
>
> Actually it's just defined there but not getting used anywhere. In fact
> we can remove it from there also.
The point is that your patch introduce changes. Before S3C_UART_OFFSET
was defined to 0x10000, after (because of #ifndef) it will be 0x400.
Description of "unused" is not accurate. Unused stuff does not impact
anything.
> So I submitted another patch to
> cleanup such redundant register definitions from plat/map-s5p.h.
That would be good.
> Only platform using S3C_UART_OFFSET is s3c64xx and its using definition
> from map-s3c.h. I have compiled all related platform defconfigs and
> found no issues because of removal of S3C_UART_OFFSET from map-s5p.c and
> map.h.
The compilation is not a test. You compiled something like this:
-#define S3C_UART_OFFSET (0x10000)
#ifndef S3C_UART_OFFSET
#define S3C_UART_OFFSET (0x400)
#endif
... and found no errors. Of course there are no compilation errors! But
the value has changed!
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-02-23 23:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 10:03 [PATCH 0/3] ARM: EXYNOS: Trivial cleanup in mach-exynos Pankaj Dubey
2016-02-22 10:03 ` Pankaj Dubey
2016-02-22 10:03 ` [PATCH 1/3] ARM: EXYNOS: correct header comment in Kconfig file Pankaj Dubey
2016-02-22 10:03 ` Pankaj Dubey
2016-02-23 0:01 ` Krzysztof Kozlowski
2016-02-23 0:01 ` Krzysztof Kozlowski
2016-02-22 10:03 ` [PATCH 2/3] ARM: EXYNOS: remove unused register offset definition Pankaj Dubey
2016-02-22 10:03 ` Pankaj Dubey
2016-02-23 0:03 ` Krzysztof Kozlowski
2016-02-23 0:03 ` Krzysztof Kozlowski
2016-02-23 9:11 ` pankaj.dubey
2016-02-23 9:11 ` pankaj.dubey
2016-02-23 23:47 ` Krzysztof Kozlowski [this message]
2016-02-23 23:47 ` Krzysztof Kozlowski
2016-02-24 8:23 ` pankaj.dubey
2016-02-24 8:23 ` pankaj.dubey
2016-02-24 9:14 ` Krzysztof Kozlowski
2016-02-24 9:14 ` Krzysztof Kozlowski
2016-02-22 10:03 ` [PATCH 3/3] ARM: EXYNOS: cleanup header files inclusion Pankaj Dubey
2016-02-22 10:03 ` Pankaj Dubey
2016-02-23 0:09 ` Krzysztof Kozlowski
2016-02-23 0:09 ` Krzysztof Kozlowski
2016-02-23 9:17 ` pankaj.dubey
2016-02-23 9:17 ` pankaj.dubey
2016-02-24 1:02 ` Krzysztof Kozlowski
2016-02-24 1:02 ` Krzysztof Kozlowski
2016-02-24 4:01 ` pankaj.dubey
2016-02-24 4:01 ` pankaj.dubey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CCEF84.6090502@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.lezcano@linaro.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pankaj.dubey@samsung.com \
--cc=thomas.ab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.