From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH] topology.h: cleanup
Date: Wed, 24 Feb 2016 10:10:56 +0800 [thread overview]
Message-ID: <56CD1130.50301@cn.fujitsu.com> (raw)
In-Reply-To: <20160223211614.GE3901@thinpad.lan.raisama.net>
On 02/24/2016 05:16 AM, Eduardo Habkost wrote:
> On Tue, Feb 23, 2016 at 02:51:11PM +0800, Cao jin wrote:
>> remove useless parameter of several functions
>>
>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
>
> I believe this makes the API much easier to be misused. Currently
> you can safely use (smp_cores, smp_threads) every time. With this
> patch, you need to always check the function definition to find
> out what's the correct argument.
>
Yes, you do have a point here, and very interesting to me. A caller need
to know/check how to use a api if it want to use it, seems a nature
thing to me.
Thanks for your explanation.
--
Yours Sincerely,
Cao jin
prev parent reply other threads:[~2016-02-24 2:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 6:51 [Qemu-devel] [PATCH] topology.h: cleanup Cao jin
2016-02-23 21:16 ` Eduardo Habkost
2016-02-24 2:10 ` Cao jin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CD1130.50301@cn.fujitsu.com \
--to=caoj.fnst@cn.fujitsu.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.