From: Doug Goldstein <cardoe@cardoe.com>
To: Jan Beulich <JBeulich@suse.com>, Feng Wu <feng.wu@intel.com>
Cc: Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>,
George Dunlap <george.dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Dario Faggioli <dario.faggioli@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v13 1/2] vmx: VT-d posted-interrupt core logic handling
Date: Tue, 23 Feb 2016 21:01:45 -0600 [thread overview]
Message-ID: <56CD1D19.1020505@cardoe.com> (raw)
In-Reply-To: <56CC980E02000078000D551B@prv-mh.provo.novell.com>
[-- Attachment #1.1: Type: text/plain, Size: 1050 bytes --]
On 2/23/16 10:34 AM, Jan Beulich wrote:
>>>> On 23.02.16 at 09:34, <feng.wu@intel.com> wrote:
>
>> --- a/xen/include/asm-x86/hvm/hvm.h
>> +++ b/xen/include/asm-x86/hvm/hvm.h
>> @@ -565,6 +565,12 @@ const char *hvm_efer_valid(const struct vcpu *v,
>> uint64_t value,
>> signed int cr0_pg);
>> unsigned long hvm_cr4_guest_reserved_bits(const struct vcpu *v, bool_t
>> restore);
>>
>> +#define arch_vcpu_block(v) ({ \
>> + void (*func) (struct vcpu *) = (v)->domain->arch.hvm_domain.vmx.vcpu_block;\
>> + if ( func ) \
>> + func(v); \
>> +})
>
> See my comment on v12. The code structure actually was better
> there, and all you needed to do is introduce a local variable.
Wouldn't this be a bit cleaner (and type-safier (inventing a word here))
to do with a static inline function?
--
Doug Goldstein
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-02-24 3:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 8:34 [PATCH v13 0/2] Add VT-d Posted-Interrupts support Feng Wu
2016-02-23 8:34 ` [PATCH v13 1/2] vmx: VT-d posted-interrupt core logic handling Feng Wu
2016-02-23 11:06 ` George Dunlap
2016-02-24 1:01 ` Wu, Feng
2016-02-23 16:34 ` Jan Beulich
2016-02-24 1:32 ` Wu, Feng
2016-02-24 9:05 ` Jan Beulich
2016-02-24 3:01 ` Doug Goldstein [this message]
2016-02-24 3:09 ` Wu, Feng
2016-02-24 12:09 ` George Dunlap
2016-02-24 12:49 ` Jan Beulich
2016-02-26 1:30 ` Wu, Feng
2016-02-26 8:28 ` Jan Beulich
2016-02-26 9:06 ` Wu, Feng
2016-02-25 2:46 ` Wu, Feng
2016-02-23 8:34 ` [PATCH v13 2/2] Add a command line parameter for VT-d posted-interrupts Feng Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CD1D19.1020505@cardoe.com \
--to=cardoe@cardoe.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=feng.wu@intel.com \
--cc=george.dunlap@eu.citrix.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.