All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jyri Sarha <jsarha@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>, dri-devel@lists.freedesktop.org
Cc: laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH v3 22/22] drm/tilcdc: Use devm_kzalloc() and devm_kcalloc() for private data
Date: Wed, 24 Feb 2016 14:48:44 +0200	[thread overview]
Message-ID: <56CDA6AC.1040401@ti.com> (raw)
In-Reply-To: <56CDA437.3060706@ti.com>

On 02/24/16 14:38, Tomi Valkeinen wrote:
>
> On 23/02/16 17:03, Jyri Sarha wrote:
>> Use devm_kzalloc() and devm_kcalloc() for private data allocation at
>> driver load time.
>>
>> Signed-off-by: Jyri Sarha <jsarha@ti.com>
>> ---
>>   drivers/gpu/drm/tilcdc/tilcdc_crtc.c   |  4 +---
>>   drivers/gpu/drm/tilcdc/tilcdc_drv.c    | 19 +++++++------------
>>   drivers/gpu/drm/tilcdc/tilcdc_panel.c  | 20 ++++++--------------
>>   drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 24 +++++++-----------------
>>   4 files changed, 21 insertions(+), 46 deletions(-)
>
> I see you took one step further and used devm_alloc for the crtcs and
> encoders etc too =). I don't see why that wouldn't work, though, as they
> are all created at init time and freed when the driver exits.
>
> However, at least omapdrm does handle freeing in the specific _destroy
> callbacks, so I do wonder if there's some reason for that...
>

The same is more or less true also for the driver load() and unload(), 
functions that you originally commented in the "drm/tilcdc: Allocate 
register storage based on the actual number registers".

> Did you test with tilcdc as module, with all the kernel debug options
> enabled, and a few load/unload module cycles?
>

I did couple of load and unload cycles, but not sure about the options. 
I'll do that again, this time with all the debug options I can think of 
active.

Best regards,
Jyri





_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2016-02-24 13:44 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-23 15:03 [PATCH v3 00/22] drm/ticdc: Accumulated fixes over the past couple of years Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 01/22] drm/tilcdc: rewrite pixel clock calculation Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 02/22] drm/tilcdc: verify fb pitch Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 03/22] drm/tilcdc: adopt pinctrl support Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 04/22] drm/tilcdc: fix kernel panic on suspend when no hdmi monitor connected Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 05/22] drm/tilcdc: make frame_done interrupt active at all times Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 06/22] drm/tilcdc: disable the lcd controller/dma engine when suspend invoked Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 07/22] drm/tilcdc: Implement dma-buf support for tilcdc Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 08/22] drm/tilcdc: fix build error when !CONFIG_CPU_FREQ Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 09/22] drm/tilcdc: Allocate register storage based on the actual number registers Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 10/22] drm/tilcdc: cleanup runtime PM handling Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 11/22] drm/tilcdc: disable crtc on unload Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 12/22] drm/tilcdc: split reset to a separate function Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 13/22] drm/tilcdc: remove broken error handling Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 14/22] drm/tilcdc: cleanup irq handling Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 15/22] drm/tilcdc: Get rid of complex ping-pong mechanism Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 16/22] drm/tilcdc: Do not update the next frame buffer close to vertical blank Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 17/22] drm/tilcdc: Fix interrupt enable/disable code for version 2 tilcdc Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 18/22] drm/tilcdc: Remove the duplicate LCDC_INT_ENABLE_SET_REG in registers[] Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 19/22] drm/tilcdc: Add prints on sync lost and FIFO underrun interrupts Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 20/22] drm/tilcdc: Disable sync lost interrupt if it fires on every frame Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 21/22] drm/tilcdc: Initialize crtc->port Jyri Sarha
2016-02-23 15:19   ` Tomi Valkeinen
2016-02-23 15:26     ` Jyri Sarha
2016-02-23 15:32       ` Tomi Valkeinen
2016-02-23 15:37         ` Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 22/22] drm/tilcdc: Use devm_kzalloc() and devm_kcalloc() for private data Jyri Sarha
2016-02-24 12:38   ` Tomi Valkeinen
2016-02-24 12:48     ` Jyri Sarha [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56CDA6AC.1040401@ti.com \
    --to=jsarha@ti.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.