All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Jyri Sarha <jsarha@ti.com>, dri-devel@lists.freedesktop.org
Cc: laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH v3 21/22] drm/tilcdc: Initialize crtc->port
Date: Tue, 23 Feb 2016 17:32:48 +0200	[thread overview]
Message-ID: <56CC7BA0.9060507@ti.com> (raw)
In-Reply-To: <56CC7A09.40709@ti.com>


[-- Attachment #1.1: Type: text/plain, Size: 865 bytes --]

On 23/02/16 17:26, Jyri Sarha wrote:

>> You didn't comment on why this is not an error? Why should the driver
>> continue even if crtc->port is missing?
>>
> 
> At least for the time being if the drm_of_find_possible_crtcs() fails
> the tda998x driver assumes the first crtc with a warning. So for that
> part everything will work just fine still.
> 
> Then it is another question how priv->is_componentized could be set and
> probing has gotten this far while there is no port node to be found. The
> WARN_ON() should really never happen as long as the code is the way it
> currently is.

Ok. But I think it's either ok to not have crtc->port, and in that case
no print is needed, or it's not ok, and it's better to print an error
and fail.

Now it's kind of vague: the driver continues without crtc->port, but
gives a scary WARN.

 Tomi


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-02-23 15:32 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-23 15:03 [PATCH v3 00/22] drm/ticdc: Accumulated fixes over the past couple of years Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 01/22] drm/tilcdc: rewrite pixel clock calculation Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 02/22] drm/tilcdc: verify fb pitch Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 03/22] drm/tilcdc: adopt pinctrl support Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 04/22] drm/tilcdc: fix kernel panic on suspend when no hdmi monitor connected Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 05/22] drm/tilcdc: make frame_done interrupt active at all times Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 06/22] drm/tilcdc: disable the lcd controller/dma engine when suspend invoked Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 07/22] drm/tilcdc: Implement dma-buf support for tilcdc Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 08/22] drm/tilcdc: fix build error when !CONFIG_CPU_FREQ Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 09/22] drm/tilcdc: Allocate register storage based on the actual number registers Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 10/22] drm/tilcdc: cleanup runtime PM handling Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 11/22] drm/tilcdc: disable crtc on unload Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 12/22] drm/tilcdc: split reset to a separate function Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 13/22] drm/tilcdc: remove broken error handling Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 14/22] drm/tilcdc: cleanup irq handling Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 15/22] drm/tilcdc: Get rid of complex ping-pong mechanism Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 16/22] drm/tilcdc: Do not update the next frame buffer close to vertical blank Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 17/22] drm/tilcdc: Fix interrupt enable/disable code for version 2 tilcdc Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 18/22] drm/tilcdc: Remove the duplicate LCDC_INT_ENABLE_SET_REG in registers[] Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 19/22] drm/tilcdc: Add prints on sync lost and FIFO underrun interrupts Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 20/22] drm/tilcdc: Disable sync lost interrupt if it fires on every frame Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 21/22] drm/tilcdc: Initialize crtc->port Jyri Sarha
2016-02-23 15:19   ` Tomi Valkeinen
2016-02-23 15:26     ` Jyri Sarha
2016-02-23 15:32       ` Tomi Valkeinen [this message]
2016-02-23 15:37         ` Jyri Sarha
2016-02-23 15:03 ` [PATCH v3 22/22] drm/tilcdc: Use devm_kzalloc() and devm_kcalloc() for private data Jyri Sarha
2016-02-24 12:38   ` Tomi Valkeinen
2016-02-24 12:48     ` Jyri Sarha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56CC7BA0.9060507@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jsarha@ti.com \
    --cc=laurent.pinchart@ideasonboard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.