All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] watchdog: Add hardware dependency to BCM7038 driver
@ 2016-02-24 15:17 Jean Delvare
  2016-02-24 15:30 ` Guenter Roeck
  2016-03-04 19:37 ` Wim Van Sebroeck
  0 siblings, 2 replies; 4+ messages in thread
From: Jean Delvare @ 2016-02-24 15:17 UTC (permalink / raw)
  To: linux-watchdog; +Cc: Guenter Roeck, Justin Chen, Wim Van Sebroeck

The BCM7038 watchdog driver is specific to Broadcom ARM and MIPS
SoCs so do not present it on other architectures, unless
build-testing.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Justin Chen <justinpopo6@gmail.com>
Cc: Wim Van Sebroeck <wim@iguana.be>
---
Changes since v1:
 * Better dependencies, suggested by Justin, and updated the
   description accordingly.
 * Better option description, provided by Justin.

 drivers/watchdog/Kconfig |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

--- linux-4.5-rc5.orig/drivers/watchdog/Kconfig	2016-02-24 14:43:18.943460233 +0100
+++ linux-4.5-rc5/drivers/watchdog/Kconfig	2016-02-24 15:42:49.756057691 +0100
@@ -1377,10 +1377,12 @@ config BCM7038_WDT
 	tristate "BCM7038 Watchdog"
 	select WATCHDOG_CORE
 	depends on HAS_IOMEM
+	depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
 	help
-	 Watchdog driver for the built-in hardware in Broadcom 7038 SoCs.
-
-	 Say 'Y or 'M' here to enable the driver.
+	 Watchdog driver for the built-in hardware in Broadcom 7038 and
+	 later SoCs used in set-top boxes.  BCM7038 was made public
+	 during the 2004 CES, and since then, many Broadcom chips use this
+	 watchdog block, including some cable modem chips.
 
 config IMGPDC_WDT
 	tristate "Imagination Technologies PDC Watchdog Timer"

-- 
Jean Delvare
SUSE L3 Support

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] watchdog: Add hardware dependency to BCM7038 driver
  2016-02-24 15:17 [PATCH v2] watchdog: Add hardware dependency to BCM7038 driver Jean Delvare
@ 2016-02-24 15:30 ` Guenter Roeck
  2016-02-24 17:08   ` Justin Chen
  2016-03-04 19:37 ` Wim Van Sebroeck
  1 sibling, 1 reply; 4+ messages in thread
From: Guenter Roeck @ 2016-02-24 15:30 UTC (permalink / raw)
  To: Jean Delvare, linux-watchdog; +Cc: Justin Chen, Wim Van Sebroeck

On 02/24/2016 07:17 AM, Jean Delvare wrote:
> The BCM7038 watchdog driver is specific to Broadcom ARM and MIPS
> SoCs so do not present it on other architectures, unless
> build-testing.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Justin Chen <justinpopo6@gmail.com>
> Cc: Wim Van Sebroeck <wim@iguana.be>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> Changes since v1:
>   * Better dependencies, suggested by Justin, and updated the
>     description accordingly.
>   * Better option description, provided by Justin.
>
>   drivers/watchdog/Kconfig |    8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
>
> --- linux-4.5-rc5.orig/drivers/watchdog/Kconfig	2016-02-24 14:43:18.943460233 +0100
> +++ linux-4.5-rc5/drivers/watchdog/Kconfig	2016-02-24 15:42:49.756057691 +0100
> @@ -1377,10 +1377,12 @@ config BCM7038_WDT
>   	tristate "BCM7038 Watchdog"
>   	select WATCHDOG_CORE
>   	depends on HAS_IOMEM
> +	depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
>   	help
> -	 Watchdog driver for the built-in hardware in Broadcom 7038 SoCs.
> -
> -	 Say 'Y or 'M' here to enable the driver.
> +	 Watchdog driver for the built-in hardware in Broadcom 7038 and
> +	 later SoCs used in set-top boxes.  BCM7038 was made public
> +	 during the 2004 CES, and since then, many Broadcom chips use this
> +	 watchdog block, including some cable modem chips.
>
>   config IMGPDC_WDT
>   	tristate "Imagination Technologies PDC Watchdog Timer"
>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] watchdog: Add hardware dependency to BCM7038 driver
  2016-02-24 15:30 ` Guenter Roeck
@ 2016-02-24 17:08   ` Justin Chen
  0 siblings, 0 replies; 4+ messages in thread
From: Justin Chen @ 2016-02-24 17:08 UTC (permalink / raw)
  To: Guenter Roeck; +Cc: Jean Delvare, linux-watchdog, Wim Van Sebroeck

On Wed, Feb 24, 2016 at 7:30 AM, Guenter Roeck <linux@roeck-us.net> wrote:
> On 02/24/2016 07:17 AM, Jean Delvare wrote:
>>
>> The BCM7038 watchdog driver is specific to Broadcom ARM and MIPS
>> SoCs so do not present it on other architectures, unless
>> build-testing.
>>
>> Signed-off-by: Jean Delvare <jdelvare@suse.de>
>> Cc: Guenter Roeck <linux@roeck-us.net>
>> Cc: Justin Chen <justinpopo6@gmail.com>
>> Cc: Wim Van Sebroeck <wim@iguana.be>
>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Justin Chen <justinpopo6@gmail.com>
>
>
>> ---
>> Changes since v1:
>>   * Better dependencies, suggested by Justin, and updated the
>>     description accordingly.
>>   * Better option description, provided by Justin.
>>
>>   drivers/watchdog/Kconfig |    8 +++++---
>>   1 file changed, 5 insertions(+), 3 deletions(-)
>>
>> --- linux-4.5-rc5.orig/drivers/watchdog/Kconfig 2016-02-24
>> 14:43:18.943460233 +0100
>> +++ linux-4.5-rc5/drivers/watchdog/Kconfig      2016-02-24
>> 15:42:49.756057691 +0100
>> @@ -1377,10 +1377,12 @@ config BCM7038_WDT
>>         tristate "BCM7038 Watchdog"
>>         select WATCHDOG_CORE
>>         depends on HAS_IOMEM
>> +       depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
>>         help
>> -        Watchdog driver for the built-in hardware in Broadcom 7038 SoCs.
>> -
>> -        Say 'Y or 'M' here to enable the driver.
>> +        Watchdog driver for the built-in hardware in Broadcom 7038 and
>> +        later SoCs used in set-top boxes.  BCM7038 was made public
>> +        during the 2004 CES, and since then, many Broadcom chips use this
>> +        watchdog block, including some cable modem chips.
>>
>>   config IMGPDC_WDT
>>         tristate "Imagination Technologies PDC Watchdog Timer"
>>
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] watchdog: Add hardware dependency to BCM7038 driver
  2016-02-24 15:17 [PATCH v2] watchdog: Add hardware dependency to BCM7038 driver Jean Delvare
  2016-02-24 15:30 ` Guenter Roeck
@ 2016-03-04 19:37 ` Wim Van Sebroeck
  1 sibling, 0 replies; 4+ messages in thread
From: Wim Van Sebroeck @ 2016-03-04 19:37 UTC (permalink / raw)
  To: Jean Delvare; +Cc: linux-watchdog, Guenter Roeck, Justin Chen

Hi Jean,

> The BCM7038 watchdog driver is specific to Broadcom ARM and MIPS
> SoCs so do not present it on other architectures, unless
> build-testing.
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Justin Chen <justinpopo6@gmail.com>
> Cc: Wim Van Sebroeck <wim@iguana.be>
> ---
> Changes since v1:
>  * Better dependencies, suggested by Justin, and updated the
>    description accordingly.
>  * Better option description, provided by Justin.
> 
>  drivers/watchdog/Kconfig |    8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> --- linux-4.5-rc5.orig/drivers/watchdog/Kconfig	2016-02-24 14:43:18.943460233 +0100
> +++ linux-4.5-rc5/drivers/watchdog/Kconfig	2016-02-24 15:42:49.756057691 +0100
> @@ -1377,10 +1377,12 @@ config BCM7038_WDT
>  	tristate "BCM7038 Watchdog"
>  	select WATCHDOG_CORE
>  	depends on HAS_IOMEM
> +	depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
>  	help
> -	 Watchdog driver for the built-in hardware in Broadcom 7038 SoCs.
> -
> -	 Say 'Y or 'M' here to enable the driver.
> +	 Watchdog driver for the built-in hardware in Broadcom 7038 and
> +	 later SoCs used in set-top boxes.  BCM7038 was made public
> +	 during the 2004 CES, and since then, many Broadcom chips use this
> +	 watchdog block, including some cable modem chips.
>  
>  config IMGPDC_WDT
>  	tristate "Imagination Technologies PDC Watchdog Timer"
> 
> -- 
> Jean Delvare
> SUSE L3 Support

Patch has been added to linux-watchdog-next.

Kind regards,
Wim.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-03-04 19:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-24 15:17 [PATCH v2] watchdog: Add hardware dependency to BCM7038 driver Jean Delvare
2016-02-24 15:30 ` Guenter Roeck
2016-02-24 17:08   ` Justin Chen
2016-03-04 19:37 ` Wim Van Sebroeck

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.