All of lore.kernel.org
 help / color / mirror / Atom feed
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] clocksource: atmel-pit: register as a sched_clock
Date: Wed, 24 Feb 2016 18:13:08 +0100	[thread overview]
Message-ID: <56CDE4A4.7080508@atmel.com> (raw)
In-Reply-To: <CAGkQfmPpyhU025nt+tcnsjWK3V+K3_7oiXxeqa7mPuHT08sLig@mail.gmail.com>

Le 24/02/2016 17:44, Romain Izard a ?crit :
> 2016-02-24 17:20 GMT+01:00 Sylvain Rochet <sylvain.rochet@finsecur.com>:
>> Hi,
>>
>> On Wed, Feb 24, 2016 at 05:04:42PM +0100, Romain Izard wrote:
>>> Register the counter of the Periodic Interval Timer as a possible
>>> source for sched_clock. Keep the timer running even if the related
>>> clockevent is disabled.
>>>
>>> This provides a better precision than the jiffies-based default. The
>>> TCB clocksource does not work, as it is registered too late in the
>>> initialization sequence.
>>
>> I have mixed feelings about that, but this is probably just a
>> misunderstanding from my part.
>>
> My goal is to get a better precision on my printk and trace logs,
> because the precision of jiffies is really very bad compared to
> everything else I have encountered until now. But it looks like reading
> a timer is quite complicated on AT91...
> 
>> The PIT timer should not be used for systems with PM_SUSPEND enabled
>> and used because it takes ages to synchronize on resume, how does this
>> patch affect that ?
>>
>> Ref: commit ac34ad27fc ("clockevents: Do not suspend/resume if
>> unused")
> 
> So your advice would be to stay clear of the PIT, because it is
> (globally) useless.
> 
> I'll keep it in mind.

I tend to think like this as well.

I would like to simplify our timer handling on AT91 and stick with TC
for this purpose.
It has de disadvantage of being obliged to use a TC(block) for
clockevent/clocksource and loose it if we want to do something else with
it but I do think that it's worth it.

If you want a modified TC driver that registers sched_clock, we can
provide you one as a workaround before that we rework the TC driver
completely. It has it's own flaws (like re-using a compatible string or
preventing the use of the "tclib") but is certainly handy.

Bye,
-- 
Nicolas Ferre

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Romain Izard <romain.izard.pro@gmail.com>,
	Sylvain Rochet <sylvain.rochet@finsecur.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Boris Brezillon <boris.brezillon@free-electrons.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Cyrille Pitchen <cyrille.pitchen@atmel.com>
Subject: Re: [PATCH v2] clocksource: atmel-pit: register as a sched_clock
Date: Wed, 24 Feb 2016 18:13:08 +0100	[thread overview]
Message-ID: <56CDE4A4.7080508@atmel.com> (raw)
In-Reply-To: <CAGkQfmPpyhU025nt+tcnsjWK3V+K3_7oiXxeqa7mPuHT08sLig@mail.gmail.com>

Le 24/02/2016 17:44, Romain Izard a écrit :
> 2016-02-24 17:20 GMT+01:00 Sylvain Rochet <sylvain.rochet@finsecur.com>:
>> Hi,
>>
>> On Wed, Feb 24, 2016 at 05:04:42PM +0100, Romain Izard wrote:
>>> Register the counter of the Periodic Interval Timer as a possible
>>> source for sched_clock. Keep the timer running even if the related
>>> clockevent is disabled.
>>>
>>> This provides a better precision than the jiffies-based default. The
>>> TCB clocksource does not work, as it is registered too late in the
>>> initialization sequence.
>>
>> I have mixed feelings about that, but this is probably just a
>> misunderstanding from my part.
>>
> My goal is to get a better precision on my printk and trace logs,
> because the precision of jiffies is really very bad compared to
> everything else I have encountered until now. But it looks like reading
> a timer is quite complicated on AT91...
> 
>> The PIT timer should not be used for systems with PM_SUSPEND enabled
>> and used because it takes ages to synchronize on resume, how does this
>> patch affect that ?
>>
>> Ref: commit ac34ad27fc ("clockevents: Do not suspend/resume if
>> unused")
> 
> So your advice would be to stay clear of the PIT, because it is
> (globally) useless.
> 
> I'll keep it in mind.

I tend to think like this as well.

I would like to simplify our timer handling on AT91 and stick with TC
for this purpose.
It has de disadvantage of being obliged to use a TC(block) for
clockevent/clocksource and loose it if we want to do something else with
it but I do think that it's worth it.

If you want a modified TC driver that registers sched_clock, we can
provide you one as a workaround before that we rework the TC driver
completely. It has it's own flaws (like re-using a compatible string or
preventing the use of the "tclib") but is certainly handy.

Bye,
-- 
Nicolas Ferre

  reply	other threads:[~2016-02-24 17:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-24 16:04 [PATCH v2] clocksource: atmel-pit: register as a sched_clock Romain Izard
2016-02-24 16:04 ` Romain Izard
2016-02-24 16:15 ` Alexandre Belloni
2016-02-24 16:15   ` Alexandre Belloni
2016-02-24 16:20 ` Sylvain Rochet
2016-02-24 16:20   ` Sylvain Rochet
2016-02-24 16:44   ` Romain Izard
2016-02-24 16:44     ` Romain Izard
2016-02-24 17:13     ` Nicolas Ferre [this message]
2016-02-24 17:13       ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56CDE4A4.7080508@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.