From: xuejiancheng <xuejiancheng@huawei.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: <mturquette@baylibre.com>, <p.zabel@pengutronix.de>,
<robh+dt@kernel.org>, <pawel.moll@arm.com>,
<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
<galak@codeaurora.org>, <linux@arm.linux.org.uk>,
<khilman@linaro.org>, <arnd@arndb.de>, <olof@lixom.net>,
<xuwei5@hisilicon.com>, <haojian.zhuang@linaro.org>,
<zhangfei.gao@linaro.org>, <bintian.wang@huawei.com>,
<linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<yanhaifeng@hisilicon.com>, <yanghongwei@hisilicon.com>,
<suwenping@hisilicon.com>, <raojun@hisilicon.com>,
<ml.yang@hisilicon.com>, <gaofei@hisilicon.com>,
<zhangzhenxing@hisilicon.com>, <xuejiancheng@hisilicon.com>,
<lidongpo@hisilicon.com>
Subject: Re: [PATCH v9 2/6] clk: hisilicon: add CRG driver for hi3519 soc
Date: Fri, 26 Feb 2016 10:17:51 +0800 [thread overview]
Message-ID: <56CFB5CF.2050800@huawei.com> (raw)
In-Reply-To: <20160225234215.GK28849@codeaurora.org>
Hi Stephen,
On 2016/2/26 7:42, Stephen Boyd wrote:
>> diff --git a/drivers/clk/hisilicon/reset.c b/drivers/clk/hisilicon/reset.c
>> new file mode 100644
>> index 0000000..50e00e7
>> --- /dev/null
>> +++ b/drivers/clk/hisilicon/reset.c
>> +
>> +int hisi_reset_init(struct device_node *np)
>> +{
>> + struct hisi_reset_controller *rstc;
>> +
>> + rstc = kzalloc(sizeof(*rstc), GFP_KERNEL);
>> + if (!rstc)
>> + return -ENOMEM;
>> +
>> + rstc->membase = of_iomap(np, 0);
>
> Any reason why we can't pass the platform device here and map the
> register space with platform device APIs?
>
This function can be called by other clock drivers except clk-hi3519. Some
clock drivers may not be registered as platform drivers. Moreover this function
may be called early even before platform_bus_init.
Thank you!
Regards,
Jiancheng.
WARNING: multiple messages have this Message-ID (diff)
From: xuejiancheng@huawei.com (xuejiancheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 2/6] clk: hisilicon: add CRG driver for hi3519 soc
Date: Fri, 26 Feb 2016 10:17:51 +0800 [thread overview]
Message-ID: <56CFB5CF.2050800@huawei.com> (raw)
In-Reply-To: <20160225234215.GK28849@codeaurora.org>
Hi Stephen,
On 2016/2/26 7:42, Stephen Boyd wrote:
>> diff --git a/drivers/clk/hisilicon/reset.c b/drivers/clk/hisilicon/reset.c
>> new file mode 100644
>> index 0000000..50e00e7
>> --- /dev/null
>> +++ b/drivers/clk/hisilicon/reset.c
>> +
>> +int hisi_reset_init(struct device_node *np)
>> +{
>> + struct hisi_reset_controller *rstc;
>> +
>> + rstc = kzalloc(sizeof(*rstc), GFP_KERNEL);
>> + if (!rstc)
>> + return -ENOMEM;
>> +
>> + rstc->membase = of_iomap(np, 0);
>
> Any reason why we can't pass the platform device here and map the
> register space with platform device APIs?
>
This function can be called by other clock drivers except clk-hi3519. Some
clock drivers may not be registered as platform drivers. Moreover this function
may be called early even before platform_bus_init.
Thank you!
Regards,
Jiancheng.
WARNING: multiple messages have this Message-ID (diff)
From: xuejiancheng <xuejiancheng@huawei.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: mturquette@baylibre.com, p.zabel@pengutronix.de,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux@arm.linux.org.uk, khilman@linaro.org, arnd@arndb.de,
olof@lixom.net, xuwei5@hisilicon.com, haojian.zhuang@linaro.org,
zhangfei.gao@linaro.org, bintian.wang@huawei.com,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
yanhaifeng@hisilicon.com, yanghongwei@hisilicon.com,
suwenping@hisilicon.com, raojun@hisilicon.com,
ml.yang@hisilicon.com, gaofei@hisilicon.com,
zhangzhenxing@hisilicon.com, xuejiancheng@hisilicon.com,
lidongpo@hisilicon.com
Subject: Re: [PATCH v9 2/6] clk: hisilicon: add CRG driver for hi3519 soc
Date: Fri, 26 Feb 2016 10:17:51 +0800 [thread overview]
Message-ID: <56CFB5CF.2050800@huawei.com> (raw)
In-Reply-To: <20160225234215.GK28849@codeaurora.org>
Hi Stephen,
On 2016/2/26 7:42, Stephen Boyd wrote:
>> diff --git a/drivers/clk/hisilicon/reset.c b/drivers/clk/hisilicon/reset.c
>> new file mode 100644
>> index 0000000..50e00e7
>> --- /dev/null
>> +++ b/drivers/clk/hisilicon/reset.c
>> +
>> +int hisi_reset_init(struct device_node *np)
>> +{
>> + struct hisi_reset_controller *rstc;
>> +
>> + rstc = kzalloc(sizeof(*rstc), GFP_KERNEL);
>> + if (!rstc)
>> + return -ENOMEM;
>> +
>> + rstc->membase = of_iomap(np, 0);
>
> Any reason why we can't pass the platform device here and map the
> register space with platform device APIs?
>
This function can be called by other clock drivers except clk-hi3519. Some
clock drivers may not be registered as platform drivers. Moreover this function
may be called early even before platform_bus_init.
Thank you!
Regards,
Jiancheng.
next prev parent reply other threads:[~2016-02-26 2:17 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 7:47 [PATCH v9 0/6] ARM: hisi: Add initial support including clock driver for Hi3519 soc Jiancheng Xue
2016-02-22 7:47 ` Jiancheng Xue
2016-02-22 7:47 ` Jiancheng Xue
2016-02-22 7:47 ` [PATCH v9 1/6] clk: hisilicon: export some hisilicon APIs to modules Jiancheng Xue
2016-02-22 7:47 ` Jiancheng Xue
2016-02-22 7:47 ` Jiancheng Xue
2016-02-25 23:42 ` Stephen Boyd
2016-02-25 23:42 ` Stephen Boyd
2016-02-22 7:47 ` [PATCH v9 2/6] clk: hisilicon: add CRG driver for hi3519 soc Jiancheng Xue
2016-02-22 7:47 ` Jiancheng Xue
2016-02-22 7:47 ` Jiancheng Xue
2016-02-22 10:01 ` kbuild test robot
2016-02-22 10:01 ` kbuild test robot
2016-02-22 10:01 ` kbuild test robot
2016-02-23 1:25 ` xuejiancheng
2016-02-23 1:25 ` xuejiancheng
2016-02-23 1:25 ` xuejiancheng
2016-02-23 9:14 ` Philipp Zabel
2016-02-23 9:14 ` Philipp Zabel
2016-02-25 23:42 ` Stephen Boyd
2016-02-25 23:42 ` Stephen Boyd
2016-02-26 1:54 ` xuejiancheng
2016-02-26 1:54 ` xuejiancheng
2016-02-26 1:54 ` xuejiancheng
2016-02-26 2:17 ` xuejiancheng [this message]
2016-02-26 2:17 ` xuejiancheng
2016-02-26 2:17 ` xuejiancheng
2016-02-22 7:47 ` [PATCH v9 3/6] ARM: hisi: add compatible string for Hi3519 soc Jiancheng Xue
2016-02-22 7:47 ` Jiancheng Xue
2016-02-22 7:47 ` Jiancheng Xue
2016-02-22 7:47 ` [PATCH v9 4/6] ARM: debug: add hi3519 debug uart Jiancheng Xue
2016-02-22 7:47 ` Jiancheng Xue
2016-02-22 7:47 ` Jiancheng Xue
2016-02-22 7:47 ` [PATCH v9 5/6] ARM: dt-bindings: add device tree bindings for Hi3519 sysctrl Jiancheng Xue
2016-02-22 7:47 ` Jiancheng Xue
2016-02-22 7:47 ` Jiancheng Xue
2016-02-22 7:48 ` [PATCH v9 6/6] ARM: dts: add dts files for Hi3519 Jiancheng Xue
2016-02-22 7:48 ` Jiancheng Xue
2016-02-22 7:48 ` Jiancheng Xue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CFB5CF.2050800@huawei.com \
--to=xuejiancheng@huawei.com \
--cc=arnd@arndb.de \
--cc=bintian.wang@huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gaofei@hisilicon.com \
--cc=haojian.zhuang@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=khilman@linaro.org \
--cc=lidongpo@hisilicon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=ml.yang@hisilicon.com \
--cc=mturquette@baylibre.com \
--cc=olof@lixom.net \
--cc=p.zabel@pengutronix.de \
--cc=pawel.moll@arm.com \
--cc=raojun@hisilicon.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=suwenping@hisilicon.com \
--cc=xuejiancheng@hisilicon.com \
--cc=xuwei5@hisilicon.com \
--cc=yanghongwei@hisilicon.com \
--cc=yanhaifeng@hisilicon.com \
--cc=zhangfei.gao@linaro.org \
--cc=zhangzhenxing@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.