[PATCH] xen.inc: fix ordering of stubs task

[PATCH] xen.inc: fix ordering of stubs task

[Chris Patterson]

Placing the stubs function between patch and configure steps
breaks because it has dependencies which are not guranteed
until the configure step.

Build error:
"fatal error: gnu/stubs-32.h: No such file or directory"

This patch simply moves the step between configure and compile
to resolve the dependency issue.

Reported-by: Machon Gregory <mbgrego@tycho.nsa.gov>
Signed-off-by: Chris Patterson <cjp256@gmail.com>
---
 recipes-extended/xen/xen.inc |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-extended/xen/xen.inc b/recipes-extended/xen/xen.inc
index 5555ed3..d35bc3f 100644
--- a/recipes-extended/xen/xen.inc
+++ b/recipes-extended/xen/xen.inc
@@ -782,7 +782,7 @@ do_stubs() {
     fi
 }
 
-addtask stubs after do_patch before do_configure
+addtask stubs after do_configure before do_compile
 
 do_configure() {
 
-- 
1.7.10.4

Re: [PATCH] xen.inc: fix ordering of stubs task

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 1347 bytes --]

merged.

Bruce

On Fri, Feb 12, 2016 at 10:34 AM, Chris Patterson <cjp256@gmail.com> wrote:

> Placing the stubs function between patch and configure steps
> breaks because it has dependencies which are not guranteed
> until the configure step.
>
> Build error:
> "fatal error: gnu/stubs-32.h: No such file or directory"
>
> This patch simply moves the step between configure and compile
> to resolve the dependency issue.
>
> Reported-by: Machon Gregory <mbgrego@tycho.nsa.gov>
> Signed-off-by: Chris Patterson <cjp256@gmail.com>
> ---
>  recipes-extended/xen/xen.inc |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-extended/xen/xen.inc b/recipes-extended/xen/xen.inc
> index 5555ed3..d35bc3f 100644
> --- a/recipes-extended/xen/xen.inc
> +++ b/recipes-extended/xen/xen.inc
> @@ -782,7 +782,7 @@ do_stubs() {
>      fi
>  }
>
> -addtask stubs after do_patch before do_configure
> +addtask stubs after do_configure before do_compile
>
>  do_configure() {
>
> --
> 1.7.10.4
>
> --
> _______________________________________________
> meta-virtualization mailing list
> meta-virtualization@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-virtualization
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"

[-- Attachment #2: Type: text/html, Size: 2140 bytes --]

Re: [PATCH] xen.inc: fix ordering of stubs task

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 1896 bytes --]

Someone was pinging me about cherry-picking a patch to Jethro, but I can't
find any trace of that email any more.

I can't even remember 100% who it was, but this patch rings a bell.

Does anyone know of this, or other Xen patches that should also be pulled
into
the jethro branch ?

Bruce

On Wed, Feb 17, 2016 at 11:26 PM, Bruce Ashfield <bruce.ashfield@gmail.com>
wrote:

> merged.
>
> Bruce
>
> On Fri, Feb 12, 2016 at 10:34 AM, Chris Patterson <cjp256@gmail.com>
> wrote:
>
>> Placing the stubs function between patch and configure steps
>> breaks because it has dependencies which are not guranteed
>> until the configure step.
>>
>> Build error:
>> "fatal error: gnu/stubs-32.h: No such file or directory"
>>
>> This patch simply moves the step between configure and compile
>> to resolve the dependency issue.
>>
>> Reported-by: Machon Gregory <mbgrego@tycho.nsa.gov>
>> Signed-off-by: Chris Patterson <cjp256@gmail.com>
>> ---
>>  recipes-extended/xen/xen.inc |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/recipes-extended/xen/xen.inc b/recipes-extended/xen/xen.inc
>> index 5555ed3..d35bc3f 100644
>> --- a/recipes-extended/xen/xen.inc
>> +++ b/recipes-extended/xen/xen.inc
>> @@ -782,7 +782,7 @@ do_stubs() {
>>      fi
>>  }
>>
>> -addtask stubs after do_patch before do_configure
>> +addtask stubs after do_configure before do_compile
>>
>>  do_configure() {
>>
>> --
>> 1.7.10.4
>>
>> --
>> _______________________________________________
>> meta-virtualization mailing list
>> meta-virtualization@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-virtualization
>>
>
>
>
> --
> "Thou shalt not follow the NULL pointer, for chaos and madness await thee
> at its end"
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"

[-- Attachment #2: Type: text/html, Size: 3183 bytes --]

Re: [PATCH] xen.inc: fix ordering of stubs task

[Chris Patterson]

On Wed, Feb 24, 2016 at 11:04 AM, Bruce Ashfield
<bruce.ashfield@gmail.com> wrote:
> Someone was pinging me about cherry-picking a patch to Jethro, but I can't
> find any trace of that email any more.
>
> I can't even remember 100% who it was, but this patch rings a bell.
>
> Does anyone know of this, or other Xen patches that should also be pulled
> into
> the jethro branch ?
>
> Bruce

It was not me, but this fix applies to jethro as well. I'd recommend
pushing to jethro & master (although you said "merged" above, I am not
seeing it in master). :)

I'm not aware of other outstanding xen patches.

Thanks Bruce!

Re: [PATCH] xen.inc: fix ordering of stubs task

[Doug Goldstein]

[-- Attachment #1: Type: text/plain, Size: 602 bytes --]

On 2/24/16 10:04 AM, Bruce Ashfield wrote:
> Someone was pinging me about cherry-picking a patch to Jethro, but I can't
> find any trace of that email any more.
> 
> I can't even remember 100% who it was, but this patch rings a bell.
> 
> Does anyone know of this, or other Xen patches that should also be
> pulled into
> the jethro branch ?
> 
> Bruce

Bruce,

They likely pinged you off list because they dropped me a note and I
told them to ask you to backport this. As far as I'm aware this is the
only fix needed and its necessary into jethro and master.

-- 
Doug Goldstein


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 978 bytes --]

Re: [PATCH] xen.inc: fix ordering of stubs task

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 1102 bytes --]

On Thu, Feb 25, 2016 at 9:59 PM, Doug Goldstein <cardoe@cardoe.com> wrote:

> On 2/24/16 10:04 AM, Bruce Ashfield wrote:
> > Someone was pinging me about cherry-picking a patch to Jethro, but I
> can't
> > find any trace of that email any more.
> >
> > I can't even remember 100% who it was, but this patch rings a bell.
> >
> > Does anyone know of this, or other Xen patches that should also be
> > pulled into
> > the jethro branch ?
> >
> > Bruce
>
> Bruce,
>
> They likely pinged you off list because they dropped me a note and I
> told them to ask you to backport this. As far as I'm aware this is the
> only fix needed and its necessary into jethro and master.
>

Great. No worries about pinging me, whatever way works, I just read the
email
filed it .. and then couldn't find it again.

So I figured that I had better broadcast before it was completely swapped
out
of my memory.

This should now be on master and jethro.

Bruce


>
> --
> Doug Goldstein
>
>


-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"

[-- Attachment #2: Type: text/html, Size: 1861 bytes --]