All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Pankaj Dubey <pankaj.dubey@samsung.com>,
	linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: kgene.kim@samsung.com, thomas.ab@samsung.com, olof@lixom.net,
	p.fedin@samsung.com, Kukjin Kim <kgene@kernel.org>
Subject: Re: [RESPIN 4/6] ARM: EXYNOS: Remove SROM related register settings from mach-exynos
Date: Fri, 26 Feb 2016 16:28:11 +0900	[thread overview]
Message-ID: <56CFFE8B.80002@samsung.com> (raw)
In-Reply-To: <1456389222-12738-5-git-send-email-pankaj.dubey@samsung.com>

On 25.02.2016 17:33, Pankaj Dubey wrote:
> As now we have dedicated driver for SROM controller, it will take care
> of saving register banks during S2R so we can safely remove these
> settings from mach-exynos.
> 
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Kukjin Kim <kgene@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>  arch/arm/mach-exynos/Kconfig                 |  2 ++
>  arch/arm/mach-exynos/exynos.c                | 17 ---------
>  arch/arm/mach-exynos/include/mach/map.h      |  3 --
>  arch/arm/mach-exynos/regs-srom.h             | 53 ----------------------------
>  arch/arm/mach-exynos/suspend.c               | 20 ++---------
>  arch/arm/plat-samsung/include/plat/map-s5p.h |  1 -
>  6 files changed, 4 insertions(+), 92 deletions(-)
>  delete mode 100644 arch/arm/mach-exynos/regs-srom.h
> 
> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
> index c4989c2..8da01d1 100644
> --- a/arch/arm/mach-exynos/Kconfig
> +++ b/arch/arm/mach-exynos/Kconfig
> @@ -18,6 +18,7 @@ menuconfig ARCH_EXYNOS
>  	select COMMON_CLK_SAMSUNG
>  	select EXYNOS_THERMAL
>  	select EXYNOS_PMU
> +	select EXYNOS_SROM if PM
>  	select HAVE_ARM_SCU if SMP
>  	select HAVE_S3C2410_I2C if I2C
>  	select HAVE_S3C2410_WATCHDOG if WATCHDOG
> @@ -30,6 +31,7 @@ menuconfig ARCH_EXYNOS
>  	select SRAM
>  	select THERMAL
>  	select MFD_SYSCON
> +	select MEMORY

select SAMSUNG_MC because otherwise the directory won't be build
(memory/Kconfig).

Rest looks good. No need to respin (I can fix this when applying),
unless other people will have some comments.

BR,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESPIN 4/6] ARM: EXYNOS: Remove SROM related register settings from mach-exynos
Date: Fri, 26 Feb 2016 16:28:11 +0900	[thread overview]
Message-ID: <56CFFE8B.80002@samsung.com> (raw)
In-Reply-To: <1456389222-12738-5-git-send-email-pankaj.dubey@samsung.com>

On 25.02.2016 17:33, Pankaj Dubey wrote:
> As now we have dedicated driver for SROM controller, it will take care
> of saving register banks during S2R so we can safely remove these
> settings from mach-exynos.
> 
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Kukjin Kim <kgene@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>  arch/arm/mach-exynos/Kconfig                 |  2 ++
>  arch/arm/mach-exynos/exynos.c                | 17 ---------
>  arch/arm/mach-exynos/include/mach/map.h      |  3 --
>  arch/arm/mach-exynos/regs-srom.h             | 53 ----------------------------
>  arch/arm/mach-exynos/suspend.c               | 20 ++---------
>  arch/arm/plat-samsung/include/plat/map-s5p.h |  1 -
>  6 files changed, 4 insertions(+), 92 deletions(-)
>  delete mode 100644 arch/arm/mach-exynos/regs-srom.h
> 
> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
> index c4989c2..8da01d1 100644
> --- a/arch/arm/mach-exynos/Kconfig
> +++ b/arch/arm/mach-exynos/Kconfig
> @@ -18,6 +18,7 @@ menuconfig ARCH_EXYNOS
>  	select COMMON_CLK_SAMSUNG
>  	select EXYNOS_THERMAL
>  	select EXYNOS_PMU
> +	select EXYNOS_SROM if PM
>  	select HAVE_ARM_SCU if SMP
>  	select HAVE_S3C2410_I2C if I2C
>  	select HAVE_S3C2410_WATCHDOG if WATCHDOG
> @@ -30,6 +31,7 @@ menuconfig ARCH_EXYNOS
>  	select SRAM
>  	select THERMAL
>  	select MFD_SYSCON
> +	select MEMORY

select SAMSUNG_MC because otherwise the directory won't be build
(memory/Kconfig).

Rest looks good. No need to respin (I can fix this when applying),
unless other people will have some comments.

BR,
Krzysztof

  reply	other threads:[~2016-02-26  7:28 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-25  8:33 [RESPIN 0/6] Add support for Exynos SROM Controller driver Pankaj Dubey
2016-02-25  8:33 ` Pankaj Dubey
2016-02-25  8:33 ` [RESPIN 1/6] dt-bindings: EXYNOS: Add exynos-srom device tree binding Pankaj Dubey
2016-02-25  8:33   ` Pankaj Dubey
     [not found]   ` <1456389222-12738-2-git-send-email-pankaj.dubey-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-03-02 17:53     ` Rob Herring
2016-03-02 17:53       ` Rob Herring
2016-03-02 17:53       ` Rob Herring
2016-03-05  4:42       ` pankaj.dubey
2016-03-05  4:42         ` pankaj.dubey
2016-03-08  7:05         ` Pavel Fedin
2016-03-08  7:05           ` Pavel Fedin
2016-04-04  3:35         ` Krzysztof Kozlowski
2016-04-04  3:35           ` Krzysztof Kozlowski
2016-03-05  6:18       ` pankaj.dubey
2016-03-05  6:18         ` pankaj.dubey
2016-03-11  2:39         ` pankaj.dubey
2016-03-11  2:39           ` pankaj.dubey
2016-02-25  8:33 ` [RESPIN 2/6] drivers: memory: Add support for exynos SROM driver Pankaj Dubey
2016-02-25  8:33   ` Pankaj Dubey
2016-02-26  7:25   ` Krzysztof Kozlowski
2016-02-26  7:25     ` Krzysztof Kozlowski
2016-02-26  7:36     ` Krzysztof Kozlowski
2016-02-26  7:36       ` Krzysztof Kozlowski
2016-02-25  8:33 ` [RESPIN 3/6] MAINTAINERS: Add maintainers entry for drivers/memory/samsung Pankaj Dubey
2016-02-25  8:33   ` Pankaj Dubey
2016-02-25  8:33 ` [RESPIN 4/6] ARM: EXYNOS: Remove SROM related register settings from mach-exynos Pankaj Dubey
2016-02-25  8:33   ` Pankaj Dubey
2016-02-26  7:28   ` Krzysztof Kozlowski [this message]
2016-02-26  7:28     ` Krzysztof Kozlowski
2016-02-25  8:33 ` [RESPIN 5/6] dt-bindings: EXYNOS: Describe SROMc configuration Pankaj Dubey
2016-02-25  8:33   ` Pankaj Dubey
     [not found]   ` <1456389222-12738-6-git-send-email-pankaj.dubey-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-03-02 17:57     ` Rob Herring
2016-03-02 17:57       ` Rob Herring
2016-03-02 17:57       ` Rob Herring
2016-03-05  4:47       ` pankaj.dubey
2016-03-05  4:47         ` pankaj.dubey
2016-02-25  8:33 ` [RESPIN 6/6] drivers: memory: exynos-srom: Add support for bank configuration Pankaj Dubey
2016-02-25  8:33   ` Pankaj Dubey
2016-02-26  7:51 ` [RESPIN 0/6] Add support for Exynos SROM Controller driver Krzysztof Kozlowski
2016-02-26  7:51   ` Krzysztof Kozlowski
2016-02-26  8:33   ` Pavel Fedin
2016-02-26  8:33     ` Pavel Fedin
2016-02-26 10:55     ` Krzysztof Kozlowski
2016-02-26 10:55       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56CFFE8B.80002@samsung.com \
    --to=k.kozlowski@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=kgene@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=p.fedin@samsung.com \
    --cc=pankaj.dubey@samsung.com \
    --cc=thomas.ab@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.