From: boris.ostrovsky@oracle.com (Boris Ostrovsky)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH, RESEND] xen: allocate gntdev_copy_batch dynamically
Date: Fri, 26 Feb 2016 08:44:11 -0500 [thread overview]
Message-ID: <56D056AB.4020806@oracle.com> (raw)
In-Reply-To: <1456435523-287763-1-git-send-email-arnd@arndb.de>
On 02/25/2016 04:25 PM, Arnd Bergmann wrote:
> struct gntdev_copy_batch is arguably too large to fit on the kernel stack,
> and we get a warning about the stack usage in gntdev_ioctl_grant_copy:
>
> drivers/xen/gntdev.c:949:1: error: the frame size of 1240 bytes is larger than 1024 bytes
>
> This changes the code to us a dynamic allocation instead.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: a4cdb556cae0 ("xen/gntdev: add ioctl for grant copy")
> ---
> drivers/xen/gntdev.c | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
>
> I sent this in January, Boris sent an almost identical patch
> as http://www.gossamer-threads.com/lists/xen/devel/414056
> but the bug remains present in mainline and linux-next as of
> Feb 25.
>
> Could you apply one of the patches before the bug makes it
> into v4.5?
David wanted to shrink the structure size instead:
http://www.gossamer-threads.com/lists/xen/devel/414535
-boris
WARNING: multiple messages have this Message-ID (diff)
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Arnd Bergmann <arnd@arndb.de>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
David Vrabel <david.vrabel@citrix.com>
Cc: linux-arm-kernel@lists.infradead.org,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH, RESEND] xen: allocate gntdev_copy_batch dynamically
Date: Fri, 26 Feb 2016 08:44:11 -0500 [thread overview]
Message-ID: <56D056AB.4020806@oracle.com> (raw)
In-Reply-To: <1456435523-287763-1-git-send-email-arnd@arndb.de>
On 02/25/2016 04:25 PM, Arnd Bergmann wrote:
> struct gntdev_copy_batch is arguably too large to fit on the kernel stack,
> and we get a warning about the stack usage in gntdev_ioctl_grant_copy:
>
> drivers/xen/gntdev.c:949:1: error: the frame size of 1240 bytes is larger than 1024 bytes
>
> This changes the code to us a dynamic allocation instead.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: a4cdb556cae0 ("xen/gntdev: add ioctl for grant copy")
> ---
> drivers/xen/gntdev.c | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
>
> I sent this in January, Boris sent an almost identical patch
> as http://www.gossamer-threads.com/lists/xen/devel/414056
> but the bug remains present in mainline and linux-next as of
> Feb 25.
>
> Could you apply one of the patches before the bug makes it
> into v4.5?
David wanted to shrink the structure size instead:
http://www.gossamer-threads.com/lists/xen/devel/414535
-boris
next prev parent reply other threads:[~2016-02-26 13:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 21:25 [PATCH, RESEND] xen: allocate gntdev_copy_batch dynamically Arnd Bergmann
2016-02-25 21:25 ` Arnd Bergmann
2016-02-26 13:44 ` Boris Ostrovsky
2016-02-26 13:44 ` Boris Ostrovsky [this message]
2016-02-26 13:44 ` Boris Ostrovsky
-- strict thread matches above, loose matches on Subject: below --
2016-02-25 21:25 Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D056AB.4020806@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.