From: Chen Gang <chengang@emindsoft.com.cn>
To: SeongJae Park <sj38.park@gmail.com>
Cc: Mel Gorman <mgorman@techsingularity.net>,
trivial@kernel.org, akpm@linux-foundation.org, vbabka@suse.cz,
rientjes@google.com, linux-kernel@vger.kernel.org,
mhocko@suse.cz, hannes@cmpxchg.org, vdavydov@virtuozzo.com,
dan.j.williams@intel.com, linux-mm@kvack.org,
Chen Gang <gang.chen.5i5j@gmail.com>
Subject: Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles
Date: Fri, 26 Feb 2016 23:06:41 +0800 [thread overview]
Message-ID: <56D06A01.3080207@emindsoft.com.cn> (raw)
In-Reply-To: <alpine.DEB.2.10.1602260806380.16296@hxeon>
On 2/26/16 07:12, SeongJae Park wrote:
>
> On Fri, 26 Feb 2016, Chen Gang wrote:
>
>>
>> git is a tool mainly for analyzing code, but not mainly for normal
>> reading main code.
>>
>> So for me, the coding styles need not consider about git.
>
>
> It is common to see reject of trivial coding style fixup patch here and
> there. Those patches usually be merged for early stage files that only
> few people read / write. However, for files that are old and lots of
> people read and write, those patches are rejected in usual. I mean, the
> negative opinions for this patches are usual in this community.
>
> I agree that coding style is important and respect your effort. However,
> because the code will be seen and written by most kernel hackers, the file
> should be maintained to be easily readable and writable by most kernel
> hackers, especially, maintainers. What I want to say is, we should
> respect maintainers' opinion in usual.
>
Yes we need consider about the maintainers' options.
And my another ideas are replied in the other thread, please check, and
welcome any ideas, suggestion, and completions.
Thanks.
--
Chen Gang (e??a??)
Managing Natural Environments is the Duty of Human Beings.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Chen Gang <chengang@emindsoft.com.cn>
To: SeongJae Park <sj38.park@gmail.com>
Cc: Mel Gorman <mgorman@techsingularity.net>,
trivial@kernel.org, akpm@linux-foundation.org, vbabka@suse.cz,
rientjes@google.com, linux-kernel@vger.kernel.org,
mhocko@suse.cz, hannes@cmpxchg.org, vdavydov@virtuozzo.com,
dan.j.williams@intel.com, linux-mm@kvack.org,
Chen Gang <gang.chen.5i5j@gmail.com>
Subject: Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles
Date: Fri, 26 Feb 2016 23:06:41 +0800 [thread overview]
Message-ID: <56D06A01.3080207@emindsoft.com.cn> (raw)
In-Reply-To: <alpine.DEB.2.10.1602260806380.16296@hxeon>
On 2/26/16 07:12, SeongJae Park wrote:
>
> On Fri, 26 Feb 2016, Chen Gang wrote:
>
>>
>> git is a tool mainly for analyzing code, but not mainly for normal
>> reading main code.
>>
>> So for me, the coding styles need not consider about git.
>
>
> It is common to see reject of trivial coding style fixup patch here and
> there. Those patches usually be merged for early stage files that only
> few people read / write. However, for files that are old and lots of
> people read and write, those patches are rejected in usual. I mean, the
> negative opinions for this patches are usual in this community.
>
> I agree that coding style is important and respect your effort. However,
> because the code will be seen and written by most kernel hackers, the file
> should be maintained to be easily readable and writable by most kernel
> hackers, especially, maintainers. What I want to say is, we should
> respect maintainers' opinion in usual.
>
Yes we need consider about the maintainers' options.
And my another ideas are replied in the other thread, please check, and
welcome any ideas, suggestion, and completions.
Thanks.
--
Chen Gang (陈刚)
Managing Natural Environments is the Duty of Human Beings.
next prev parent reply other threads:[~2016-02-26 15:03 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 22:26 [PATCH trivial] include/linux/gfp.h: Improve the coding styles chengang
2016-02-24 22:26 ` chengang
2016-02-25 1:01 ` SeongJae Park
2016-02-25 1:01 ` SeongJae Park
2016-02-25 14:12 ` Chen Gang
2016-02-25 14:12 ` Chen Gang
2016-02-25 8:57 ` Michal Hocko
2016-02-25 8:57 ` Michal Hocko
2016-02-25 14:23 ` Chen Gang
2016-02-25 14:23 ` Chen Gang
2016-02-25 14:47 ` Michal Hocko
2016-02-25 14:47 ` Michal Hocko
2016-02-25 22:17 ` Chen Gang
2016-02-25 22:17 ` Chen Gang
2016-02-25 9:27 ` Mel Gorman
2016-02-25 9:27 ` Mel Gorman
2016-02-25 14:38 ` Chen Gang
2016-02-25 14:38 ` Chen Gang
2016-02-25 15:12 ` Jiri Kosina
2016-02-25 15:12 ` Jiri Kosina
2016-02-25 22:19 ` Chen Gang
2016-02-25 22:19 ` Chen Gang
2016-02-25 16:07 ` Mel Gorman
2016-02-25 16:07 ` Mel Gorman
2016-02-25 22:29 ` Chen Gang
2016-02-25 22:29 ` Chen Gang
2016-02-25 22:39 ` Jiri Kosina
2016-02-25 22:39 ` Jiri Kosina
2016-02-26 14:57 ` Chen Gang
2016-02-26 14:57 ` Chen Gang
2016-02-25 23:12 ` SeongJae Park
2016-02-25 23:12 ` SeongJae Park
2016-02-26 15:06 ` Chen Gang [this message]
2016-02-26 15:06 ` Chen Gang
2016-02-26 2:32 ` Jianyu Zhan
2016-02-26 2:32 ` Jianyu Zhan
2016-02-26 15:26 ` Chen Gang
2016-02-26 15:26 ` Chen Gang
2016-02-27 2:45 ` Theodore Ts'o
2016-02-27 2:45 ` Theodore Ts'o
2016-02-27 14:32 ` Chen Gang
2016-02-27 14:32 ` Chen Gang
2016-02-27 16:53 ` Theodore Ts'o
2016-02-27 16:53 ` Theodore Ts'o
2016-02-28 0:21 ` Chen Gang
2016-02-28 0:21 ` Chen Gang
2016-02-28 13:27 ` Mel Gorman
2016-02-28 13:27 ` Mel Gorman
2016-02-28 15:28 ` Chen Gang
2016-02-28 15:28 ` Chen Gang
2016-02-27 23:14 ` Jiri Kosina
2016-02-27 23:14 ` Jiri Kosina
2016-02-28 0:47 ` Chen Gang
2016-02-28 0:47 ` Chen Gang
2016-02-28 22:23 ` Theodore Ts'o
2016-02-29 15:48 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D06A01.3080207@emindsoft.com.cn \
--to=chengang@emindsoft.com.cn \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=gang.chen.5i5j@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
--cc=sj38.park@gmail.com \
--cc=trivial@kernel.org \
--cc=vbabka@suse.cz \
--cc=vdavydov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.