From: Andrew Cooper <andrew.cooper3@citrix.com>
To: xen-devel@lists.xen.org, Olaf Hering <olaf@aepfle.de>
Subject: Re: staging: libxl compile error in libxl__domain_save
Date: Sat, 27 Feb 2016 12:35:17 +0000 [thread overview]
Message-ID: <56D19805.6030905@citrix.com> (raw)
In-Reply-To: <20160227081426.GA5356@aepfle.de>
On 27/02/2016 08:14, Olaf Hering wrote:
> Current staging fails to compile:
>
> [ 276s] libxl_dom_save.c: In function 'libxl__domain_save':
> [ 276s] libxl_dom_save.c:328:9: error: 'rc' may be used uninitialized in this function
>
> It was introduced between abf8824fe530bcf060c757596f68663c87546a6a and
> 3dd926a25d866364ce6d46c21f9ac05a82fa7ffb. Would travis catch such
> errors?
-Wmaybe-uninitalised is quite distro-specific as to whether it is
enabled by default or not.
Travis being ubuntu-based, it appears not.
https://travis-ci.org/xen-project/xen/builds/112092866
I am tempted to suggest explicitly enabling it. I have lost count of
how many times I have found the build legitimately broken on CentOS, due
to their default of -Wmaybe-initialised.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-02-27 12:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-27 8:14 staging: libxl compile error in libxl__domain_save Olaf Hering
2016-02-27 12:35 ` Andrew Cooper [this message]
2016-02-27 14:44 ` Wei Liu
2016-02-27 15:25 ` Olaf Hering
2016-02-28 9:39 ` Olaf Hering
2016-02-28 15:47 ` Wei Liu
2016-02-28 15:55 ` Andrew Cooper
2016-02-29 6:54 ` Olaf Hering
2016-02-29 9:59 ` Andrew Cooper
2016-02-29 10:32 ` Olaf Hering
2016-02-27 13:47 ` Wei Liu
2016-02-27 14:18 ` Wei Liu
2016-02-28 2:01 ` Doug Goldstein
2016-02-28 14:10 ` Andrew Cooper
2016-02-28 20:20 ` Doug Goldstein
2016-02-28 21:06 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D19805.6030905@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=olaf@aepfle.de \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.