From: Doug Goldstein <cardoe@cardoe.com>
To: Olaf Hering <olaf@aepfle.de>, xen-devel@lists.xen.org
Subject: Re: staging: libxl compile error in libxl__domain_save
Date: Sat, 27 Feb 2016 20:01:48 -0600 [thread overview]
Message-ID: <56D2550C.2080605@cardoe.com> (raw)
In-Reply-To: <20160227081426.GA5356@aepfle.de>
[-- Attachment #1.1: Type: text/plain, Size: 1052 bytes --]
On 2/27/16 2:14 AM, Olaf Hering wrote:
>
> Current staging fails to compile:
>
> [ 276s] libxl_dom_save.c: In function 'libxl__domain_save':
> [ 276s] libxl_dom_save.c:328:9: error: 'rc' may be used uninitialized in this function
>
> It was introduced between abf8824fe530bcf060c757596f68663c87546a6a and
> 3dd926a25d866364ce6d46c21f9ac05a82fa7ffb. Would travis catch such
> errors?
>
Travis currently wouldn't catch this because I've got tools disabled
from building. The reason for this is because the configure script fails
to properly find Python due to problems with how AC_CHECK_LIB is called.
Down the road this doesn't matter because we never use that output from
the configure script and instead utilize setuptools to build the
extensions which do linking correctly.
The relevant patch is here and still waiting for an ACK:
http://lists.xen.org/archives/html/xen-devel/2016-02/msg02715.html
Once that gets merged and I can enable tools building on Travis then yes
it would catch it.
--
Doug Goldstein
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-02-28 2:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-27 8:14 staging: libxl compile error in libxl__domain_save Olaf Hering
2016-02-27 12:35 ` Andrew Cooper
2016-02-27 14:44 ` Wei Liu
2016-02-27 15:25 ` Olaf Hering
2016-02-28 9:39 ` Olaf Hering
2016-02-28 15:47 ` Wei Liu
2016-02-28 15:55 ` Andrew Cooper
2016-02-29 6:54 ` Olaf Hering
2016-02-29 9:59 ` Andrew Cooper
2016-02-29 10:32 ` Olaf Hering
2016-02-27 13:47 ` Wei Liu
2016-02-27 14:18 ` Wei Liu
2016-02-28 2:01 ` Doug Goldstein [this message]
2016-02-28 14:10 ` Andrew Cooper
2016-02-28 20:20 ` Doug Goldstein
2016-02-28 21:06 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D2550C.2080605@cardoe.com \
--to=cardoe@cardoe.com \
--cc=olaf@aepfle.de \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.