* [Qemu-trivial] [PATCH v3 0/2] doc/memory: cleanup
@ 2016-02-26 11:29 ` Cao jin
0 siblings, 0 replies; 12+ messages in thread
From: Cao jin @ 2016-02-26 11:29 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, peter.maydell
see each commit message
Cao jin (2):
doc/memory: fix typo
doc/memory: remove the stray extra '-'
docs/memory.txt | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
--
2.1.0
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Qemu-devel] [PATCH v3 0/2] doc/memory: cleanup
@ 2016-02-26 11:29 ` Cao jin
0 siblings, 0 replies; 12+ messages in thread
From: Cao jin @ 2016-02-26 11:29 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, peter.maydell
see each commit message
Cao jin (2):
doc/memory: fix typo
doc/memory: remove the stray extra '-'
docs/memory.txt | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
--
2.1.0
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Qemu-trivial] [PATCH v3 1/2] doc/memory: fix typo
2016-02-26 11:29 ` [Qemu-devel] " Cao jin
@ 2016-02-26 11:29 ` Cao jin
-1 siblings, 0 replies; 12+ messages in thread
From: Cao jin @ 2016-02-26 11:29 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, peter.maydell
Fix typo while also modify its description, make the text parallel to
the existing .impl.unaligned doc.
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
docs/memory.txt | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/docs/memory.txt b/docs/memory.txt
index 8745f76..306280e 100644
--- a/docs/memory.txt
+++ b/docs/memory.txt
@@ -297,8 +297,9 @@ various constraints can be supplied to control how these callbacks are called:
- .valid.min_access_size, .valid.max_access_size define the access sizes
(in bytes) which the device accepts; accesses outside this range will
have device and bus specific behaviour (ignored, or machine check)
- - .valid.aligned specifies that the device only accepts naturally aligned
- accesses. Unaligned accesses invoke device and bus specific behaviour.
+ - .valid.unaligned specifies that the *device being modelled* supports
+ unaligned accesses. if false, unaligned accesses will invoke the appropriate
+ bus or CPU specific behaviour.
- .impl.min_access_size, .impl.max_access_size define the access sizes
(in bytes) supported by the *implementation*; other access sizes will be
emulated using the ones available. For example a 4-byte write will be
--
2.1.0
^ permalink raw reply related [flat|nested] 12+ messages in thread* [Qemu-devel] [PATCH v3 1/2] doc/memory: fix typo
@ 2016-02-26 11:29 ` Cao jin
0 siblings, 0 replies; 12+ messages in thread
From: Cao jin @ 2016-02-26 11:29 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, peter.maydell
Fix typo while also modify its description, make the text parallel to
the existing .impl.unaligned doc.
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
docs/memory.txt | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/docs/memory.txt b/docs/memory.txt
index 8745f76..306280e 100644
--- a/docs/memory.txt
+++ b/docs/memory.txt
@@ -297,8 +297,9 @@ various constraints can be supplied to control how these callbacks are called:
- .valid.min_access_size, .valid.max_access_size define the access sizes
(in bytes) which the device accepts; accesses outside this range will
have device and bus specific behaviour (ignored, or machine check)
- - .valid.aligned specifies that the device only accepts naturally aligned
- accesses. Unaligned accesses invoke device and bus specific behaviour.
+ - .valid.unaligned specifies that the *device being modelled* supports
+ unaligned accesses. if false, unaligned accesses will invoke the appropriate
+ bus or CPU specific behaviour.
- .impl.min_access_size, .impl.max_access_size define the access sizes
(in bytes) supported by the *implementation*; other access sizes will be
emulated using the ones available. For example a 4-byte write will be
--
2.1.0
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [Qemu-trivial] [PATCH v3 1/2] doc/memory: fix typo
2016-02-26 11:29 ` [Qemu-devel] " Cao jin
@ 2016-02-26 11:36 ` Peter Maydell
-1 siblings, 0 replies; 12+ messages in thread
From: Peter Maydell @ 2016-02-26 11:36 UTC (permalink / raw)
To: Cao jin; +Cc: QEMU Trivial, QEMU Developers
On 26 February 2016 at 11:29, Cao jin <caoj.fnst@cn.fujitsu.com> wrote:
> Fix typo while also modify its description, make the text parallel to
> the existing .impl.unaligned doc.
This still isn't a typo...
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
> docs/memory.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/docs/memory.txt b/docs/memory.txt
> index 8745f76..306280e 100644
> --- a/docs/memory.txt
> +++ b/docs/memory.txt
> @@ -297,8 +297,9 @@ various constraints can be supplied to control how these callbacks are called:
> - .valid.min_access_size, .valid.max_access_size define the access sizes
> (in bytes) which the device accepts; accesses outside this range will
> have device and bus specific behaviour (ignored, or machine check)
> - - .valid.aligned specifies that the device only accepts naturally aligned
> - accesses. Unaligned accesses invoke device and bus specific behaviour.
> + - .valid.unaligned specifies that the *device being modelled* supports
> + unaligned accesses. if false, unaligned accesses will invoke the appropriate
> + bus or CPU specific behaviour.
Needs to be a semicolon before the "if".
Either "something something. If foo" or "something something; if foo"
are correct as punctuation. Since we're aiming to follow the same
construction as the existing text for .impl.unaligned, we want the
semicolon and lowercase.
> - .impl.min_access_size, .impl.max_access_size define the access sizes
> (in bytes) supported by the *implementation*; other access sizes will be
> emulated using the ones available. For example a 4-byte write will be
> --
> 2.1.0
thanks
-- PMM
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH v3 1/2] doc/memory: fix typo
@ 2016-02-26 11:36 ` Peter Maydell
0 siblings, 0 replies; 12+ messages in thread
From: Peter Maydell @ 2016-02-26 11:36 UTC (permalink / raw)
To: Cao jin; +Cc: QEMU Trivial, QEMU Developers
On 26 February 2016 at 11:29, Cao jin <caoj.fnst@cn.fujitsu.com> wrote:
> Fix typo while also modify its description, make the text parallel to
> the existing .impl.unaligned doc.
This still isn't a typo...
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
> docs/memory.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/docs/memory.txt b/docs/memory.txt
> index 8745f76..306280e 100644
> --- a/docs/memory.txt
> +++ b/docs/memory.txt
> @@ -297,8 +297,9 @@ various constraints can be supplied to control how these callbacks are called:
> - .valid.min_access_size, .valid.max_access_size define the access sizes
> (in bytes) which the device accepts; accesses outside this range will
> have device and bus specific behaviour (ignored, or machine check)
> - - .valid.aligned specifies that the device only accepts naturally aligned
> - accesses. Unaligned accesses invoke device and bus specific behaviour.
> + - .valid.unaligned specifies that the *device being modelled* supports
> + unaligned accesses. if false, unaligned accesses will invoke the appropriate
> + bus or CPU specific behaviour.
Needs to be a semicolon before the "if".
Either "something something. If foo" or "something something; if foo"
are correct as punctuation. Since we're aiming to follow the same
construction as the existing text for .impl.unaligned, we want the
semicolon and lowercase.
> - .impl.min_access_size, .impl.max_access_size define the access sizes
> (in bytes) supported by the *implementation*; other access sizes will be
> emulated using the ones available. For example a 4-byte write will be
> --
> 2.1.0
thanks
-- PMM
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-trivial] [PATCH v3 1/2] doc/memory: fix typo
2016-02-26 11:36 ` [Qemu-devel] " Peter Maydell
@ 2016-02-28 10:48 ` Cao jin
-1 siblings, 0 replies; 12+ messages in thread
From: Cao jin @ 2016-02-28 10:48 UTC (permalink / raw)
To: Peter Maydell; +Cc: QEMU Trivial, QEMU Developers
On 02/26/2016 07:36 PM, Peter Maydell wrote:
> On 26 February 2016 at 11:29, Cao jin <caoj.fnst@cn.fujitsu.com> wrote:
>
> Needs to be a semicolon before the "if".
>
> Either "something something. If foo" or "something something; if foo"
> are correct as punctuation. Since we're aiming to follow the same
> construction as the existing text for .impl.unaligned, we want the
> semicolon and lowercase.
>
interesting punctuation knowledge to me(as a non-native speaker). Thanks
for the comment:)
--
Yours Sincerely,
Cao jin
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH v3 1/2] doc/memory: fix typo
@ 2016-02-28 10:48 ` Cao jin
0 siblings, 0 replies; 12+ messages in thread
From: Cao jin @ 2016-02-28 10:48 UTC (permalink / raw)
To: Peter Maydell; +Cc: QEMU Trivial, QEMU Developers
On 02/26/2016 07:36 PM, Peter Maydell wrote:
> On 26 February 2016 at 11:29, Cao jin <caoj.fnst@cn.fujitsu.com> wrote:
>
> Needs to be a semicolon before the "if".
>
> Either "something something. If foo" or "something something; if foo"
> are correct as punctuation. Since we're aiming to follow the same
> construction as the existing text for .impl.unaligned, we want the
> semicolon and lowercase.
>
interesting punctuation knowledge to me(as a non-native speaker). Thanks
for the comment:)
--
Yours Sincerely,
Cao jin
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Qemu-trivial] [PATCH v3 2/2] doc/memory: remove the stray extra '-'
2016-02-26 11:29 ` [Qemu-devel] " Cao jin
@ 2016-02-26 11:29 ` Cao jin
-1 siblings, 0 replies; 12+ messages in thread
From: Cao jin @ 2016-02-26 11:29 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, peter.maydell
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
docs/memory.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/memory.txt b/docs/memory.txt
index 306280e..d5c216c 100644
--- a/docs/memory.txt
+++ b/docs/memory.txt
@@ -185,8 +185,8 @@ an MMIO region mapped at 0x0, size 0x6000, priority 2. B currently has two
of its own subregions: D of size 0x1000 at offset 0 and E of size 0x1000 at
offset 0x2000. As a diagram:
- 0 1000 2000 3000 4000 5000 6000 7000 8000
- |------|------|------|------|------|------|------|-------|
+ 0 1000 2000 3000 4000 5000 6000 7000 8000
+ |------|------|------|------|------|------|------|------|
A: [ ]
C: [CCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCC]
B: [ ]
--
2.1.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Qemu-devel] [PATCH v3 2/2] doc/memory: remove the stray extra '-'
@ 2016-02-26 11:29 ` Cao jin
0 siblings, 0 replies; 12+ messages in thread
From: Cao jin @ 2016-02-26 11:29 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, peter.maydell
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
docs/memory.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/memory.txt b/docs/memory.txt
index 306280e..d5c216c 100644
--- a/docs/memory.txt
+++ b/docs/memory.txt
@@ -185,8 +185,8 @@ an MMIO region mapped at 0x0, size 0x6000, priority 2. B currently has two
of its own subregions: D of size 0x1000 at offset 0 and E of size 0x1000 at
offset 0x2000. As a diagram:
- 0 1000 2000 3000 4000 5000 6000 7000 8000
- |------|------|------|------|------|------|------|-------|
+ 0 1000 2000 3000 4000 5000 6000 7000 8000
+ |------|------|------|------|------|------|------|------|
A: [ ]
C: [CCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCC]
B: [ ]
--
2.1.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH v3 2/2] doc/memory: remove the stray extra '-'
2016-02-26 11:29 ` [Qemu-devel] " Cao jin
@ 2016-02-26 11:36 ` Peter Maydell
-1 siblings, 0 replies; 12+ messages in thread
From: Peter Maydell @ 2016-02-26 11:36 UTC (permalink / raw)
To: Cao jin; +Cc: QEMU Trivial, QEMU Developers
On 26 February 2016 at 11:29, Cao jin <caoj.fnst@cn.fujitsu.com> wrote:
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
> docs/memory.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/docs/memory.txt b/docs/memory.txt
> index 306280e..d5c216c 100644
> --- a/docs/memory.txt
> +++ b/docs/memory.txt
> @@ -185,8 +185,8 @@ an MMIO region mapped at 0x0, size 0x6000, priority 2. B currently has two
> of its own subregions: D of size 0x1000 at offset 0 and E of size 0x1000 at
> offset 0x2000. As a diagram:
>
> - 0 1000 2000 3000 4000 5000 6000 7000 8000
> - |------|------|------|------|------|------|------|-------|
> + 0 1000 2000 3000 4000 5000 6000 7000 8000
> + |------|------|------|------|------|------|------|------|
> A: [ ]
> C: [CCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCC]
> B: [ ]
> --
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH v3 2/2] doc/memory: remove the stray extra '-'
@ 2016-02-26 11:36 ` Peter Maydell
0 siblings, 0 replies; 12+ messages in thread
From: Peter Maydell @ 2016-02-26 11:36 UTC (permalink / raw)
To: Cao jin; +Cc: QEMU Trivial, QEMU Developers
On 26 February 2016 at 11:29, Cao jin <caoj.fnst@cn.fujitsu.com> wrote:
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
> docs/memory.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/docs/memory.txt b/docs/memory.txt
> index 306280e..d5c216c 100644
> --- a/docs/memory.txt
> +++ b/docs/memory.txt
> @@ -185,8 +185,8 @@ an MMIO region mapped at 0x0, size 0x6000, priority 2. B currently has two
> of its own subregions: D of size 0x1000 at offset 0 and E of size 0x1000 at
> offset 0x2000. As a diagram:
>
> - 0 1000 2000 3000 4000 5000 6000 7000 8000
> - |------|------|------|------|------|------|------|-------|
> + 0 1000 2000 3000 4000 5000 6000 7000 8000
> + |------|------|------|------|------|------|------|------|
> A: [ ]
> C: [CCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCC]
> B: [ ]
> --
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2016-02-28 10:48 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-26 11:29 [Qemu-trivial] [PATCH v3 0/2] doc/memory: cleanup Cao jin
2016-02-26 11:29 ` [Qemu-devel] " Cao jin
2016-02-26 11:29 ` [Qemu-trivial] [PATCH v3 1/2] doc/memory: fix typo Cao jin
2016-02-26 11:29 ` [Qemu-devel] " Cao jin
2016-02-26 11:36 ` [Qemu-trivial] " Peter Maydell
2016-02-26 11:36 ` [Qemu-devel] " Peter Maydell
2016-02-28 10:48 ` [Qemu-trivial] " Cao jin
2016-02-28 10:48 ` [Qemu-devel] " Cao jin
2016-02-26 11:29 ` [Qemu-trivial] [PATCH v3 2/2] doc/memory: remove the stray extra '-' Cao jin
2016-02-26 11:29 ` [Qemu-devel] " Cao jin
2016-02-26 11:36 ` [Qemu-trivial] " Peter Maydell
2016-02-26 11:36 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.