* [PATCH] pinctrl-bcm2835: Fix cut-and-paste error in "pull" parsing
@ 2016-03-01 1:30 ` Eric Anholt
0 siblings, 0 replies; 9+ messages in thread
From: Eric Anholt @ 2016-03-01 1:30 UTC (permalink / raw)
To: linux-arm-kernel
From: Phil Elwell <phil@raspberrypi.org>
The DT bindings for pinctrl-bcm2835 allow both the function and pull
to contain either one entry or one per pin. However, an error in the
DT parsing can cause failures if the number of pulls differs from the
number of functions.
Signed-off-by: Eric Anholt <eric@anholt.net>
Cc: stable at vger.kernel.org
---
Yes, the s-o-b differs from the author of the commit, but this falls
under part b) of the process.
Phil, any chance you could start putting Signed-off-by lines on your
kernel commits?
drivers/pinctrl/bcm/pinctrl-bcm2835.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
index 0f5997c..08b1d93 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c
+++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
@@ -779,7 +779,7 @@ static int bcm2835_pctl_dt_node_to_map(struct pinctrl_dev *pctldev,
}
if (num_pulls) {
err = of_property_read_u32_index(np, "brcm,pull",
- (num_funcs > 1) ? i : 0, &pull);
+ (num_pulls > 1) ? i : 0, &pull);
if (err)
goto out;
err = bcm2835_pctl_dt_node_to_map_pull(pc, np, pin,
--
2.7.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] pinctrl-bcm2835: Fix cut-and-paste error in "pull" parsing
2016-03-01 1:30 ` Eric Anholt
(?)
@ 2016-03-01 9:13 ` Phil Elwell
-1 siblings, 0 replies; 9+ messages in thread
From: Phil Elwell @ 2016-03-01 9:13 UTC (permalink / raw)
To: Eric Anholt, Linus Walleij
Cc: Stephen Warren, Lee Jones, linux-kernel, stable, linux-gpio,
linux-rpi-kernel, linux-arm-kernel
On 01/03/2016 01:30, Eric Anholt wrote:
> From: Phil Elwell <phil@raspberrypi.org>
>
> The DT bindings for pinctrl-bcm2835 allow both the function and pull
> to contain either one entry or one per pin. However, an error in the
> DT parsing can cause failures if the number of pulls differs from the
> number of functions.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> Cc: stable@vger.kernel.org
> ---
>
> Yes, the s-o-b differs from the author of the commit, but this falls
> under part b) of the process.
>
> Phil, any chance you could start putting Signed-off-by lines on your
> kernel commits?
>
> drivers/pinctrl/bcm/pinctrl-bcm2835.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
> index 0f5997c..08b1d93 100644
> --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c
> +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
> @@ -779,7 +779,7 @@ static int bcm2835_pctl_dt_node_to_map(struct pinctrl_dev *pctldev,
> }
> if (num_pulls) {
> err = of_property_read_u32_index(np, "brcm,pull",
> - (num_funcs > 1) ? i : 0, &pull);
> + (num_pulls > 1) ? i : 0, &pull);
> if (err)
> goto out;
> err = bcm2835_pctl_dt_node_to_map_pull(pc, np, pin,
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] pinctrl-bcm2835: Fix cut-and-paste error in "pull" parsing
@ 2016-03-01 9:13 ` Phil Elwell
0 siblings, 0 replies; 9+ messages in thread
From: Phil Elwell @ 2016-03-01 9:13 UTC (permalink / raw)
To: Eric Anholt, Linus Walleij
Cc: linux-rpi-kernel, linux-arm-kernel, linux-kernel, Stephen Warren,
Lee Jones, linux-gpio, stable
On 01/03/2016 01:30, Eric Anholt wrote:
> From: Phil Elwell <phil@raspberrypi.org>
>
> The DT bindings for pinctrl-bcm2835 allow both the function and pull
> to contain either one entry or one per pin. However, an error in the
> DT parsing can cause failures if the number of pulls differs from the
> number of functions.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> Cc: stable@vger.kernel.org
> ---
>
> Yes, the s-o-b differs from the author of the commit, but this falls
> under part b) of the process.
>
> Phil, any chance you could start putting Signed-off-by lines on your
> kernel commits?
>
> drivers/pinctrl/bcm/pinctrl-bcm2835.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
> index 0f5997c..08b1d93 100644
> --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c
> +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
> @@ -779,7 +779,7 @@ static int bcm2835_pctl_dt_node_to_map(struct pinctrl_dev *pctldev,
> }
> if (num_pulls) {
> err = of_property_read_u32_index(np, "brcm,pull",
> - (num_funcs > 1) ? i : 0, &pull);
> + (num_pulls > 1) ? i : 0, &pull);
> if (err)
> goto out;
> err = bcm2835_pctl_dt_node_to_map_pull(pc, np, pin,
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH] pinctrl-bcm2835: Fix cut-and-paste error in "pull" parsing
@ 2016-03-01 9:13 ` Phil Elwell
0 siblings, 0 replies; 9+ messages in thread
From: Phil Elwell @ 2016-03-01 9:13 UTC (permalink / raw)
To: linux-arm-kernel
On 01/03/2016 01:30, Eric Anholt wrote:
> From: Phil Elwell <phil@raspberrypi.org>
>
> The DT bindings for pinctrl-bcm2835 allow both the function and pull
> to contain either one entry or one per pin. However, an error in the
> DT parsing can cause failures if the number of pulls differs from the
> number of functions.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> Cc: stable at vger.kernel.org
> ---
>
> Yes, the s-o-b differs from the author of the commit, but this falls
> under part b) of the process.
>
> Phil, any chance you could start putting Signed-off-by lines on your
> kernel commits?
>
> drivers/pinctrl/bcm/pinctrl-bcm2835.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
> index 0f5997c..08b1d93 100644
> --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c
> +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
> @@ -779,7 +779,7 @@ static int bcm2835_pctl_dt_node_to_map(struct pinctrl_dev *pctldev,
> }
> if (num_pulls) {
> err = of_property_read_u32_index(np, "brcm,pull",
> - (num_funcs > 1) ? i : 0, &pull);
> + (num_pulls > 1) ? i : 0, &pull);
> if (err)
> goto out;
> err = bcm2835_pctl_dt_node_to_map_pull(pc, np, pin,
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] pinctrl-bcm2835: Fix cut-and-paste error in "pull" parsing
2016-03-01 1:30 ` Eric Anholt
@ 2016-03-03 21:09 ` Stephen Warren
-1 siblings, 0 replies; 9+ messages in thread
From: Stephen Warren @ 2016-03-03 21:09 UTC (permalink / raw)
To: Eric Anholt
Cc: Linus Walleij, linux-rpi-kernel, linux-arm-kernel, linux-kernel,
Lee Jones, linux-gpio, Phil Elwell, stable
On 02/29/2016 06:30 PM, Eric Anholt wrote:
> From: Phil Elwell <phil@raspberrypi.org>
>
> The DT bindings for pinctrl-bcm2835 allow both the function and pull
> to contain either one entry or one per pin. However, an error in the
> DT parsing can cause failures if the number of pulls differs from the
> number of functions.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> Cc: stable@vger.kernel.org
> ---
>
> Yes, the s-o-b differs from the author of the commit, but this falls
> under part b) of the process.
I'd argue that part (b) only applies if the s-o-b line is present in the
original, otherwise I'm not sure how it's clear the author intended to
publish their source under the license in question. That's why I've
always beedn careful to go back and ask the original author to give
their s-o-b, like you did. Some commits at least in the earlier Pi
Foundation kernels also clearly had incorrect git author values, or were
squashed together forms of multiple peoples' work:-(
Luckily it's a moot point since Phil gave his s-o-b.
Reviewed-by: Stephen Warren <swarren@wwwdotorg.org>
Does a similar bug exist in any other pinctrl drivers?
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] pinctrl-bcm2835: Fix cut-and-paste error in "pull" parsing
@ 2016-03-03 21:09 ` Stephen Warren
0 siblings, 0 replies; 9+ messages in thread
From: Stephen Warren @ 2016-03-03 21:09 UTC (permalink / raw)
To: linux-arm-kernel
On 02/29/2016 06:30 PM, Eric Anholt wrote:
> From: Phil Elwell <phil@raspberrypi.org>
>
> The DT bindings for pinctrl-bcm2835 allow both the function and pull
> to contain either one entry or one per pin. However, an error in the
> DT parsing can cause failures if the number of pulls differs from the
> number of functions.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> Cc: stable at vger.kernel.org
> ---
>
> Yes, the s-o-b differs from the author of the commit, but this falls
> under part b) of the process.
I'd argue that part (b) only applies if the s-o-b line is present in the
original, otherwise I'm not sure how it's clear the author intended to
publish their source under the license in question. That's why I've
always beedn careful to go back and ask the original author to give
their s-o-b, like you did. Some commits at least in the earlier Pi
Foundation kernels also clearly had incorrect git author values, or were
squashed together forms of multiple peoples' work:-(
Luckily it's a moot point since Phil gave his s-o-b.
Reviewed-by: Stephen Warren <swarren@wwwdotorg.org>
Does a similar bug exist in any other pinctrl drivers?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] pinctrl-bcm2835: Fix cut-and-paste error in "pull" parsing
2016-03-01 1:30 ` Eric Anholt
@ 2016-03-08 8:18 ` Linus Walleij
-1 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2016-03-08 8:18 UTC (permalink / raw)
To: Eric Anholt
Cc: linux-rpi-kernel, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Stephen Warren, Lee Jones,
linux-gpio@vger.kernel.org, Phil Elwell, stable
On Tue, Mar 1, 2016 at 8:30 AM, Eric Anholt <eric@anholt.net> wrote:
> From: Phil Elwell <phil@raspberrypi.org>
>
> The DT bindings for pinctrl-bcm2835 allow both the function and pull
> to contain either one entry or one per pin. However, an error in the
> DT parsing can cause failures if the number of pulls differs from the
> number of functions.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> Cc: stable@vger.kernel.org
> ---
>
> Yes, the s-o-b differs from the author of the commit, but this falls
> under part b) of the process.
>
> Phil, any chance you could start putting Signed-off-by lines on your
> kernel commits?
Patch applied with the extra SoB and Stephen's review tag.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] pinctrl-bcm2835: Fix cut-and-paste error in "pull" parsing
@ 2016-03-08 8:18 ` Linus Walleij
0 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2016-03-08 8:18 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Mar 1, 2016 at 8:30 AM, Eric Anholt <eric@anholt.net> wrote:
> From: Phil Elwell <phil@raspberrypi.org>
>
> The DT bindings for pinctrl-bcm2835 allow both the function and pull
> to contain either one entry or one per pin. However, an error in the
> DT parsing can cause failures if the number of pulls differs from the
> number of functions.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> Cc: stable at vger.kernel.org
> ---
>
> Yes, the s-o-b differs from the author of the commit, but this falls
> under part b) of the process.
>
> Phil, any chance you could start putting Signed-off-by lines on your
> kernel commits?
Patch applied with the extra SoB and Stephen's review tag.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread