All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felix Fietkau <nbd@openwrt.org>
To: greearb@candelatech.com, ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath10k: Fix mgmt tx status for 10.4.3 firmware.
Date: Tue, 1 Mar 2016 10:26:42 +0100	[thread overview]
Message-ID: <56D56052.2010007@openwrt.org> (raw)
In-Reply-To: <1456782654-24723-1-git-send-email-greearb@candelatech.com>

On 2016-02-29 22:50, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
> 
> When testing a 10.4.3 firmware in station mode, I notice that
> when the AP is powered down, the ath10k does not notice AP is gone
> because mgt frames get tx status of 3, which is not handled.
> 
> It appears that status 3 means something similar to failed-retry.
> 
> Treating it thus lets the station disconnect properly.
> 
> Tested against a non-stock 10.4.3 firmware, but likely upstream
> firmware acts similarly in this case.
> 
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
> 
> This patch is against a heavily patched tree based on 4.4, hopefully
> it can be applied to upstream code w/out too much trouble.
> 
> Someone should verify this on stock 10.4-ish firmware before applying.
> 
>  drivers/net/wireless/ath/ath10k/htt.h    |  4 +++-
>  drivers/net/wireless/ath/ath10k/htt_rx.c | 11 +++++++++--
>  2 files changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath10k/htt.h b/drivers/net/wireless/ath/ath10k/htt.h
> index c31a31f..de663a6 100644
> --- a/drivers/net/wireless/ath/ath10k/htt.h
> +++ b/drivers/net/wireless/ath/ath10k/htt.h
> @@ -309,7 +309,9 @@ struct htt_mgmt_tx_desc {
>  enum htt_mgmt_tx_status {
>  	HTT_MGMT_TX_STATUS_OK    = 0,
>  	HTT_MGMT_TX_STATUS_RETRY = 1,
> -	HTT_MGMT_TX_STATUS_DROP  = 2
> +	HTT_MGMT_TX_STATUS_DROP  = 2,
> +	HTT_MGMT_TX_STATUS_TXFILT = 3 /* Seems to be logically similar to
> +					 RETRY failure. */
In that case the driver should probably set IEEE80211_TX_STAT_TX_FILTERED

- Felix

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Felix Fietkau <nbd@openwrt.org>
To: greearb@candelatech.com, ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath10k: Fix mgmt tx status for 10.4.3 firmware.
Date: Tue, 1 Mar 2016 10:26:42 +0100	[thread overview]
Message-ID: <56D56052.2010007@openwrt.org> (raw)
In-Reply-To: <1456782654-24723-1-git-send-email-greearb@candelatech.com>

On 2016-02-29 22:50, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
> 
> When testing a 10.4.3 firmware in station mode, I notice that
> when the AP is powered down, the ath10k does not notice AP is gone
> because mgt frames get tx status of 3, which is not handled.
> 
> It appears that status 3 means something similar to failed-retry.
> 
> Treating it thus lets the station disconnect properly.
> 
> Tested against a non-stock 10.4.3 firmware, but likely upstream
> firmware acts similarly in this case.
> 
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
> 
> This patch is against a heavily patched tree based on 4.4, hopefully
> it can be applied to upstream code w/out too much trouble.
> 
> Someone should verify this on stock 10.4-ish firmware before applying.
> 
>  drivers/net/wireless/ath/ath10k/htt.h    |  4 +++-
>  drivers/net/wireless/ath/ath10k/htt_rx.c | 11 +++++++++--
>  2 files changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath10k/htt.h b/drivers/net/wireless/ath/ath10k/htt.h
> index c31a31f..de663a6 100644
> --- a/drivers/net/wireless/ath/ath10k/htt.h
> +++ b/drivers/net/wireless/ath/ath10k/htt.h
> @@ -309,7 +309,9 @@ struct htt_mgmt_tx_desc {
>  enum htt_mgmt_tx_status {
>  	HTT_MGMT_TX_STATUS_OK    = 0,
>  	HTT_MGMT_TX_STATUS_RETRY = 1,
> -	HTT_MGMT_TX_STATUS_DROP  = 2
> +	HTT_MGMT_TX_STATUS_DROP  = 2,
> +	HTT_MGMT_TX_STATUS_TXFILT = 3 /* Seems to be logically similar to
> +					 RETRY failure. */
In that case the driver should probably set IEEE80211_TX_STAT_TX_FILTERED

- Felix

  reply	other threads:[~2016-03-01 13:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-29 21:50 [PATCH] ath10k: Fix mgmt tx status for 10.4.3 firmware greearb
2016-02-29 21:50 ` greearb
2016-03-01  9:26 ` Felix Fietkau [this message]
2016-03-01  9:26   ` Felix Fietkau
2016-06-16 13:57 ` Valo, Kalle
2016-06-16 13:57   ` Valo, Kalle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D56052.2010007@openwrt.org \
    --to=nbd@openwrt.org \
    --cc=ath10k@lists.infradead.org \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.