From: Laxman Dewangan <ldewangan@nvidia.com>
To: Mark Brown <broonie@kernel.org>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
lgirdwood@gmail.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] regulator: core: Add support for active-discharge configuration
Date: Wed, 2 Mar 2016 07:31:40 +0530 [thread overview]
Message-ID: <56D64984.8080405@nvidia.com> (raw)
In-Reply-To: <20160302014421.GM18327@sirena.org.uk>
On Wednesday 02 March 2016 07:14 AM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Tue, Mar 01, 2016 at 06:08:13PM +0530, Laxman Dewangan wrote:
>
>> + * @active_discharge: Enable/disable active discharge. The values are:
>> + * -1: Default, 0: Disable, 1: Enable.
> This isn't a good interface, it means that 0 (which is the default value
> for static constrants or kzalloc()ed constraints) means to actively
> discharge rather than leave the settings unchanged but our general
> policy is to not touch anything unless explicitly told to do so.
>
Yaah, I agree.
I had other option to use 0 as default, 1 as disable and 2 as enable.
but generally for disable, we use 0 and for enable 1 and that's why I
went to -1,0,1 approach.
Will it be fine to have this as
0: Default i..e do not change.
1: disable.
2: Enable.
WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Mark Brown <broonie@kernel.org>
Cc: <robh+dt@kernel.org>, <pawel.moll@arm.com>,
<mark.rutland@arm.com>, <lgirdwood@gmail.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] regulator: core: Add support for active-discharge configuration
Date: Wed, 2 Mar 2016 07:31:40 +0530 [thread overview]
Message-ID: <56D64984.8080405@nvidia.com> (raw)
In-Reply-To: <20160302014421.GM18327@sirena.org.uk>
On Wednesday 02 March 2016 07:14 AM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Tue, Mar 01, 2016 at 06:08:13PM +0530, Laxman Dewangan wrote:
>
>> + * @active_discharge: Enable/disable active discharge. The values are:
>> + * -1: Default, 0: Disable, 1: Enable.
> This isn't a good interface, it means that 0 (which is the default value
> for static constrants or kzalloc()ed constraints) means to actively
> discharge rather than leave the settings unchanged but our general
> policy is to not touch anything unless explicitly told to do so.
>
Yaah, I agree.
I had other option to use 0 as default, 1 as disable and 2 as enable.
but generally for disable, we use 0 and for enable 1 and that's why I
went to -1,0,1 approach.
Will it be fine to have this as
0: Default i..e do not change.
1: disable.
2: Enable.
next prev parent reply other threads:[~2016-03-02 2:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 12:38 [PATCH 0/4] regulator: Add support for configuration of active-discharge Laxman Dewangan
2016-03-01 12:38 ` Laxman Dewangan
2016-03-01 12:38 ` [PATCH 1/4] regulator: DT: Add DT property for active-discharge configuration Laxman Dewangan
2016-03-01 12:38 ` Laxman Dewangan
2016-03-01 12:38 ` [PATCH 2/4] regulator: core: Add support " Laxman Dewangan
2016-03-01 12:38 ` Laxman Dewangan
2016-03-02 1:44 ` Mark Brown
2016-03-02 2:01 ` Laxman Dewangan [this message]
2016-03-02 2:01 ` Laxman Dewangan
[not found] ` <56D64984.8080405-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-02 3:13 ` Mark Brown
2016-03-02 3:13 ` Mark Brown
2016-03-01 12:38 ` [PATCH 3/4] regulator: helper: Add helper to configure active-discharge using regmap Laxman Dewangan
2016-03-01 12:38 ` Laxman Dewangan
2016-03-01 12:38 ` [PATCH 4/4] regulator: max77620: Add support to configure active-discharge Laxman Dewangan
2016-03-01 12:38 ` Laxman Dewangan
-- strict thread matches above, loose matches on Subject: below --
2016-03-02 6:56 [PATCH V2 0/4] regulator: Add support for configuration of active-discharge Laxman Dewangan
[not found] ` <1456901797-21340-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-02 6:56 ` [PATCH 2/4] regulator: core: Add support for active-discharge configuration Laxman Dewangan
2016-03-02 6:56 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D64984.8080405@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.