All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Fedorov <serge.fdrv@gmail.com>
To: Sergey Sorokin <afarallax@yandex.ru>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org
Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH] target-arm: Fix translation level on early translation faults
Date: Wed, 2 Mar 2016 22:19:18 +0300	[thread overview]
Message-ID: <56D73CB6.7040702@gmail.com> (raw)
In-Reply-To: <1456941872-8791-1-git-send-email-afarallax@yandex.ru>

On 02.03.2016 21:04, Sergey Sorokin wrote:
> Qemu reports translation fault on 1st level instead of 0th level in case of
> AArch64 address translation if the translation table walk is disabled or
> the address is in the gap between the two regions.

It's probably not a very clear description in the commit message. IIUC,
level 0 fault is reported in case of any fault from TTBR in AArch64 state.

Best regards,
Sergey

>
> Signed-off-by: Sergey Sorokin <afarallax@yandex.ru>
> ---
>  target-arm/helper.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/target-arm/helper.c b/target-arm/helper.c
> index 18c8296..09f920c 100644
> --- a/target-arm/helper.c
> +++ b/target-arm/helper.c
> @@ -7238,6 +7238,7 @@ static bool get_phys_addr_lpae(CPUARMState *env, target_ulong address,
>       * support for those page table walks.
>       */
>      if (arm_el_is_aa64(env, el)) {
> +        level = 0;
>          va_size = 64;
>          if (el > 1) {
>              if (mmu_idx != ARMMMUIdx_S2NS) {


WARNING: multiple messages have this Message-ID (diff)
From: Sergey Fedorov <serge.fdrv@gmail.com>
To: Sergey Sorokin <afarallax@yandex.ru>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] target-arm: Fix translation level on early translation faults
Date: Wed, 2 Mar 2016 22:19:18 +0300	[thread overview]
Message-ID: <56D73CB6.7040702@gmail.com> (raw)
In-Reply-To: <1456941872-8791-1-git-send-email-afarallax@yandex.ru>

On 02.03.2016 21:04, Sergey Sorokin wrote:
> Qemu reports translation fault on 1st level instead of 0th level in case of
> AArch64 address translation if the translation table walk is disabled or
> the address is in the gap between the two regions.

It's probably not a very clear description in the commit message. IIUC,
level 0 fault is reported in case of any fault from TTBR in AArch64 state.

Best regards,
Sergey

>
> Signed-off-by: Sergey Sorokin <afarallax@yandex.ru>
> ---
>  target-arm/helper.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/target-arm/helper.c b/target-arm/helper.c
> index 18c8296..09f920c 100644
> --- a/target-arm/helper.c
> +++ b/target-arm/helper.c
> @@ -7238,6 +7238,7 @@ static bool get_phys_addr_lpae(CPUARMState *env, target_ulong address,
>       * support for those page table walks.
>       */
>      if (arm_el_is_aa64(env, el)) {
> +        level = 0;
>          va_size = 64;
>          if (el > 1) {
>              if (mmu_idx != ARMMMUIdx_S2NS) {

  reply	other threads:[~2016-03-02 19:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-02 18:04 [Qemu-devel] [PATCH] target-arm: Fix translation level on early translation faults Sergey Sorokin
2016-03-02 19:19 ` Sergey Fedorov [this message]
2016-03-02 19:19   ` Sergey Fedorov
2016-03-03 13:49   ` [Qemu-arm] " Peter Maydell
2016-03-03 13:49     ` Peter Maydell
2016-03-03 14:48     ` [Qemu-arm] " Sergey Fedorov
2016-03-03 14:48       ` Sergey Fedorov
2016-03-03 14:55       ` [Qemu-arm] " Peter Maydell
2016-03-03 14:55         ` [Qemu-devel] [Qemu-arm] " Peter Maydell
2016-03-03 16:37         ` [Qemu-arm] [Qemu-devel] " Sergey Fedorov
2016-03-03 16:37           ` [Qemu-devel] [Qemu-arm] " Sergey Fedorov
2016-03-03 16:54           ` [Qemu-arm] [Qemu-devel] " Peter Maydell
2016-03-03 16:54             ` [Qemu-devel] [Qemu-arm] " Peter Maydell
2016-03-04 15:03             ` [Qemu-arm] [Qemu-devel] " Sergey Sorokin
2016-03-04 15:03               ` [Qemu-devel] [Qemu-arm] " Sergey Sorokin
2016-03-04 15:18               ` [Qemu-arm] [Qemu-devel] " Peter Maydell
2016-03-04 15:18                 ` [Qemu-devel] [Qemu-arm] " Peter Maydell
2016-03-02 21:36 ` [Qemu-arm] [Qemu-devel] " Sergey Fedorov
2016-03-02 21:36   ` Sergey Fedorov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D73CB6.7040702@gmail.com \
    --to=serge.fdrv@gmail.com \
    --cc=afarallax@yandex.ru \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.