From: Zefan Li <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-team-b10kYP2dOMg@public.gmane.org
Subject: Re: [cgroup/for-4.6 1/2] cgroup: re-hash init_css_set after subsystems are initialized
Date: Thu, 3 Mar 2016 11:05:09 +0800 [thread overview]
Message-ID: <56D7A9E5.2030507@huawei.com> (raw)
In-Reply-To: <20160302180712.GA11029-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
On 2016/3/3 2:07, Tejun Heo wrote:
> css_sets are hashed by their subsys[] contents and in cgroup_init()
> init_css_set is hashed early, before subsystem inits, when all entries
> in its subsys[] are NULL, so that cgroup_dfl_root initialization can
> find and link to it. As subsystems are initialized,
> init_css_set.subsys[] is filled up but the hashing is never updated
> making init_css_set hashed in the wrong place. While incorrect, this
> doesn't cause a critical failure as css_set management code would
> create an identical css_set dynamically.
>
> Fix it by rehashing init_css_set after subsystems are initialized.
> While at it, drop unnecessary @key local variable.
>
> Signed-off-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
For both patches:
Acked-by: Zefan Li <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
WARNING: multiple messages have this Message-ID (diff)
From: Zefan Li <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>
Cc: <cgroups@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel-team@fb.com>
Subject: Re: [cgroup/for-4.6 1/2] cgroup: re-hash init_css_set after subsystems are initialized
Date: Thu, 3 Mar 2016 11:05:09 +0800 [thread overview]
Message-ID: <56D7A9E5.2030507@huawei.com> (raw)
In-Reply-To: <20160302180712.GA11029@mtj.duckdns.org>
On 2016/3/3 2:07, Tejun Heo wrote:
> css_sets are hashed by their subsys[] contents and in cgroup_init()
> init_css_set is hashed early, before subsystem inits, when all entries
> in its subsys[] are NULL, so that cgroup_dfl_root initialization can
> find and link to it. As subsystems are initialized,
> init_css_set.subsys[] is filled up but the hashing is never updated
> making init_css_set hashed in the wrong place. While incorrect, this
> doesn't cause a critical failure as css_set management code would
> create an identical css_set dynamically.
>
> Fix it by rehashing init_css_set after subsystems are initialized.
> While at it, drop unnecessary @key local variable.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
For both patches:
Acked-by: Zefan Li <lizefan@huawei.com>
next prev parent reply other threads:[~2016-03-03 3:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 18:07 [cgroup/for-4.6 1/2] cgroup: re-hash init_css_set after subsystems are initialized Tejun Heo
2016-03-02 18:07 ` Tejun Heo
[not found] ` <20160302180712.GA11029-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-03-02 18:07 ` [cgroup/for-4.6 2/2] cgroup: suppress spurious de-populated events Tejun Heo
2016-03-02 18:07 ` Tejun Heo
2016-03-03 3:05 ` Zefan Li [this message]
2016-03-03 3:05 ` [cgroup/for-4.6 1/2] cgroup: re-hash init_css_set after subsystems are initialized Zefan Li
2016-03-03 14:59 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D7A9E5.2030507@huawei.com \
--to=lizefan-hv44wf8li93qt0dzr+alfa@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=kernel-team-b10kYP2dOMg@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.