From: Haggai Eran <haggaie@mellanox.com>
To: Parav Pandit <pandit.parav@gmail.com>, Tejun Heo <tj@kernel.org>
Cc: cgroups@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
lizefan@huawei.com, Johannes Weiner <hannes@cmpxchg.org>,
Doug Ledford <dledford@redhat.com>,
Liran Liss <liranl@mellanox.com>,
"Hefty, Sean" <sean.hefty@intel.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Jonathan Corbet <corbet@lwn.net>,
james.l.morris@oracle.com, serge@hallyn.com,
Or Gerlitz <ogerlitz@mellanox.com>,
Matan Barak <matanb@mellanox.com>,
raindel@mellanox.com, akpm@linux-foundation.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCHv9 1/3] rdmacg: Added rdma cgroup controller
Date: Thu, 3 Mar 2016 10:14:53 +0200 [thread overview]
Message-ID: <56D7F27D.1040702@mellanox.com> (raw)
In-Reply-To: <CAG53R5WcbE8Hesb2sh6xg1fRLBOBt+VFo0L3U6WLPr3irtko8w@mail.gmail.com>
On 03/03/2016 05:18, Parav Pandit wrote:
> On Thu, Mar 3, 2016 at 1:28 AM, Parav Pandit <pandit.parav@gmail.com> wrote:
>> On Wed, Mar 2, 2016 at 11:09 PM, Tejun Heo <tj@kernel.org> wrote:
>>> Nothing seems to prevent @cg from going away if this races with
>>> @current being migrated to a different cgroup. Have you run this with
>>> lockdep and rcu debugging enabled? This should have triggered a
>>> warning.
> I am able to reproduce this race. Looking into how to address it.
If I understand correctly, task_css() requires rcu read lock being held.
Is task_get_css() suitable here?
WARNING: multiple messages have this Message-ID (diff)
From: Haggai Eran <haggaie@mellanox.com>
To: Parav Pandit <pandit.parav@gmail.com>, Tejun Heo <tj@kernel.org>
Cc: <cgroups@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
<lizefan@huawei.com>, Johannes Weiner <hannes@cmpxchg.org>,
Doug Ledford <dledford@redhat.com>,
Liran Liss <liranl@mellanox.com>,
"Hefty, Sean" <sean.hefty@intel.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Jonathan Corbet <corbet@lwn.net>, <james.l.morris@oracle.com>,
<serge@hallyn.com>, Or Gerlitz <ogerlitz@mellanox.com>,
Matan Barak <matanb@mellanox.com>, <raindel@mellanox.com>,
<akpm@linux-foundation.org>,
<linux-security-module@vger.kernel.org>
Subject: Re: [PATCHv9 1/3] rdmacg: Added rdma cgroup controller
Date: Thu, 3 Mar 2016 10:14:53 +0200 [thread overview]
Message-ID: <56D7F27D.1040702@mellanox.com> (raw)
In-Reply-To: <CAG53R5WcbE8Hesb2sh6xg1fRLBOBt+VFo0L3U6WLPr3irtko8w@mail.gmail.com>
On 03/03/2016 05:18, Parav Pandit wrote:
> On Thu, Mar 3, 2016 at 1:28 AM, Parav Pandit <pandit.parav@gmail.com> wrote:
>> On Wed, Mar 2, 2016 at 11:09 PM, Tejun Heo <tj@kernel.org> wrote:
>>> Nothing seems to prevent @cg from going away if this races with
>>> @current being migrated to a different cgroup. Have you run this with
>>> lockdep and rcu debugging enabled? This should have triggered a
>>> warning.
> I am able to reproduce this race. Looking into how to address it.
If I understand correctly, task_css() requires rcu read lock being held.
Is task_get_css() suitable here?
next prev parent reply other threads:[~2016-03-03 8:14 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 19:05 [PATCHv9 0/3] rdmacg: IB/core: rdma controller support Parav Pandit
2016-03-01 19:05 ` Parav Pandit
2016-03-01 19:05 ` [PATCHv9 1/3] rdmacg: Added rdma cgroup controller Parav Pandit
[not found] ` <1456859137-13646-2-git-send-email-pandit.parav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-03-02 17:39 ` Tejun Heo
2016-03-02 17:39 ` Tejun Heo
2016-03-02 19:58 ` Parav Pandit
2016-03-03 2:49 ` Parav Pandit
2016-03-03 7:51 ` Haggai Eran
2016-03-03 7:51 ` Haggai Eran
2016-03-05 11:15 ` Parav Pandit
2016-03-05 12:52 ` Tejun Heo
2016-03-05 17:20 ` Parav Pandit
2016-03-06 8:37 ` Haggai Eran
2016-03-06 8:37 ` Haggai Eran
[not found] ` <CAG53R5V-fhbVqZWroAkvDpgjNWchnO87G47-iXqSGg41sY1A5Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-12 6:19 ` Parav Pandit
2016-03-12 6:19 ` Parav Pandit
2016-03-16 20:40 ` Tejun Heo
2016-03-17 20:04 ` Parav Pandit
[not found] ` <CAG53R5UAmTP9-m77-j2tPGZ+z8AicuVvUB_++cRUbQY-EwaBYw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-03 3:18 ` Parav Pandit
2016-03-03 3:18 ` Parav Pandit
2016-03-03 8:14 ` Haggai Eran [this message]
2016-03-03 8:14 ` Haggai Eran
[not found] ` <56D7F27D.1040702-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-03-03 8:31 ` Parav Pandit
2016-03-03 8:31 ` Parav Pandit
2016-03-01 19:05 ` [PATCHv9 2/3] IB/core: added support to use " Parav Pandit
2016-03-02 11:28 ` Haggai Eran
2016-03-02 11:28 ` Haggai Eran
2016-03-01 19:05 ` [PATCHv9 3/3] rdmacg: Added documentation for rdmacg Parav Pandit
2016-03-01 19:05 ` Parav Pandit
[not found] ` <1456859137-13646-1-git-send-email-pandit.parav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-03-02 17:40 ` [PATCHv9 0/3] rdmacg: IB/core: rdma controller support Tejun Heo
2016-03-02 17:40 ` Tejun Heo
[not found] ` <20160302174052.GH29826-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-03-02 19:22 ` Parav Pandit
2016-03-02 19:22 ` Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D7F27D.1040702@mellanox.com \
--to=haggaie@mellanox.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=dledford@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=james.l.morris@oracle.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=liranl@mellanox.com \
--cc=lizefan@huawei.com \
--cc=matanb@mellanox.com \
--cc=ogerlitz@mellanox.com \
--cc=pandit.parav@gmail.com \
--cc=raindel@mellanox.com \
--cc=sean.hefty@intel.com \
--cc=serge@hallyn.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.